- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: don't load disks for templates on search
by ofrenkel＠redhat.com 25 Feb '14

25 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: don't load disks for templates on search ...................................................................... core: don't load disks for templates on search When searching for templates, the search loads all the disks for each template. this is not necessary as disks are a different collection that need to be fetched upon request, also the disks are not used currently by the search initiators, and it make the templates search slow for systems with many templates. this patch removes the disks population on templates search. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064907 Change-Id: Ia83a3117f2c65bbb17972095cf3271eb39449cd6 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Omer Frenkel: Verified Liran Zelkha: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia83a3117f2c65bbb17972095cf3271eb39449cd6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove error messages from log when adding host
by emesika＠redhat.com 25 Feb '14

25 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: core: Remove error messages from log when adding host ...................................................................... core: Remove error messages from log when adding host When we add a host 3 errors on not finding vdsManager for the host appeared in the log. This patch fixes this issue. Change-Id: Ia17656dbfa0e16457565b04b849eb80ea74a8949 Bug-Url: https://bugzilla.redhat.com/1062438 Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RemoveVdsVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/AddVdsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RemoveVdsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsIdVDSCommandBase.java 7 files changed, 51 insertions(+), 11 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/24980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia17656dbfa0e16457565b04b849eb80ea74a8949 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : VMs do not appear in virtual machine tab if host is s...
by emesika＠redhat.com 25 Feb '14

25 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: core : VMs do not appear in virtual machine tab if host is selected in side pane ...................................................................... core : VMs do not appear in virtual machine tab if host is selected in side pane Vms do not appear in 'virtual machine' main tab if host is selected in webadmin side pane. screen shows empty (0 item) despite there are large number of vms running on the host. Change-Id: I8ac91785cdb8982349c1cd0364b5673d2817f9f2 Bug-Url: https://bugzilla.redhat.com/1063782 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmCrossRefAutoCompleter.java 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/24972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ac91785cdb8982349c1cd0364b5673d2817f9f2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine, webadmin: Edit Approve Host popup -> Cluster not u...
by emesika＠redhat.com 25 Feb '14

25 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: engine, webadmin: Edit Approve Host popup -> Cluster not updated ...................................................................... engine, webadmin: Edit Approve Host popup -> Cluster not updated The host cluster is not updated in the "Edit Approve Host" dialog. For oVirt node the cpu flags is null, so GetHostArchitectureQuery throws a NPE. When cpu flags is null, ArchitectureType.unknown is returned and the webadmin displays all clusters for data center if unknown is returned. Change-Id: I4b0357f07de5ac27902ceb250b7ef4c2e1642d08 Bug-Url: https://bugzilla.redhat.com/1056998 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetHostArchitectureQuery.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Ravi Nori: Verified Gilad Chaplik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b0357f07de5ac27902ceb250b7ef4c2e1642d08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Add host/Reinstall radio button text not actionable
by emesika＠redhat.com 25 Feb '14

25 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: webadmin: Add host/Reinstall radio button text not actionable ...................................................................... webadmin: Add host/Reinstall radio button text not actionable The radio buttons in Add/Reinstall host dialogs to select between password and SSH Key are not actionable. You can only click the radio button to change selection but not the text. Change-Id: I2baad8ec5f50b7022a348d6ef236691b3feaa804 Bug-Url: https://bugzilla.redhat.com/1035844 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2baad8ec5f50b7022a348d6ef236691b3feaa804 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: Revert "core: When ActivateVDS fails, move VDS out of Unassi...
by iheim＠redhat.com 25 Feb '14

25 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: Revert "core: When ActivateVDS fails, move VDS out of Unassigned status" ...................................................................... Revert "core: When ActivateVDS fails, move VDS out of Unassigned status" This reverts commit ae49a3b702c166c87d5e2992a5d12591cd785a3b as this solution is not standard. Change-Id: I4a91e20142f36de1ddae12bfcf63f684823e4358 Signed-off-by: lzelkha(a)redhat.com Bug-Url: https://bugzilla.redhat.com/962180 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Liran Zelkha: Verified -- To view, visit http://gerrit.ovirt.org/24974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a91e20142f36de1ddae12bfcf63f684823e4358 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: setup: split utilities into own module
by ydary＠redhat.com 25 Feb '14

25 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: split utilities into own module ...................................................................... packaging: setup: split utilities into own module Change-Id: Id938790964d913303a10ea068317960713f0180b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- A packaging/setup/ovirt_engine_setup/reportsutil.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 2 files changed, 176 insertions(+), 119 deletions(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id938790964d913303a10ea068317960713f0180b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: setup: file handling to own stage
by ydary＠redhat.com 25 Feb '14

25 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: file handling to own stage ...................................................................... packaging: setup: file handling to own stage Change-Id: Ib3464257d9e9ca8b18d374be199f89833f705499 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py 1 file changed, 22 insertions(+), 10 deletions(-) Approvals: Alon Bar-Lev: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3464257d9e9ca8b18d374be199f89833f705499 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3.4]: build: ovirt-engine-3.3.4
by sbonazzo＠redhat.com 25 Feb '14

25 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-engine-3.3.4 ...................................................................... build: ovirt-engine-3.3.4 Change-Id: Iac6f00af3cc766b3f65d790acfb6badfa9e09fed Bug-Url: https://bugzilla.redhat.com/1064462 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in M version.mak 2 files changed, 17 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Liran Zelkha: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac6f00af3cc766b3f65d790acfb6badfa9e09fed Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine-cli[cli_3.4]: cli: show command should retrieve sdk collection.get() metho...
by juan.hernandez＠redhat.com 25 Feb '14

25 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: show command should retrieve sdk collection.get() method's args dynamically ...................................................................... cli: show command should retrieve sdk collection.get() method's args dynamically show command should retrieve sdk collection.get() method's args dynamically, currently hardcoded id/name options being used. Change-Id: If9e0bce51f3a973049bffaa243aa1bd42e0ae25d Bug-Url: https://bugzilla.redhat.com/866448 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/command/command.py M src/ovirtcli/shell/showcmdshell.py 2 files changed, 42 insertions(+), 8 deletions(-) Approvals: Ravi Nori: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24973 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9e0bce51f3a973049bffaa243aa1bd42e0ae25d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0