- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: Drop ip--mtu from update host's nic api
by masayag＠redhat.com 26 Feb '14

26 Feb '14

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Drop ip--mtu from update host's nic api ...................................................................... restapi: Drop ip--mtu from update host's nic api There mtu is not a property of the IP element. Also, the update nic api doesn't support updating the nic's mtu directly. Change-Id: Iaafd159d6b489458ef8366f29838edf94b1afb28 Bug-Url: https://bugzilla.redhat.com/1049611 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24917 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaafd159d6b489458ef8366f29838edf94b1afb28 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Allow both "type" and "data"
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Allow both "type" and "data" ...................................................................... restapi: Allow both "type" and "data" The "type" and "data" elements used when importing a VM from a configuration are both allowed and needed, but they are specified as a XML schema "choice" instead of a "sequence". This patch fixes that. Change-Id: I6d67b5b14b908c503c1e7d7fffb2a303cc026557 Bug-Url: https://bugzilla.redhat.com/1069522 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 87b1d9acc9c5c1f01512b6b6e58aede9ad04b735) --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Ori Liel: Looks good to me, approved Juan Hernandez: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d67b5b14b908c503c1e7d7fffb2a303cc026557 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Bad vertical alignment in add user screen
by emesika＠redhat.com 26 Feb '14

26 Feb '14

Eli Mesika has submitted this change and it was merged. Change subject: webadmin: Bad vertical alignment in add user screen ...................................................................... webadmin: Bad vertical alignment in add user screen When adding a new user, the dropdown box for selecting the domain and the search box are misaligned Change-Id: I967023959027f2b977592cf8a6b61952960e24c3 Bug-Url: https://bugzilla.redhat.com/1057109 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.ui.xml 1 file changed, 14 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/24854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I967023959027f2b977592cf8a6b61952960e24c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core : VMs do not appear in virtual machine tab if host is s...
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core : VMs do not appear in virtual machine tab if host is selected in side pane ...................................................................... core : VMs do not appear in virtual machine tab if host is selected in side pane Vms do not appear in 'virtual machine' main tab if host is selected in webadmin side pane. screen shows empty (0 item) despite there are large number of vms running on the host. Change-Id: I8ac91785cdb8982349c1cd0364b5673d2817f9f2 Bug-Url: https://bugzilla.redhat.com/1063782 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmCrossRefAutoCompleter.java 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ac91785cdb8982349c1cd0364b5673d2817f9f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Add host/Reinstall radio button text not actionable
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Add host/Reinstall radio button text not actionable ...................................................................... webadmin: Add host/Reinstall radio button text not actionable The radio buttons in Add/Reinstall host dialogs to select between password and SSH Key are not actionable. You can only click the radio button to change selection but not the text. Change-Id: I2baad8ec5f50b7022a348d6ef236691b3feaa804 Bug-Url: https://bugzilla.redhat.com/1035844 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2baad8ec5f50b7022a348d6ef236691b3feaa804 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine, webadmin: Edit Approve Host popup -> Cluster not upd...
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine, webadmin: Edit Approve Host popup -> Cluster not updated ...................................................................... engine, webadmin: Edit Approve Host popup -> Cluster not updated The host cluster is not updated in the "Edit Approve Host" dialog. For oVirt node the cpu flags is null, so GetHostArchitectureQuery throws a NPE. When cpu flags is null, ArchitectureType.unknown is returned and the webadmin displays all clusters for data center if unknown is returned. Change-Id: I4b0357f07de5ac27902ceb250b7ef4c2e1642d08 Bug-Url: https://bugzilla.redhat.com/1056998 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetHostArchitectureQuery.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Ravi Nori: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b0357f07de5ac27902ceb250b7ef4c2e1642d08 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: tools: Fix error if LDAP server cannot be resolved
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: tools: Fix error if LDAP server cannot be resolved ...................................................................... tools: Fix error if LDAP server cannot be resolved Fixes error message in engine-manage-domains if LDAP server cannot be resolved. Change-Id: I8a234d08979b97d8695bb3b7afb76e6998b38c87 Bug-Url: https://bugzilla.redhat.com/1001976 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a234d08979b97d8695bb3b7afb76e6998b38c87 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core+setup: adding the public glance repository
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core+setup: adding the public glance repository ...................................................................... core+setup: adding the public glance repository This patch adds a stored procedure to add the public glance repository, and in addition a setup plugin that uses it, if needed. Change-Id: I415dd452f644e1adf150713f3dfdc094ae9af160 Bug-Url: https://bugzilla.redhat.com/1053544 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> (cherry picked from commit 146b9c89e8cc4ddfd05fb038cdaf6d6c126e2845) --- M packaging/dbscripts/inst_sp.sql M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/__init__.py A packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/public_glance_repository.py 4 files changed, 113 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, but someone else must approve Eli Mesika: Looks good to me, but someone else must approve Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I415dd452f644e1adf150713f3dfdc094ae9af160 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: don't load disks for templates on search
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: don't load disks for templates on search ...................................................................... core: don't load disks for templates on search When searching for templates, the search loads all the disks for each template. this is not necessary as disks are a different collection that need to be fetched upon request, also the disks are not used currently by the search initiators, and it make the templates search slow for systems with many templates. this patch removes the disks population on templates search. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064907 Change-Id: Ia83a3117f2c65bbb17972095cf3271eb39449cd6 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 1 file changed, 2 insertions(+), 10 deletions(-) Approvals: Omer Frenkel: Verified Arik Hadas: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/25035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia83a3117f2c65bbb17972095cf3271eb39449cd6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: fix cpu info for AMD Opterom Processor G5
by iheim＠redhat.com 26 Feb '14

26 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: fix cpu info for AMD Opterom Processor G5 ...................................................................... core: fix cpu info for AMD Opterom Processor G5 Fix for detecting AMD Opteron Processor G5 as AMD Opteron Processor G4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1064880 Change-Id: Ica30c91f572229e9cbd0277dd84852c8f99bd50e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/24961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica30c91f572229e9cbd0277dd84852c8f99bd50e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0