- Engine-commits - oVirt List Archives

Change in ovirt-release[master]: add EL6 derived distribution support
by sbonazzo＠redhat.com 24 Feb '14

24 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: add EL6 derived distribution support ...................................................................... add EL6 derived distribution support Change-Id: Id3c8c356c59fc99f091103f929dda74045214ef8 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> Signed-off-by: Jimmy Dorff <jdorff(a)phy.duke.edu> --- M ovirt-release.spec.in 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24869 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3c8c356c59fc99f091103f929dda74045214ef8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Dave Neary <dneary(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Jimmy Dorff <jdorff(a)phy.duke.edu> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Meital Bourvine <mbourvin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.4]: build: ovirt-log-collector-3.4.0
by sbonazzo＠redhat.com 24 Feb '14

24 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-log-collector-3.4.0 ...................................................................... build: ovirt-log-collector-3.4.0 Change-Id: Ie9a1f76e719c362c1dd118b2e88a18d0450a5064 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-log-collector.spec.in 2 files changed, 7 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9a1f76e719c362c1dd118b2e88a18d0450a5064 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.4 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Block cluster change if network labels not supported
by iheim＠redhat.com 23 Feb '14

23 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Block cluster change if network labels not supported ...................................................................... engine: Block cluster change if network labels not supported Network labels are supported only if setup networks is supported by the cluster level. Therefore a host which has network labels shouldn't be moved to a cluster which doesn't support it, without removing the labels from the interfaces. Change-Id: I918905e2e5ca01726a0a647109b11e1bbeb5596a Bug-Url: https://bugzilla.redhat.com/1063285 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 36 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I918905e2e5ca01726a0a647109b11e1bbeb5596a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: prevent illegal disk on custom preview active snapshot
by iheim＠redhat.com 23 Feb '14

23 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: prevent illegal disk on custom preview active snapshot ...................................................................... core: prevent illegal disk on custom preview active snapshot * SnapshotVmConfigurationHelper: avoid marking disks as illegal for a 'PREVIEW' snapshot as it represents previous 'Active VM' state. * SnapshotsManager -> attempToRestoreVmConfigurationFromSnapshot: updating images according the specified list when VmConfiguration is not available - i.e. custom snapshotting to active VM (prevents a possible scenario of missing disks on active VM). Change-Id: I1561107e05de155f9483e1f8a00d2dba3a4ab342 Bug-Url: https://bugzilla.redhat.com/1064067 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24890 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1561107e05de155f9483e1f8a00d2dba3a4ab342 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: SyncLunsInfo when activating FC storage domain
by iheim＠redhat.com 23 Feb '14

23 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: SyncLunsInfo when activating FC storage domain ...................................................................... core: SyncLunsInfo when activating FC storage domain * Invoke SyncLunsInfoForBlockStorageDomainCommand on FCPStorageHelper -> connectStorageToDomainByVdsId. * Renamed SyncLunsInfoForIscsiStorageDomainCommand to SyncLunsInfoForBlockStorageDomainCommand for defining its purpose accurately. Change-Id: I31f3e376120e7b30a74af8d1fc7e3ed5346411f8 Bug-Url: https://bugzilla.redhat.com/1066081 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 5 files changed, 14 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31f3e376120e7b30a74af8d1fc7e3ed5346411f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: fix flow of FC DirectLUN disk creation
by iheim＠redhat.com 23 Feb '14

23 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: fix flow of FC DirectLUN disk creation ...................................................................... core: fix flow of FC DirectLUN disk creation StorageDomainCommandBase -> proceedLUNInDb: prevent connections handling for FCP storage (FCP storage doesn't utilize connections). Change-Id: Icf0fbd892b4c8549380b4394c8a4545de1da2343 Bug-Url: https://bugzilla.redhat.com/1065014 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf0fbd892b4c8549380b4394c8a4545de1da2343 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Allow manual fence in connecting state
by iheim＠redhat.com 23 Feb '14

23 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Allow manual fence in connecting state ...................................................................... core: Allow manual fence in connecting state Allow to manually fence a Host that is in Connecting state. Up to now, when host had a network problem, it was switched to Connecting state for 3 attempts, after those attempts, if host was still unreachable, the host was turned to non-responding status. During the Connecting status, if you would try to manually fence the host, you would get an error saying: "Due to intermittent connectivity to this Host, fence operations are not allowed at this time. The system is trying to reconnect, please try again in 30 seconds." If an outage problem occurs, this limitation forces us to wait for all 3 network reconnect attempts before we can confirm that the host was rebooted and perform a manual fence (which can take several minutes) This patch removes this limitation and allow manually fencing a host that is in the Connecting state. Change-Id: I37a63d299244bc88a35e9c264e696ac88e6d7ef0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1066400 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java 1 file changed, 3 insertions(+), 8 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Eli Mesika: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24627 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37a63d299244bc88a35e9c264e696ac88e6d7ef0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Correct timezone offset for Sri Lanka
by ofrenkel＠redhat.com 23 Feb '14

23 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Correct timezone offset for Sri Lanka ...................................................................... engine: Correct timezone offset for Sri Lanka The offset should be GMT+05:30 instead of GMT+06:00 Change-Id: I2243780f409443e6d9a59eb89b30076a47ae1707 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1045681 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Betak: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2243780f409443e6d9a59eb89b30076a47ae1707 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: customization fixed capitalizing in patch
by ydary＠redhat.com 23 Feb '14

23 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: customization fixed capitalizing in patch ...................................................................... packaging: customization fixed capitalizing in patch Change-Id: Id72b0a26be20a7d99e971b99facd891505ec144d Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/jasper-war-patches/300_003_jsp_rebrand-tab-headers.patch 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id72b0a26be20a7d99e971b99facd891505ec144d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: block migration for paused vm only in case of an error
by ofrenkel＠redhat.com 23 Feb '14

23 Feb '14

Omer Frenkel has submitted this change and it was merged. Change subject: core: block migration for paused vm only in case of an error ...................................................................... core: block migration for paused vm only in case of an error We used to block migration for every VM which is in paused state but actually VMs which are in paused state not due to an error should be able to migrate so we should not block it for such VMs. Change-Id: Ic6e7a7d41fcf66e2d3c13b93de7dd68b42aeaecb Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 17 insertions(+), 12 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6e7a7d41fcf66e2d3c13b93de7dd68b42aeaecb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0