- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: SyncLunsInfo when activating FC storage domain
by derez＠redhat.com 23 Feb '14

23 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: core: SyncLunsInfo when activating FC storage domain ...................................................................... core: SyncLunsInfo when activating FC storage domain * Invoke SyncLunsInfoForBlockStorageDomainCommand on FCPStorageHelper -> connectStorageToDomainByVdsId. * Renamed SyncLunsInfoForIscsiStorageDomainCommand to SyncLunsInfoForBlockStorageDomainCommand for defining its purpose accurately. Change-Id: I31f3e376120e7b30a74af8d1fc7e3ed5346411f8 Bug-Url: https://bugzilla.redhat.com/1066081 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/SyncLunsInfoForIscsiStorageDomainCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 5 files changed, 14 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31f3e376120e7b30a74af8d1fc7e3ed5346411f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Reorder network actions when changing host cluster
by iheim＠redhat.com 23 Feb '14

23 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Reorder network actions when changing host cluster ...................................................................... engine: Reorder network actions when changing host cluster When moving host between clusters, there is a need to first clear all the labeled networks originated in the source cluster. Second, to add all of the labeled networks according to the target cluster attachment. The reason for it is to deallocate assigned interfaces which were assigned with networks of the source cluster. Change-Id: I1ea644edbe7e3d314d4d1baf8a45b52d7a5a8f95 Bug-Url: https://bugzilla.redhat.com/1064953 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ea644edbe7e3d314d4d1baf8a45b52d7a5a8f95 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Modify EnableMACAntiSpoofing version to general
by iheim＠redhat.com 23 Feb '14

23 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Modify EnableMACAntiSpoofing version to general ...................................................................... engine: Modify EnableMACAntiSpoofing version to general There used to be a mix in the declaration and usage of MacAntiSpoofingFilterRulesSupported configuration value which allowed the user to determine in which cluster level the feature should be used. This should be determined by the engine itself and not by the user. Therefore the versioning is removed from this parameter which will define for the entire system if no-mac-spoofing filter should be applied to running vms or not. Change-Id: Ia2c7659844318dd38241a6ae56895ca3c4bf91cf ug-Url: https://bugzilla.redhat.com/1063711 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 4 files changed, 16 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia2c7659844318dd38241a6ae56895ca3c4bf91cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix flow of FC DirectLUN disk creation
by derez＠redhat.com 23 Feb '14

23 Feb '14

Daniel Erez has submitted this change and it was merged. Change subject: core: fix flow of FC DirectLUN disk creation ...................................................................... core: fix flow of FC DirectLUN disk creation StorageDomainCommandBase -> proceedLUNInDb: prevent connections handling for FCP storage (FCP storage doesn't utilize connections). Change-Id: Icf0fbd892b4c8549380b4394c8a4545de1da2343 Bug-Url: https://bugzilla.redhat.com/1065014 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, but someone else must approve Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf0fbd892b4c8549380b4394c8a4545de1da2343 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin: New Data Center "Guide Me" does not reflect hosts ...
by iheim＠redhat.com 21 Feb '14

21 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: New Data Center "Guide Me" does not reflect hosts presence ...................................................................... webadmin: New Data Center "Guide Me" does not reflect hosts presence DataCenter guide me dialog does not reflect the presence of hosts. "Configure Host" button appears under "There are still unconfigured entities:" even when hosts exist in the datacenter. Change-Id: I6dbbac65e439f0d58b4104da8e1acb2860e7556c Bug-Url: https://bugzilla.redhat.com/1023330 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 13 insertions(+), 2 deletions(-) Approvals: Ravi Nori: Verified Itamar Heim: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6dbbac65e439f0d58b4104da8e1acb2860e7556c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Do not cast memory.used to int
by juan.hernandez＠redhat.com 21 Feb '14

21 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Do not cast memory.used to int ...................................................................... restapi: Do not cast memory.used to int Casting the computed value to int caused an overflow when the value was higher than about 4G. That is not that unusual nowadays.. Change-Id: I216ac4ef5cf4cfd8cf523a84f75b252e0ce65ad0 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/VmStatisticalQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I216ac4ef5cf4cfd8cf523a84f75b252e0ce65ad0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Cloud init wants DNS inside interface
by juan.hernandez＠redhat.com 21 Feb '14

21 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: core: Cloud init wants DNS inside interface ...................................................................... core: Cloud init wants DNS inside interface Cloud-init expects the DNS information inside the network interface definition, like this: iface eth0 inet static address 192.168.0.1 netmask 255.255.255.0 gateway 192.168.0.1 dns-nameservers 1.1.1.1 2.2.2.2 dns-search example.com auto eth0 But we put it outside, like this: dns-nameservers 1.1.1.1 2.2.2.2 dns-search example.com iface eth0 inet static address 192.168.0.1 netmask 255.255.255.0 gateway 192.168.0.1 auto eth0 The way we do it looks more correct, as the list of name servers and search domains isn't specific to a network interface, but common to all of them. But cloud-init doesn't like this. This patch changes the engine so that it generates the format that cloud-init wants. Change-Id: I79f758544496bedaf4e220639a9768a2518579f6 Bug-Url: https://bugzilla.redhat.com/1067906 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java 1 file changed, 13 insertions(+), 13 deletions(-) Approvals: Greg Padgett: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/24850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79f758544496bedaf4e220639a9768a2518579f6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: 1. [WIP] core: Changing UserDomainsCacheManager to be a regu...
by yzaslavs＠redhat.com 21 Feb '14

21 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: 1. [WIP] core: Changing UserDomainsCacheManager to be a regular singleton ...................................................................... 1. [WIP] core: Changing UserDomainsCacheManager to be a regular singleton There is no particular need for this to be an EJB singleton. Change-Id: I68d4cff4ecf7bbf0052d0473f9a833e17b4e8d1c Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/UsersDomainsCacheManagerService.java 2 files changed, 16 insertions(+), 33 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68d4cff4ecf7bbf0052d0473f9a833e17b4e8d1c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: Add more files to .gitignore
by msivak＠redhat.com 21 Feb '14

21 Feb '14

Martin Sivák has submitted this change and it was merged. Change subject: Add more files to .gitignore ...................................................................... Add more files to .gitignore Change-Id: I694be218c187ec1d531a426dfcf76f8c8764da2a Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit b8f29d2197589247cf70108da76218e8d6a30d1c) --- M .gitignore 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I694be218c187ec1d531a426dfcf76f8c8764da2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.1 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: Document the Agent FSM using docstrings and autogenerate the...
by msivak＠redhat.com 21 Feb '14

21 Feb '14

Martin Sivák has submitted this change and it was merged. Change subject: Document the Agent FSM using docstrings and autogenerate the graphviz sources ...................................................................... Document the Agent FSM using docstrings and autogenerate the graphviz sources This adds two special lines to state class docstrings: :transition[ destination]: description - describes transition from current class to destination - it is treated as staying in the current state when destination is not provided :transitions_from StateClass: - used to support inheritance, copies all transitions from StateClass to the current class This patch also adds a script that reads the state_machine.py and states.py modules and generates the fill graphviz source for the state machine. make fsm then generates the new source and png file with the state machine. Change-Id: Ie6de8b20a8908aa0906404283829775b5487a850 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 21a18395a2b9d8724a3712910e20efaed78ae3ac) --- M Makefile.am A build/build-aux/gen_gv.py M doc/agent-fsm.gv M ovirt_hosted_engine_ha/agent/state_machine.py M ovirt_hosted_engine_ha/agent/states.py 5 files changed, 258 insertions(+), 31 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6de8b20a8908aa0906404283829775b5487a850 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.1 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

1 0