- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: core: Fixing I18N validation to allow empty strings
by iheim＠redhat.com 18 Feb '14

18 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Fixing I18N validation to allow empty strings ...................................................................... core: Fixing I18N validation to allow empty strings The I18N validation in the validation framework was set to pass validation an empty string, this behavior is incorrect since the I18N validation should only care for extisting characters within the string and since an empty string contains no illegal characters, validation should pass, for validating a strings length the size validation should be used. The regular expression was changed to pass validation on an empty string and the places which used this validation without minimum string length validation were changed to validate a minimum string length of 1 in order not to have regressions. This solves a validation problem when creating a VM disk via REST and not specifying an alias, validation should not fail in that case and an alias should be generated by the add disk command Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1065727 Change-Id: I6d6cf47a0ccaf1d8af3d46e5dee9c264e9a29bb3 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Tags.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d6cf47a0ccaf1d8af3d46e5dee9c264e9a29bb3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Removed JDK7 ConfigurationException ctor
by iheim＠redhat.com 18 Feb '14

18 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Removed JDK7 ConfigurationException ctor ...................................................................... core: Removed JDK7 ConfigurationException ctor Removed ConfigurationException(String, Throwable, boolean, boolean). This constructor was introduced to RuntimeException in JDK7, and having it in the common project breaks JDK6 compatibility required for GWT compilation. Change-Id: I057c641a8f05b789bb69e15d524588ba3f0f42fd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/ConfigurationException.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Allon Mureinik: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I057c641a8f05b789bb69e15d524588ba3f0f42fd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Allow searching data center with local property
by iheim＠redhat.com 18 Feb '14

18 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Allow searching data center with local property ...................................................................... core: Allow searching data center with local property Change-Id: Ica5bfded3a0464c7315ec636cc44b3280cc5921e Bug-url: https://bugzilla.redhat.com/1065941 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StoragePoolFieldAutoCompleter.java 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica5bfded3a0464c7315ec636cc44b3280cc5921e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-cli[cli_3.4]: cli: Prepare for next release
by juan.hernandez＠redhat.com 18 Feb '14

18 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Prepare for next release ...................................................................... cli: Prepare for next release In preparation for the next release this patch increases the version number and sets the RPM release number to 0.1. Change-Id: If7c2095b582eb51848079a0eed6ddf1bb2ffd9f1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24660 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7c2095b582eb51848079a0eed6ddf1bb2ffd9f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.4]: cli: Release 3.4.0.4
by juan.hernandez＠redhat.com 18 Feb '14

18 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Release 3.4.0.4 ...................................................................... cli: Release 3.4.0.4 Change-Id: I2a6fae6091c96f0206023f40dd9d69be031312ae Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in 2 files changed, 6 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a6fae6091c96f0206023f40dd9d69be031312ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[sdk_3.4]: sdk: Prepare for the next release
by juan.hernandez＠redhat.com 18 Feb '14

18 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Prepare for the next release ...................................................................... sdk: Prepare for the next release In preparation for the next release this patch increases the micro version number, adds the SNAPHSOT suffixs to the maven version and sets the RPM release number to 0.1. Change-Id: I35087d2c0650d5cc69dc9061aed13cace6e970a5 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java/Makefile M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in M ovirt-engine-sdk-java/pom.xml 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35087d2c0650d5cc69dc9061aed13cace6e970a5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[sdk_3.4]: sdk: Release 3.4.0.4
by juan.hernandez＠redhat.com 18 Feb '14

18 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Release 3.4.0.4 ...................................................................... sdk: Release 3.4.0.4 Change-Id: I48bee5a1a3a5e4018bd4521033befbb5556882f1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java/Makefile M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in M ovirt-engine-sdk-java/pom.xml 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48bee5a1a3a5e4018bd4521033befbb5556882f1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[sdk_3.4]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com 18 Feb '14

18 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate against the latest API ...................................................................... sdk: Regenerate against the latest API This patch regenerates the SDK using the latest API obtained from the engine built from commit 089a28b. Relevant changes: - Added allContent parameter to relevant methods. Change-Id: Ie4025cc23680bc66b93f58f84b6c80f9248ccec6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/src/main/resources/api.rsdl M ovirt-engine-sdk-java-codegen/src/main/resources/api.xsd M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Templates.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMNICs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/GuestNicsConfiguration.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Initialization.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java 8 files changed, 148 insertions(+), 82 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4025cc23680bc66b93f58f84b6c80f9248ccec6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Potential NullPointerException at Entities.ObjectNames...
by gchaplik＠redhat.com 18 Feb '14

18 Feb '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Potential NullPointerException at Entities.ObjectNames method ...................................................................... core: Potential NullPointerException at Entities.ObjectNames method The method accepts a list that could contain null elements. In case one or more of the elements in the list is null, an exception will be thrown. Change-Id: If282b7a525800ffcb9a6f73292f01de3fca810d0 Bug-Url: https://bugzilla.redhat.com/1063173 Signed-off-by: Kobi Ianko <kobi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If282b7a525800ffcb9a6f73292f01de3fca810d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: HA Vm reservation check failure event log is not well ...
by gchaplik＠redhat.com 18 Feb '14

18 Feb '14

Gilad Chaplik has submitted this change and it was merged. Change subject: core: HA Vm reservation check failure event log is not well resolved ...................................................................... core: HA Vm reservation check failure event log is not well resolved Making the event log message more user readable, using the host name and not the toString. Change-Id: I245f8eea3a955bcd8e75c574c572cf2608452d68 Bug-Url: https://bugzilla.redhat.com/1057584 Signed-off-by: Kobi Ianko <kobi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I245f8eea3a955bcd8e75c574c572cf2608452d68 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0