- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fixing I18N validation to allow empty strings
by tnisan＠redhat.com 18 Feb '14

18 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Fixing I18N validation to allow empty strings ...................................................................... core: Fixing I18N validation to allow empty strings The I18N validation in the validation framework was set to pass validation an empty string, this behavior is incorrect since the I18N validation should only care for extisting characters within the string and since an empty string contains no illegal characters, validation should pass, for validating a strings length the size validation should be used. The regular expression was changed to pass validation on an empty string and the places which used this validation without minimum string length validation were changed to validate a minimum string length of 1 in order not to have regressions. This solves a validation problem when creating a VM disk via REST and not specifying an alias, validation should not fail in that case and an alias should be generated by the add disk command Signed-off-by: Tal Nisan <tnisan(a)redhat.com> https://bugzilla.redhat.com/show_bug.cgi?id=1065727 Change-Id: I6d6cf47a0ccaf1d8af3d46e5dee9c264e9a29bb3 --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Tags.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d6cf47a0ccaf1d8af3d46e5dee9c264e9a29bb3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in otopi[otopi-1.1]: packaging: post otopi-1.1.3
by Alon Bar-Lev 18 Feb '14

18 Feb '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: post otopi-1.1.3 ...................................................................... packaging: post otopi-1.1.3 Change-Id: I731d5d030a3e0462a1f58d37f509252cb21a19c1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I731d5d030a3e0462a1f58d37f509252cb21a19c1 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.1 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[otopi-1.1]: packaging: otopi-1.1.3
by Alon Bar-Lev 18 Feb '14

18 Feb '14

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: otopi-1.1.3 ...................................................................... packaging: otopi-1.1.3 Change-Id: I7688781ad0668e2985e5725778245ef55e191051 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac M otopi.spec.in 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7688781ad0668e2985e5725778245ef55e191051 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.1 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.4]: sdk: Prepare for next release
by juan.hernandez＠redhat.com 18 Feb '14

18 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Prepare for next release ...................................................................... sdk: Prepare for next release In preparation for the next release this patch increases the version number and sets the RPM release number to 0.1. Change-Id: I52e599f0d7194fb73ed3efbc229cb48a0ec4ee22 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52e599f0d7194fb73ed3efbc229cb48a0ec4ee22 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.4]: sdk: Release 3.4.0.4
by juan.hernandez＠redhat.com 18 Feb '14

18 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Release 3.4.0.4 ...................................................................... sdk: Release 3.4.0.4 Change-Id: I612356ba853162c7be6ed72c834f93327d8125e0 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M ovirt-engine-sdk-python.spec.in 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I612356ba853162c7be6ed72c834f93327d8125e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-sdk[sdk_3.4]: sdk: Regenerate against the latest API
by juan.hernandez＠redhat.com 18 Feb '14

18 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Regenerate against the latest API ...................................................................... sdk: Regenerate against the latest API This patch regenerates the SDK using the latest API obtained from the engine built from commit 089a28b. Relevant changes: - Added all_content parameter to relevant methods. - Added disks collection to Snapshot. - Added external_id property to User and Group. - Added ha_reservation property to Cluster. - Added ksm.enabled property to Cluster. - Added local property to DataCenter. - Added migration_downtime property to VM and Template. - Added network label support. - Added power_management.automatic_pm_enabled property to Host. - Added reboot method to VM. - Added sso.methods property to VM and Template. - Removed storage_type property from DataCenter. Change-Id: I7807cae801e632111fe91242de064da54b94e3e4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 2 files changed, 1,735 insertions(+), 35 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7807cae801e632111fe91242de064da54b94e3e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.4]: cli: Add example of search with quotes
by juan.hernandez＠redhat.com 18 Feb '14

18 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Add example of search with quotes ...................................................................... cli: Add example of search with quotes This patch adds to the documentation of the list command an example of how to use quotes when the search text contains spaces. Change-Id: I4ca3f77a33bdec56b4d6630a73e9c3b38a6e7e40 Bug-Url: https://bugzilla.redhat.com/1065945 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 2f02ed1d2822e6bad236ddf74b3bed12b567348a) --- M src/ovirtcli/command/list.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ca3f77a33bdec56b4d6630a73e9c3b38a6e7e40 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: Add example of search with quotes
by juan.hernandez＠redhat.com 18 Feb '14

18 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Add example of search with quotes ...................................................................... cli: Add example of search with quotes This patch adds to the documentation of the list command an example of how to use quotes when the search text contains spaces. Change-Id: I4ca3f77a33bdec56b4d6630a73e9c3b38a6e7e40 Bug-Url: https://bugzilla.redhat.com/1065945 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M src/ovirtcli/command/list.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/24622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ca3f77a33bdec56b4d6630a73e9c3b38a6e7e40 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ilia Meerovich <imeerovi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Disabling an SD with unplugged disk of a VM
by amureini＠redhat.com 18 Feb '14

18 Feb '14

Allon Mureinik has submitted this change and it was merged. Change subject: core: Disabling an SD with unplugged disk of a VM ...................................................................... core: Disabling an SD with unplugged disk of a VM Prior to this patch, when disabling a Storage Domain the canDoAction() would check that it does not contain any disks in that belong to running VM, and if it does, the command is failed. This behavior is overly strict, and we should be able to disable a domain which contains unplugged disks, even if they are attached to a running VM. This patch contains: 1. Changing the GetVmsByStorageDomainId stored procedure to take only plugged disks in to account. 2. In fixtures.xml, plugging disk 1b26a52b-b60f-44cb-9f46-3ef333b04a35 into VM 77296e00-0cad-4e5a-9299-008a7b6f4355, as opposed to just attaching it in order for this fix to be tested. 3. Updating the DAO tests accordingly. Change-Id: I89d119295cf16eb1ea2df365fb22cadde6595e6a Bug-Url: https://bugzilla.redhat.com/969770 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/vms_sp.sql 6 files changed, 30 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89d119295cf16eb1ea2df365fb22cadde6595e6a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: build: ovirt-hosted-engine-ha-1.1.0-0.2.beta2
by dfediuck＠redhat.com 18 Feb '14

18 Feb '14

Doron Fediuck has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-1.1.0-0.2.beta2 ...................................................................... build: ovirt-hosted-engine-ha-1.1.0-0.2.beta2 Change-Id: I67489b82db8e26624e1bc8343adc000b1cc1e41f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24610 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67489b82db8e26624e1bc8343adc000b1cc1e41f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0