- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi : JAXBMarshallingException are not propogated
by juan.hernandez＠redhat.com 17 Feb '14

17 Feb '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi : JAXBMarshallingException are not propogated ...................................................................... restapi : JAXBMarshallingException are not propogated When invalid xml is submitted to restapi, the JAXBMarshallingException is not propogated to the client. Change-Id: I2a3913b4b063bc7cff3f972a68f8c5fb7fccc1a1 Bug-Url: https://bugzilla.redhat.com/1064572 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/JaxbMarshallExceptionMapper.java 2 files changed, 43 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a3913b4b063bc7cff3f972a68f8c5fb7fccc1a1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8520(a)yahoo.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: allinone: Prevent on upgrade
by sbonazzo＠redhat.com 17 Feb '14

17 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: allinone: Prevent on upgrade ...................................................................... packaging: setup: allinone: Prevent on upgrade Only allow all-in-one on a clean install. Bug-Url: https://bugzilla.redhat.com/1063869 Change-Id: I91d94c2d17be0ecf39bb5aa40c602a20926bf283 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/core.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Ofer Schreiber: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/24334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91d94c2d17be0ecf39bb5aa40c602a20926bf283 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: modify log message on live snapshot failure
by laravot＠redhat.com 17 Feb '14

17 Feb '14

Liron Ar has submitted this change and it was merged. Change subject: core: modify log message on live snapshot failure ...................................................................... core: modify log message on live snapshot failure The log message that was printed when live snapshot failed contained the word "Wasn't" which appears in the log file as "Wasnt". That is confusing because if you use copy-paste in order to look for it in the log file you won't find it. Thus, the log message is changed. Change-Id: Iee77b46be0948ab90de2e9ea438ef9e9b4413546 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Arik Hadas: Verified Liron Ar: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee77b46be0948ab90de2e9ea438ef9e9b4413546 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-node-plugin-vdsm[master]: engine_page: display url/port only on availble
by dougsland＠redhat.com 17 Feb '14

17 Feb '14

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: engine_page: display url/port only on availble ...................................................................... engine_page: display url/port only on availble Do not show URL and PORT on status page if we don't have these data available. Change-Id: If2d64a3d0c3530432544afbf3fe8a8155a2698d2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057453 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/engine_page.py 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2d64a3d0c3530432544afbf3fe8a8155a2698d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: findbugs possible null pointer dereference
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: findbugs possible null pointer dereference ...................................................................... engine: findbugs possible null pointer dereference fix from commit d46ebd8712f369b924e199b82197e59568a686ff Change-Id: Icb9829514f49cb7f371b31acc018112beda477fb Bug-Url: https://bugzilla.redhat.com/1051041 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb9829514f49cb7f371b31acc018112beda477fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: UI: add info tooltip for Cloud-Init custom script
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: UI: add info tooltip for Cloud-Init custom script ...................................................................... UI: add info tooltip for Cloud-Init custom script Bug-Url: https://bugzilla.redhat.com/1051041 Change-Id: Id3990c7ccc646f3c9653993a36c3b1c5668a453f Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml 3 files changed, 23 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/24509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3990c7ccc646f3c9653993a36c3b1c5668a453f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Suggest --help on failure
by sbonazzo＠redhat.com 17 Feb '14

17 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Suggest --help on failure ...................................................................... packaging: engine-backup: Suggest --help on failure Also added to --help a link to the wiki page. Bug-Url: https://bugzilla.redhat.com/1064903 Change-Id: I6021095d229df8279f5b593f2a6619867d4fcc99 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/24542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6021095d229df8279f5b593f2a6619867d4fcc99 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: NPE when trying to run Windows with no Domain
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: NPE when trying to run Windows with no Domain ...................................................................... engine: NPE when trying to run Windows with no Domain Change-Id: I897a372ebe8cc7575b2a3824cad7accfbc1874e3 Bug-Url:https://bugzilla.redhat.com/1063883 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I897a372ebe8cc7575b2a3824cad7accfbc1874e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: UI: Prevent dialog close when pressing Enter in TextArea
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: UI: Prevent dialog close when pressing Enter in TextArea ...................................................................... UI: Prevent dialog close when pressing Enter in TextArea By default add/edit VM dialog close when pressing Enter (for fast navigation), This is a problem while edition TextArea when the enter key is used. Bug-Url: https://bugzilla.redhat.com/1051041 Change-Id: I436d4ab656d2739a9681a6b3d2f80038eb0c2063 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EnterIgnoringFocusHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelTextAreaEditor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/EntityModelTextAreaEditor.java 3 files changed, 90 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/24507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I436d4ab656d2739a9681a6b3d2f80038eb0c2063 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: Remove IteratorUtils class
by tnisan＠redhat.com 17 Feb '14

17 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Remove IteratorUtils class ...................................................................... frontend: Remove IteratorUtils class Since we changed the items held in the ListModel from Iterable to Collection, we can now remove IteratorUtils as it's redundant, instead of iterating on the Iterable we can just use the size() method that Collection object has Change-Id: Iace61d708d6e66da4b898a6d6069136e1c838c4f Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/IteratorUtils.java 2 files changed, 2 insertions(+), 42 deletions(-) Approvals: Tal Nisan: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iace61d708d6e66da4b898a6d6069136e1c838c4f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0