- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: engine: CloudInit custom script section
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: CloudInit custom script section ...................................................................... engine: CloudInit custom script section Custom Script: User can add arbitrary CloudInit section in additional to the defaults (such as hostname, timezone etc) User can add files and other non supported sections. This will add two new files: write_files: - content: | # some file content path: /root/myfile - encoding: b64 content: CiMgVGhpcyBmaWxlIGNvbnRyb2xzIHRoZSBzdGF0ZSBvZiBTRUxpbnV4... owner: root:root path: /etc/sysconfig/selinux permissions: '0644' Bug-Url: https://bugzilla.redhat.com/1051041 Change-Id: Ibbe4107401cc5add22a519f6a18bad96f1055615 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java 1 file changed, 4 insertions(+), 8 deletions(-) Approvals: Shahar Havivi: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibbe4107401cc5add22a519f6a18bad96f1055615 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: UI: set the default initial run to false in RunOnce dialog
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: UI: set the default initial run to false in RunOnce dialog ...................................................................... UI: set the default initial run to false in RunOnce dialog We change the default to false only if the is_initialized flag is true (ie the user already run/initialize the VM), Assuming that the user don't want to re-initialize the VM again. Change-Id: I2ac2eeee70d1fb4db2712b5407ee3e778e7293c1 Bug-Url: https://bugzilla.redhat.com/1051041 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ac2eeee70d1fb4db2712b5407ee3e778e7293c1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: VmInit root-password not fetch from DB
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: VmInit root-password not fetch from DB ...................................................................... engine: VmInit root-password not fetch from DB By default we don't fetch the password when getting VmInit for security reasons (we don't want to display the password in plain text via API or in the source code of the UI). For this reason the password was not copy when creating a Template, New Pool. Bug-Url: https://bugzilla.redhat.com/1051041 Change-Id: I9206906e3b61551023b21e4358663a4842018c7c Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 3 files changed, 28 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9206906e3b61551023b21e4358663a4842018c7c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: UI: add indication the VMInit root password is set
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: UI: add indication the VMInit root password is set ...................................................................... UI: add indication the VMInit root password is set Since we are not returning the password on edit VM, we need to let the user know that the password is set. Bug-Url: https://bugzilla.redhat.com/1051041 Change-Id: Iedfea8520e885c948772dd0d1b612296aeced895 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInit.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInitModel.java 6 files changed, 85 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified -- To view, visit http://gerrit.ovirt.org/24503 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iedfea8520e885c948772dd0d1b612296aeced895 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: webadmin, userportal: Small ScrollableTabBar improvements
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: webadmin,userportal: Small ScrollableTabBar improvements ...................................................................... webadmin,userportal: Small ScrollableTabBar improvements 1. ScrollableTabBarView: - removed "implements HasLoadHandlers" - removed fireEvent + addLoadHandler methods - the "+1 width adjustment" comment moved to appropriate location 2. ModelBoundTab: - added setAccessible override that fires TabAccessibleChangeEvent whenever tab's accessibility changes Change-Id: Ib7ffdb2827067b35320fd43d37db80479df6605d Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ScrollableTabBarView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/ModelBoundTab.java 2 files changed, 15 insertions(+), 19 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit http://gerrit.ovirt.org/24478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7ffdb2827067b35320fd43d37db80479df6605d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: restapi: Empty String Validation (#1005296)
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Empty String Validation (#1005296) ...................................................................... restapi: Empty String Validation (#1005296) The generic input validation method in the API - validateParameters() uses reflection to invoke isSetX() for the given field. In the particular case of when the filed is a string, .isEmpty() check should be added. This is what this patch does. This fix is done in the context of a specific bug - 1005296 - which complains about empty <address> field passing validation when creating a new storage server connection Bug-Url: http://bugzilla.redhat.com/1005296 Change-Id: Ib0556725ad2ddc607d587c079bad451e4b74972d Signed-off-by: Ori Liel <oliel(a)redhat.com> (cherry picked from commit 0107892b7c0b3a6c0ccad0da0c077a1966fc1f8a) --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/ReflectionHelper.java 1 file changed, 25 insertions(+), 2 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0556725ad2ddc607d587c079bad451e4b74972d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Add a validation when deactivate ISO domain.
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Add a validation when deactivate ISO domain. ...................................................................... core: Add a validation when deactivate ISO domain. Adding a CDA when deactivating an ISO storage domain if there are VMs with an ISO file attached to them and are not down. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/969641 Change-Id: I47c1a8155762ecd0b04bb17676151946982bb919 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 105 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit http://gerrit.ovirt.org/24462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47c1a8155762ecd0b04bb17676151946982bb919 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core, engine: Add more OSes for the ppc64 architecture
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core, engine: Add more OSes for the ppc64 architecture ...................................................................... core, engine: Add more OSes for the ppc64 architecture This change includes more OSes which are compatible with the ppc64 architecture. Currently only SLES and RHEL are added in osinfo. Change-Id: Ib0c0915e6ba803640d97a83e1d47b0541f19288c Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java M packaging/conf/osinfo-defaults.properties 2 files changed, 47 insertions(+), 0 deletions(-) Approvals: Gustavo Frederico Temple Pedrosa: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0c0915e6ba803640d97a83e1d47b0541f19288c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: packaging: engine-backup: align db creation instructions wit...
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: packaging: engine-backup: align db creation instructions with dwh ...................................................................... packaging: engine-backup: align db creation instructions with dwh Replace 'create user' with 'create role'. Also add a missing quote. Change-Id: Id11a2746ced31a2731a8f8d76a29b3ea4b6a5478 Bug-Url: https://bugzilla.redhat.com/1040572 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id11a2746ced31a2731a8f8d76a29b3ea4b6a5478 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: [Fix] NPE in GlusterSyncJob
by iheim＠redhat.com 17 Feb '14

17 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: [Fix] NPE in GlusterSyncJob ...................................................................... core: [Fix] NPE in GlusterSyncJob Add validation for corrupt brick(s). Change-Id: I0c0209683ab1fc4c837c23d4223278582fc0f920 Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Gustavo Frederico Temple Pedrosa: Verified Sahina Bose: Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c0209683ab1fc4c837c23d4223278582fc0f920 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Deepak C Shetty <deepakcs(a)linux.vnet.ibm.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0