- Engine-commits - oVirt List Archives

Change in ovirt-log-collector[master]: command: allow --help and --version as unprivileged user
by sbonazzo＠redhat.com 13 Feb '14

13 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: command: allow --help and --version as unprivileged user ...................................................................... command: allow --help and --version as unprivileged user Change-Id: I79d48d69409494156799ef5a2bd8965ef000e3b5 Bug-Url: https://bugzilla.redhat.com/1059654 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/24424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79d48d69409494156799ef5a2bd8965ef000e3b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in gerrit-admin[master]: Bugzilla change a bit the format of the bug xml
by dcaroest＠redhat.com 13 Feb '14

13 Feb '14

David Caro has submitted this change and it was merged. Change subject: Bugzilla change a bit the format of the bug xml ...................................................................... Bugzilla change a bit the format of the bug xml It mage the hooks fail to detect if a bug was private. Change-Id: I0df9e821f45c848c664c1bbd90416525c01a926d Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/lib/bz.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0df9e821f45c848c664c1bbd90416525c01a926d Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>

1 0

Change in gerrit-admin[master]: Fixed bug when detecting open patches
by dcaroest＠redhat.com 13 Feb '14

13 Feb '14

David Caro has submitted this change and it was merged. Change subject: Fixed bug when detecting open patches ...................................................................... Fixed bug when detecting open patches Also improved the logging a bit Change-Id: I197470c60e1d7a0270361d554afa9d38e75bcbc9 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M hooks/bz/patchset-created.warn_if_not_merged_to_previous_branch 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: David Caro: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I197470c60e1d7a0270361d554afa9d38e75bcbc9 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: moved log location change to patch
by ydary＠redhat.com 13 Feb '14

13 Feb '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: moved log location change to patch ...................................................................... packaging: moved log location change to patch This is instead of overwriting the whole file, just for this change. Change-Id: Id52f44264db2e69a83d696af1748b010b950f17d Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M .gitignore M Makefile D packaging/jasper-customizations/WEB-INF/log4j.properties.in A packaging/jasper-war-patches/900_004_props_change_logs_location.patch.in 4 files changed, 22 insertions(+), 141 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id52f44264db2e69a83d696af1748b010b950f17d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Change backward compatibility logic for add/update vnic
by iheim＠redhat.com 13 Feb '14

13 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Change backward compatibility logic for add/update vnic ...................................................................... engine: Change backward compatibility logic for add/update vnic The current backward compatibility logic designed for resolving a vnic profile id for a given network should be modified, since REST clients which provides both network name and vnic profile id might face issues, such ignoring the vnic profile id. For that purpose the engine will attempt to find a change in the network name provided by the user to what is already configured on the vnic: 1. If network name is provided, and unchanged - the vnic profile id from the parameters is used. 2. If the network name is provided and changed, use it instead of the vnic profile id. Change-Id: If1611087bad26b0bfa5a42780c5362e3413fbb75 Bug-Url: https://bugzilla.redhat.com/1064823 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/UpdateVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/VmTemplateInterfaceCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileHelper.java 5 files changed, 55 insertions(+), 11 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/24348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1611087bad26b0bfa5a42780c5362e3413fbb75 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Persist comment in AddVmTemplateCommand
by tjelinek＠redhat.com 13 Feb '14

13 Feb '14

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Persist comment in AddVmTemplateCommand ...................................................................... engine: Persist comment in AddVmTemplateCommand AddVmTemplateCommand did not map comment field from given VM to newly created template. Also added corresponding mapping to frontend CommonUnitToVmBaseBuilder. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013670 Change-Id: I5ef17d46b067036063865fbb0e64d266493132cb Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CommonUnitToVmBaseBuilder.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/FullUnitToVmBaseBuilder.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/pools/BaseVmListModelTest.java 5 files changed, 7 insertions(+), 10 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/24117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ef17d46b067036063865fbb0e64d266493132cb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: adding ovirt glance repository
by oourfali＠redhat.com 13 Feb '14

13 Feb '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: adding ovirt glance repository ...................................................................... core: adding ovirt glance repository We recently added a public Glance repository in glance.ovirt.org This patch adds it as a provider + storage domain, to be used by default in oVirt installations. Change-Id: I66215abe4c68e2a7ffe919124745be6136f8f550 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- A packaging/dbscripts/upgrade/03_04_0630_add_public_glance_repository.sql 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66215abe4c68e2a7ffe919124745be6136f8f550 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: Prevent StopVm to interleave with other VM locked actions
by iheim＠redhat.com 13 Feb '14

13 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: Prevent StopVm to interleave with other VM locked actions ...................................................................... core: Prevent StopVm to interleave with other VM locked actions Stop and Shutdown VM commands are calling the DestoryVds command which is contending on the VdsManager lock. The lock is implemented as synchronized (object) - this means that order isn't kept and we're subjected to JVM's scheduling descisions so other commands, like RunVm can take the lock and result the Vm to stop instead of start Fix: take an exclusive engine lock on Stop and Shutdown commands This will also prevent a situation where asyncRunningVms has an entry although the VM is down. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1038351 Change-Id: I6109ef0ea4869b59a93be6fef4b0c3cff50da62e Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java 3 files changed, 20 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6109ef0ea4869b59a93be6fef4b0c3cff50da62e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix event message when removing a LUN disk
by tnisan＠redhat.com 13 Feb '14

13 Feb '14

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix event message when removing a LUN disk ...................................................................... core: Fix event message when removing a LUN disk When removing a disk, the event message included the domain name parameter in case the disk is a LUN disk there is no storage domain and the message appeared incorrectly, added a new type of event message for LUN disks that displays the same message without the storage domain parameter Change-Id: I7624619d27e9e9fd6ffdc09f4380b9d2dbe5624b Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-url: https://bugzilla.redhat.com/910733 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 11 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7624619d27e9e9fd6ffdc09f4380b9d2dbe5624b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: tools: Throw error if STARTTLS not supported
by iheim＠redhat.com 13 Feb '14

13 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: tools: Throw error if STARTTLS not supported ...................................................................... tools: Throw error if STARTTLS not supported Throw error if STARTTLS is not supported on SMTP server when notifier is configured to send emails using TLS (by default it falls back to plain text). Change-Id: Id1355ef6ac04dade33f3fff0294886dfaf84f0d6 Bug-Url: https://bugzilla.redhat.com/1062646 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1355ef6ac04dade33f3fff0294886dfaf84f0d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0