- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.4]: tools: Doc fixes of provider type in engine-manage-domains
by iheim＠redhat.com 13 Feb '14

13 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: tools: Doc fixes of provider type in engine-manage-domains ...................................................................... tools: Doc fixes of provider type in engine-manage-domains Fixes provider type description in man page and help for engine-manage-domains. Change-Id: I013547823809e1cec8025f3bcbcfa7577939b76f Bug-Url: https://bugzilla.redhat.com/1056999 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsArguments.java M backend/manager/tools/src/main/resources/manage-domains-help.properties M packaging/man/man8/engine-manage-domains.8 3 files changed, 13 insertions(+), 13 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I013547823809e1cec8025f3bcbcfa7577939b76f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: fix vm pools behavior when DC is missing
by iheim＠redhat.com 13 Feb '14

13 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: fix vm pools behavior when DC is missing ...................................................................... core: fix vm pools behavior when DC is missing When DC is missing (for example force-removed) then if any vm pools still exist, they don't return in queries, because of bad join in the view. this was fixed by changing the vm_pools_view to use left-join with storage-pools in addition, this should not happen, as empty vm pools are not supported. but when using force-remove DC, all vms are deleted, but vm-pools are left. this was fixed by changing the stored procedure for remove storage pool, to remove vm-pools as well, after removing vms. Change-Id: I47c963b6b66efa05e96cb9b9f80e034d8070a30b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031717 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M packaging/dbscripts/create_views.sql M packaging/dbscripts/storages_sp.sql 2 files changed, 11 insertions(+), 1 deletion(-) Approvals: Roy Golan: Looks good to me, approved Omer Frenkel: Verified -- To view, visit http://gerrit.ovirt.org/24405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47c963b6b66efa05e96cb9b9f80e034d8070a30b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Throw error if STARTTLS not supported
by yzaslavs＠redhat.com 13 Feb '14

13 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Throw error if STARTTLS not supported ...................................................................... tools: Throw error if STARTTLS not supported Throw error if STARTTLS is not supported on SMTP server when notifier is configured to send emails using TLS (by default it falls back to plain text). Change-Id: Id1355ef6ac04dade33f3fff0294886dfaf84f0d6 Bug-Url: https://bugzilla.redhat.com/1062646 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1355ef6ac04dade33f3fff0294886dfaf84f0d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: Doc fixes of provider type in engine-manage-domains
by yzaslavs＠redhat.com 13 Feb '14

13 Feb '14

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Doc fixes of provider type in engine-manage-domains ...................................................................... tools: Doc fixes of provider type in engine-manage-domains Fixes provider type description in man page and help for engine-manage-domains. Change-Id: I013547823809e1cec8025f3bcbcfa7577939b76f Bug-Url: https://bugzilla.redhat.com/1056999 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomainsArguments.java M backend/manager/tools/src/main/resources/manage-domains-help.properties M packaging/man/man8/engine-manage-domains.8 3 files changed, 13 insertions(+), 13 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I013547823809e1cec8025f3bcbcfa7577939b76f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-release[master]: Unify ovirt-release-fedora and ovirt-release-el6
by sbonazzo＠redhat.com 13 Feb '14

13 Feb '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: Unify ovirt-release-fedora and ovirt-release-el6 ...................................................................... Unify ovirt-release-fedora and ovirt-release-el6 - detect and configure repositories in %post - updated build scripts conforming to the new structure - cleaned up build scripts Bug-Url: https://bugzilla.redhat.com/1053037 Change-Id: Ib6b1c775e7afe36ef146fcfc2b7fed37f054a0c5 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M .gitignore M Makefile.am M configure.ac D el6-ovirt.repo D fedora-ovirt.repo A ovirt-epel.repo M ovirt-release.spec.in A ovirt.repo.in 8 files changed, 118 insertions(+), 168 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6b1c775e7afe36ef146fcfc2b7fed37f054a0c5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dave Neary <dneary(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: core: task list in Webadmin - jobs disappear while still run...
by iheim＠redhat.com 13 Feb '14

13 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: core: task list in Webadmin - jobs disappear while still running ...................................................................... core: task list in Webadmin - jobs disappear while still running Previous commit deleted jobs that had at least one step that doesn't have an async task. Proper logic is to delete jobs that doesn't have steps with async tasks. Change-Id: I772ec5a6255351cd3145295c783385bf0a0c4de0 Bug-Url: https://bugzilla.redhat.com/1064227 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> (cherry picked from commit 6e5452304692a7e1c201dbbe28b7d39c167f47d5) --- M packaging/dbscripts/job_sp.sql 1 file changed, 8 insertions(+), 8 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/24375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I772ec5a6255351cd3145295c783385bf0a0c4de0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Log unsupported network update
by iheim＠redhat.com 13 Feb '14

13 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Log unsupported network update ...................................................................... engine: Log unsupported network update When hosts need to be updated on an unsupporting data center, an audit log will be sent that specifies that the automatic update will not be happening. As specified in: http://www.ovirt.org/Features/MultiHostNetworkConfiguration#Events Change-Id: I9b37fbdec5134b3131c1cafb1cd9e0596c2efb74 Bug-Url: https://bugzilla.redhat.com/1055161 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> (cherry picked from commit 1c334d843e6f9737b0443efa8175e3d261a9cc0e) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 14 insertions(+), 7 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b37fbdec5134b3131c1cafb1cd9e0596c2efb74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Log mass network operations
by iheim＠redhat.com 13 Feb '14

13 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Log mass network operations ...................................................................... engine: Log mass network operations Added logging of mass operations of networking commands so that each network change that causes update of the network on multiple hosts would output a log similar to: (7/11): Applying changes for network red on host vds1. Both start and end (successful or failed) are logged. Change-Id: Ie86bd5368052b4ed3bd18cff567c39daef911b31 Bug-Url: https://bugzilla.redhat.com/1055161 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> (cherry picked from commit 52854122b7bfd442e3d2f949bdac8739c8a5bb6a) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworksByLabelParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworksByLabelParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworksToClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworksFromClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PersistentSetupNetworksParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 15 files changed, 106 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie86bd5368052b4ed3bd18cff567c39daef911b31 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Add PersistentSetupNetworksParameters
by iheim＠redhat.com 13 Feb '14

13 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Add PersistentSetupNetworksParameters ...................................................................... engine: Add PersistentSetupNetworksParameters This parameters class will be used to print audit logging where it's necessary due to running multiple PersistentSetupNetworks commands. Change-Id: I94972492a2c87c302f07d4ccc5b7ed9e204d27dc Related-To: https://bugzilla.redhat.com/1055161 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> (cherry picked from commit d07d1f61795c48692397ecc1187c97cd0988b266) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/AddNetworksByLabelParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworkParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/RemoveNetworksByLabelParametersBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PersistentSetupNetworksParameters.java 9 files changed, 40 insertions(+), 27 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94972492a2c87c302f07d4ccc5b7ed9e204d27dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.4]: engine: Use collection for object names
by iheim＠redhat.com 13 Feb '14

13 Feb '14

Itamar Heim has submitted this change and it was merged. Change subject: engine: Use collection for object names ...................................................................... engine: Use collection for object names For nameable objects, there's no need to use a list for creating a set of the object names, just use any collection. Change-Id: I9451323cf5b9a3edd5f538ada69d8427a7bd4145 Related-To: https://bugzilla.redhat.com/1055161 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> (cherry picked from commit 2f4f23da31d386223d05f603f91b2d815b5cde7f) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Entities.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9451323cf5b9a3edd5f538ada69d8427a7bd4145 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0