- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: packaging: pythonlib: mem.py: Add M unit
by Code Review 03 Apr '17

03 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: pythonlib: mem.py: Add M unit ...................................................................... packaging: pythonlib: mem.py: Add M unit Bug-Url: https://bugzilla.redhat.com/1329119 Change-Id: I206fe363a18efd821139b258e790f48db6a5bed3 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/pythonlib/ovirt_engine/mem.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/75085 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I206fe363a18efd821139b258e790f48db6a5bed3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: userportal: replace vm actions Composite with separate columns
by Code Review 03 Apr '17

03 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: userportal: replace vm actions Composite with separate columns ...................................................................... userportal: replace vm actions Composite with separate columns In the extended view VM grid, replace vm action Composite with five separate columns. Additionally, replace the old image-based icons with new font-awesome versions. Also reworked the ButtonCell classes to be a little cleaner. Change-Id: Ieb36934062b105d66a88dd75af22aadd46c5fcdd Bug-Url: https://bugzilla.redhat.com/1413899 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractButtonCell.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractIconButtonCell.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/cell/VmButtonsImageButtonCell.java M packaging/branding/ovirt.brand/ovirt.css 5 files changed, 209 insertions(+), 152 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/74989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb36934062b105d66a88dd75af22aadd46c5fcdd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: Fixing incorrect db update for new provider
by Code Review 03 Apr '17

03 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Fixing incorrect db update for new provider ...................................................................... packaging: Fixing incorrect db update for new provider Change-Id: I323fdb1c11070cb6e6f589c2413b3ac99e986dbb Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1436154 Bug-Url: https://bugzilla.redhat.com/1438467 --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Marcin Mirecki: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I323fdb1c11070cb6e6f589c2413b3ac99e986dbb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: pythonlib: mem.py: Add M unit
by Code Review 03 Apr '17

03 Apr '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: pythonlib: mem.py: Add M unit ...................................................................... packaging: pythonlib: mem.py: Add M unit Bug-Url: https://bugzilla.redhat.com/1329119 Change-Id: I206fe363a18efd821139b258e790f48db6a5bed3 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/pythonlib/ovirt_engine/mem.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/75080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I206fe363a18efd821139b258e790f48db6a5bed3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: jenkins standard publisher: export nosetests*.xml junit reports
by Code Review 03 Apr '17

03 Apr '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: jenkins standard publisher: export nosetests*.xml junit reports ...................................................................... jenkins standard publisher: export nosetests*.xml junit reports Change-Id: I7bc72602af0d6ef8ff75233794fafeaa4684c0e7 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/yaml/publishers/standard.yaml M jobs/confs/yaml/publishers/system_tests_publishers.yaml 2 files changed, 13 insertions(+), 5 deletions(-) Approvals: Nadav Goldin: Looks good to me Eyal Edri: Looks good to me, approved; Ready for merge Daniel Belenky: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bc72602af0d6ef8ff75233794fafeaa4684c0e7 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: services: Limit engine heap size
by Code Review 03 Apr '17

03 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: services: Limit engine heap size ...................................................................... packaging: services: Limit engine heap size If ENGINE_HEAP_MIN/ENGINE_HEAP_MAX are too high, set them lower. They are set by default in new setups to be 25% of available memory, or 1024MB if machine has < 4096MB, and currently are not changed on upgrades. If the machine later on has less memory, or if the engine was restored on a machine with less memory, it might fail. So run it with lower values and warn in the system log. Optionally disable this by setting in engine conf: ENFORCE_ENGINE_HEAP_PARAMS=true Bug-Url: https://bugzilla.redhat.com/1329119 Change-Id: I2f239691893ad36c723444c956fef0fb755e9c43 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit cd9d7f275ce704ce8436ba213780b7c7ca520d90) --- M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.py 2 files changed, 36 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/75054 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f239691893ad36c723444c956fef0fb755e9c43 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: setup: Display the DWH setup requirement better t...
by Code Review 03 Apr '17

03 Apr '17

>From Shirly Radco <sradco(a)redhat.com>: Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Display the DWH setup requirement better to the user ...................................................................... packaging: setup: Display the DWH setup requirement better to the user Change-Id: I6811b3bed0956bceeaba32c4d69e9145df18e08e Bug-url: https://bugzilla.redhat.com/1431632 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/misc.py 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Shirly Radco: Looks good to me, approved Ido Rosenzwig: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74867 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6811b3bed0956bceeaba32c4d69e9145df18e08e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: aaa: RestAPI connection fail after time change
by Code Review 03 Apr '17

03 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: aaa: RestAPI connection fail after time change ...................................................................... aaa: RestAPI connection fail after time change Any failure to cleanup SsoSession due to callback notification service unavailability or authentication domain unavailability should log the error and continue with the flow. Change-Id: Ia8b685fbd2a62854befd4fce1882f28a85c53252 Bug-Url: https://bugzilla.redhat.com/1434326 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/TokenCleanupUtility.java 1 file changed, 17 insertions(+), 12 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8b685fbd2a62854befd4fce1882f28a85c53252 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: introduce VdsDynamicDao.checkIfExistsHostWithStatusI...
by Code Review 03 Apr '17

03 Apr '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: engine: introduce VdsDynamicDao.checkIfExistsHostWithStatusInCluster ...................................................................... engine: introduce VdsDynamicDao.checkIfExistsHostWithStatusInCluster Change-Id: Ied011bbe96ecf15e9682cf7e07688339c6f8edd6 Bug-Url: https://bugzilla.redhat.com/1431228 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDynamicDaoTest.java M packaging/dbscripts/vds_sp.sql 4 files changed, 58 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/74854 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied011bbe96ecf15e9682cf7e07688339c6f8edd6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: avoid using HostNicUtils in NetworkClusterHelper
by Code Review 03 Apr '17

03 Apr '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: engine: avoid using HostNicUtils in NetworkClusterHelper ...................................................................... engine: avoid using HostNicUtils in NetworkClusterHelper Change-Id: I45340bffd61af59f2570c05b337fd04206abeacd Bug-Url: https://bugzilla.redhat.com/1431228 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterHelperTest.java 2 files changed, 36 insertions(+), 99 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/74855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45340bffd61af59f2570c05b337fd04206abeacd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0