- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: EngineExtensionsManager type inference
by Code Review 03 Apr '17

03 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: EngineExtensionsManager type inference ...................................................................... core: EngineExtensionsManager type inference Change-Id: Id74a9d5884349af0fb6c61e1a8f2c4eb0386d1b2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75033 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id74a9d5884349af0fb6c61e1a8f2c4eb0386d1b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-guest-agent[master]: Allow ability to ignore specific NICs in linux guest agent
by Code Review 03 Apr '17

03 Apr '17

>From Vinzenz Feenstra <vfeenstr(a)redhat.com>: Vinzenz Feenstra has submitted this change and it was merged. Change subject: Allow ability to ignore specific NICs in linux guest agent ...................................................................... Allow ability to ignore specific NICs in linux guest agent Change-Id: Ifc7cd4e72a72b5133bae7405753046f56036c37f Signed-off-by: Marcus Young <myoung34(a)my.apsu.edu> --- M configurations/default.conf M configurations/ovirt-guest-agent.conf M ovirt-guest-agent/GuestAgentLinux2.py M tests/guest_agent_test.py 4 files changed, 18 insertions(+), 11 deletions(-) Approvals: Vinzenz Feenstra: Looks good to me, approved; Passed CI tests myoung34: Verified -- To view, visit https://gerrit.ovirt.org/74877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc7cd4e72a72b5133bae7405753046f56036c37f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: myoung34 <myoung34(a)my.apsu.edu> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: myoung34 <myoung34(a)my.apsu.edu>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: CopyImageGroup/CloneImageGroupVolumesStructure - volume format
by Code Review 02 Apr '17

02 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: CopyImageGroup/CloneImageGroupVolumesStructure - volume format ...................................................................... CopyImageGroup/CloneImageGroupVolumesStructure - volume format CopyImageGroupCommand generates a destination format for the target disk when performing a disk copy. This format is by the command when copying a disk with snapshot collapse by passing it to the CopyImage vdsm verb or when executing the CopyImageGroupWithData command (spdm flow). The CopyImageGroupWithData command used that format for creating a collapsed volume, but it passed it to CloneImageGroupVolumesStructure which is used when cloning the image structure without performing collapse. This patch changes CopyImageGroupWithData and CloneImageGroupVolumesStructure to not use the generated format when creating the target image without collapse, but use the original volume format. Change-Id: Ie70f847a069a80e3c8e5bc45223da51ef957ed30 Bug-Url: https://bugzilla.redhat.com/1437383 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupWithDataCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CloneImageGroupVolumesStructureCommandParameters.java 3 files changed, 3 insertions(+), 16 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/74807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie70f847a069a80e3c8e5bc45223da51ef957ed30 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: CreateImageVDSCommandParams - adding imageType to appendAttr...
by Code Review 02 Apr '17

02 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: CreateImageVDSCommandParams - adding imageType to appendAttributes() ...................................................................... CreateImageVDSCommandParams - adding imageType to appendAttributes() Change-Id: I1c1f30c1149ad761764d5e720b67caa9a9960c91 Bug-Url: https://bugzilla.redhat.com/1437383 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateImageVDSCommandParameters.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/74808 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c1f30c1149ad761764d5e720b67caa9a9960c91 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: import dialog load button
by Code Review 02 Apr '17

02 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: import dialog load button ...................................................................... webadmin: import dialog load button - The GWT buttons don't like being in a bootstrap grid layout, and take up the entire width of the container. This patch fixes the buttons in the import dialog. Change-Id: Icbc0e3592e3581f4bfc5ac100939228a96334edf Bug-Url: https://bugzilla.redhat.com/1390271 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbc0e3592e3581f4bfc5ac100939228a96334edf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core, engine, aaa: RestAPI connection fail after time change
by Code Review 02 Apr '17

02 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core, engine, aaa: RestAPI connection fail after time change ...................................................................... core, engine, aaa: RestAPI connection fail after time change Configure apache http pooling connection manager to validate idle connections and retry failed requests. Change-Id: I16876681f0cbf9d4dc36ffbc6d6f9442addc1fa9 Bug-Url: https://bugzilla.redhat.com/1434326 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/SsoOAuthServiceUtils.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/net/HttpClientBuilder.java M packaging/services/ovirt-engine/ovirt-engine.conf.in 4 files changed, 32 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16876681f0cbf9d4dc36ffbc6d6f9442addc1fa9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: microbenchmarks: Introduce microbenchmarks using JMH
by Code Review 02 Apr '17

02 Apr '17

>From Roy Golan <rgolan(a)redhat.com>: Roy Golan has submitted this change and it was merged. Change subject: microbenchmarks: Introduce microbenchmarks using JMH ...................................................................... microbenchmarks: Introduce microbenchmarks using JMH See: http://openjdk.java.net/projects/code-tools/jmh/ Motivation: Microbenchmark when you don't know how pieces of code behave in runtime. For example, make sure encryption and decryption performs well and doesn't affect the throughput of query for vds from the db. Change: Add encryption and decryption benchmarks based on EngineEncryptionUtils Result: Run Benchmarks from your IDE or using mvn or straight java: - mvn package creates an uber jar target/benchmarks.jar - run it with java -jar target/benchmarks.jar - or run mvn test -P benchmarks Sample output of running 'mvn test -P benchmarks': Benchmark Mode Samples Score Score error Units Benchmark.decryption thrpt 50 0.099 0.002 ops/ms Benchmark.encryption thrpt 50 0.237 0.003 ops/ms Benchmark.decryption avgt 50 10.038 0.166 ms/op Benchmark.encryption avgt 50 4.419 0.239 ms/op Benchmark.decryption sample 5320 10.381 0.064 ms/op Benchmark.encryption sample 12864 4.280 0.015 ms/op Benchmark.decryption ss 50 14.313 1.430 ms Benchmark.encryption ss 50 8.725 0.683 ms Process finished with exit code 0 Change-Id: If93cfe18435f8c9fc16973296e4f5e598eb0b248 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- A backend/manager/modules/microbenchmarks/exclude-filters.xml A backend/manager/modules/microbenchmarks/pom.xml A backend/manager/modules/microbenchmarks/src/main/java/org/ovirt/engine/benchmarks/EncryptionDecryptionBenchmark.java A backend/manager/modules/microbenchmarks/src/main/resources/key.p12 M backend/manager/modules/pom.xml 5 files changed, 220 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Roy Golan: Verified; Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74537 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If93cfe18435f8c9fc16973296e4f5e598eb0b248 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: EngineEncryptionUtils type inference
by Code Review 02 Apr '17

02 Apr '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: EngineEncryptionUtils type inference ...................................................................... core: EngineEncryptionUtils type inference Change-Id: I5e7e1dda5b99c9802113d45dfaa5a0d7c88d1e13 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EngineEncryptionUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/75012 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e7e1dda5b99c9802113d45dfaa5a0d7c88d1e13 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Inline Linq.ProviderTypeComparator
by Code Review 31 Mar '17

31 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Inline Linq.ProviderTypeComparator ...................................................................... webadmin: Inline Linq.ProviderTypeComparator ProviderTypeComparator is only used in one place (ProviderModel). With Java 8's easy syntax, there's no reason to have it in Linq instead of just have a oneliner with the same logic where it's actually needed. Change-Id: I416b004c7094146aa55d1b3561e2ea9766b9397c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java 2 files changed, 5 insertions(+), 14 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74943 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I416b004c7094146aa55d1b3561e2ea9766b9397c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Inline Linq.GlusterVolumeGeoRepSessionComparer
by Code Review 31 Mar '17

31 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Inline Linq.GlusterVolumeGeoRepSessionComparer ...................................................................... webadmin: Inline Linq.GlusterVolumeGeoRepSessionComparer GlusterVolumeGeoRepSessionComparer is only used in one place (VolumeGeoRepListModel). With Java 8's easy syntax, there's no reason to have it in Linq instead of just have a oneliner with the same logic where it's actually needed. Change-Id: Ied532f18209f591da694e09464eab5274cf9f344 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeGeoRepListModel.java 2 files changed, 3 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74932 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied532f18209f591da694e09464eab5274cf9f344 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0