- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: better excpetion logging of VdsExceptions
by ofrenkel＠redhat.com 19 Dec '13

19 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: better excpetion logging of VdsExceptions ...................................................................... core: better excpetion logging of VdsExceptions host details are missing in case of communication errors. so instead of this (no host details at all: ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.GetCapabilitiesVDSCommand] (DefaultQuartzScheduler_Worker-66) Command GetCapabilitiesVDS execution failed. Exception: VDSNetworkException: java.net.SocketTimeoutException: connect timed out it will look like this: ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.GetCapabilitiesVDSCommand] (DefaultQuartzScheduler_Worker-15) Command GetCapabilitiesVDSCommand(HostName = local-bmw, HostId = 4ad3ef8c-ee35-4853-8e49-9637fcef45e1, vds=Host[local-bmw]) execution failed. Exception: VDSNetworkException: java.net.SocketTimeoutException: connect timed out Change-Id: Iae20330e5761b844a6725d5e84aaa4d05e3db728 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22513 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae20330e5761b844a6725d5e84aaa4d05e3db728 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename members to start with lowercase in NfsStorageModel
by tnisan＠redhat.com 19 Dec '13

19 Dec '13

Tal Nisan has submitted this change and it was merged. Change subject: ui: rename members to start with lowercase in NfsStorageModel ...................................................................... ui: rename members to start with lowercase in NfsStorageModel Change-Id: I94402e65aa8e3c08868762bfac9f39ce78c7ad77 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22521 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94402e65aa8e3c08868762bfac9f39ce78c7ad77 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: rename member to lowercase in SanTargetModel
by tnisan＠redhat.com 19 Dec '13

19 Dec '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: rename member to lowercase in SanTargetModel ...................................................................... webadmin: rename member to lowercase in SanTargetModel Change-Id: I4f5161049afe446409f21ee7d648202f37757dce Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanTargetModel.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f5161049afe446409f21ee7d648202f37757dce Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename members to start with lowercase in HostListModel
by tnisan＠redhat.com 19 Dec '13

19 Dec '13

Tal Nisan has submitted this change and it was merged. Change subject: ui: rename members to start with lowercase in HostListModel ...................................................................... ui: rename members to start with lowercase in HostListModel Change-Id: I111ee0bcfdcffe7332292c1db4f123d855bb676b Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 2 files changed, 8 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22519 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I111ee0bcfdcffe7332292c1db4f123d855bb676b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: ui: rename member in StorageModel to start with lowercase
by tnisan＠redhat.com 19 Dec '13

19 Dec '13

Tal Nisan has submitted this change and it was merged. Change subject: ui: rename member in StorageModel to start with lowercase ...................................................................... ui: rename member in StorageModel to start with lowercase Change-Id: Ibefcf132fddab66b0608a1d542a31a2d40a724bd Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22516 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibefcf132fddab66b0608a1d542a31a2d40a724bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine-sdk-java[master]: sdk: The code generator needs to depend on the SDK
by mpastern＠redhat.com 19 Dec '13

19 Dec '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: The code generator needs to depend on the SDK ...................................................................... sdk: The code generator needs to depend on the SDK The code generator uses some classes from the SDK itself, so in order to build it with maven the POM needs to explictly contain that dependency. Change-Id: Ia699e673546e360e4535a7bd4678c08fd37e18d4 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/pom.xml 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia699e673546e360e4535a7bd4678c08fd37e18d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: allow current master domain to be selected as the new ...
by iheim＠redhat.com 19 Dec '13

19 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: core: allow current master domain to be selected as the new master ...................................................................... core: allow current master domain to be selected as the new master Currently the current master domain cannot be selected as the new master, which can cause to the system to not be able to recover in case that it's the only available domain. This patch allows to perform reconstruct using the master domain in case that we know that it's accessible - 1. Getting WrongMasterDomain error from vdsm means that we could get to the master domain metadata. NOTE: in that case, the reconstruct command will be executed with parameter indicating that the current master can be selected as the new master - but the host that return the WrongMasterDomain error or the master domain id as the master domain id as the id of the domain to reconstruct to aren't being passed to the command - this is being done to avoid possible issues (for example: failing to reconstruct to that domain although we can read the metadata, keep trying through the same host..etc). The intention here is to improve the current situation for most of the usecases. 2. When the master domain info in the db is different then the info received from getStoragePoolInfo. Change-Id: I705298d4f94b4afacc3ca028bb0a4e6080ac5a46 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1016118 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 7 files changed, 73 insertions(+), 40 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I705298d4f94b4afacc3ca028bb0a4e6080ac5a46 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: rm unneeded disconnect when reconstructing
by iheim＠redhat.com 19 Dec '13

19 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: core: rm unneeded disconnect when reconstructing ...................................................................... core: rm unneeded disconnect when reconstructing When performing reconstruct in the case that the old master status isn't changed to inactive there is a call to disconnect from it. This operation is wrong, there is no need to disconnect from the current master which can only cause issues. Change-Id: Ic3a0a3014d19ae78ddb47ef1a8ad4aa950539a9c Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1016118 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3a0a3014d19ae78ddb47ef1a8ad4aa950539a9c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Clean up treatment of /etc/exports
by iheim＠redhat.com 19 Dec '13

19 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: Clean up treatment of /etc/exports ...................................................................... packaging: setup: Clean up treatment of /etc/exports Without this change, /etc/exports: - gets overwritten on setup if there is no /etc/exports.d - is added empty lines when edited by setup - is not restored to previous content on cleanup With this change: - If there is /etc/exports.d: -- Setup writes there a file with the iso domain path, which is removed on cleanup (if not changed since setup) -- Setup removes this path from /etc/exports if it's there (supposedly added by a previous legacy Setup), and this change is not reverted on cleanup - If there is only /etc/exports: -- Setup adds to it the path if it's not there already -- Cleanup reverts this change if the line was not changed since setup Bug-Url: https://bugzilla.redhat.com/1035511 Change-Id: I035817c048518f77fc666cc6d5212c8e46edd65d Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/system/exportfs.py 1 file changed, 80 insertions(+), 45 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I035817c048518f77fc666cc6d5212c8e46edd65d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: frontend: adjust SPICE channels name
by iheim＠redhat.com 19 Dec '13

19 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: frontend: adjust SPICE channels name ...................................................................... frontend: adjust SPICE channels name This patch correct legacy SPICE channels names passing to clients. Change-Id: Ia7d49e2bcf24b5190197e36e4f6d000b9cde54a3 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java A frontend/webadmin/modules/gwt-common/src/test/java/org/ovirt/engine/ui/common/uicommon/AbstractSpiceTest.java 2 files changed, 53 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7d49e2bcf24b5190197e36e4f6d000b9cde54a3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0