- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: use AutoStartVmsRunner job from VdsUpdateRunTimeInfo
by ofrenkel＠redhat.com 23 Dec '13

23 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: use AutoStartVmsRunner job from VdsUpdateRunTimeInfo ...................................................................... core: use AutoStartVmsRunner job from VdsUpdateRunTimeInfo Currently VdsUpdateRunTimeInfo invokes RunVmCommand for each HA VM that went down and only when it fails because of lock acquisition problem, the VM is added to the AutoStartVmsRunner job. This patch changes that, such that the VdsUpdateRunTimeInfo pass the VM to the AutoStartVmsRunner right away and it will try to run the VM in its next iteration. Change-Id: Ia5ff535810f969255fb1d496a11378c2c10bcb91 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 2 files changed, 2 insertions(+), 22 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5ff535810f969255fb1d496a11378c2c10bcb91 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fixing restore.sh log file location
by emesika＠redhat.com 23 Dec '13

23 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fixing restore.sh log file location ...................................................................... core: fixing restore.sh log file location Setting default log file to be under /var/log/ovirt-engine if this directory exists Change-Id: I3cd0742896e2fb5cfa79c75147ced47b94c37155 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1030834 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/dbcustomfunctions.sh 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cd0742896e2fb5cfa79c75147ced47b94c37155 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: packaging: remove log4j usage
by ydary＠redhat.com 23 Dec '13

23 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: remove log4j usage ...................................................................... packaging: remove log4j usage Change-Id: Id5b4dbe479eb494aa32a52212c63a311381b5a60 Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M data-warehouse/history_etl/etl_sources/advancedPersistentLookupLib/pom.xml M data-warehouse/history_etl/etl_sources/packaging/pom.xml M data-warehouse/history_etl/history_service/history_service.sh M packaging/ovirt-engine-dwh.spec.in M pom.xml 5 files changed, 1 insertion(+), 13 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5b4dbe479eb494aa32a52212c63a311381b5a60 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: rename members to start with lowercase in ListModel.
by tnisan＠redhat.com 23 Dec '13

23 Dec '13

Tal Nisan has submitted this change and it was merged. Change subject: ui: rename members to start with lowercase in ListModel. ...................................................................... ui: rename members to start with lowercase in ListModel. Fix all places which use those members as well. Change-Id: Ie2005b745e74796704bd4b94eb1c384e2e93e72c Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 3 files changed, 12 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2005b745e74796704bd4b94eb1c384e2e93e72c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: ux: rephrase screen usage text
by sbonazzo＠redhat.com 23 Dec '13

23 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: ux: rephrase screen usage text ...................................................................... ux: rephrase screen usage text Change-Id: I9d281d803d0c083d0835ad7ebdc88c10dc8e81a7 Bug-Url: https://bugzilla.redhat.com/1044895 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/shell.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d281d803d0c083d0835ad7ebdc88c10dc8e81a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: ux: provide default gw for pingable address.
by sbonazzo＠redhat.com 23 Dec '13

23 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: ux: provide default gw for pingable address. ...................................................................... ux: provide default gw for pingable address. Change-Id: Id73ecc9d929e0afe9c62773975c9564b35c38da7 Bug-Url: https://bugzilla.redhat.com/1044920 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/network/gateway.py 1 file changed, 23 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22594 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id73ecc9d929e0afe9c62773975c9564b35c38da7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: ux: rephrase confirm installation dialog
by sbonazzo＠redhat.com 23 Dec '13

23 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: ux: rephrase confirm installation dialog ...................................................................... ux: rephrase confirm installation dialog Change-Id: Iee730d02e3b3b69cfc7ec3455cc07a1cde546089 Bug-Url: https://bugzilla.redhat.com/1044889 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/core/misc.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/22587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee730d02e3b3b69cfc7ec3455cc07a1cde546089 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Move VDS to Maintenance only if StopSPM is successful
by emesika＠redhat.com 22 Dec '13

22 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Move VDS to Maintenance only if StopSPM is successful ...................................................................... core: Move VDS to Maintenance only if StopSPM is successful Fixes MaintenanceNumberOfVdssCommand so only VDSs for which StopSPM was executed successfully, will continues with Move to Maintenance process. Change-Id: I5c58f9a9629d2e7a496f02c4dececeb842d44543 Bug-Url: https://bugzilla.redhat.com/1023145 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVdsStatusVDSCommandParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetVdsStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java 7 files changed, 98 insertions(+), 42 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c58f9a9629d2e7a496f02c4dececeb842d44543 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: supress findbugs warning
by oourfali＠redhat.com 22 Dec '13

22 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: supress findbugs warning ...................................................................... webadmin: supress findbugs warning - Surpressed findbugs warning as the code is GWT code that is used to generate other code. Change-Id: Iaa7407a647b85f6e1d92302476233b3323eb9aae Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/frontend/exclude-filters.xml 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa7407a647b85f6e1d92302476233b3323eb9aae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fixing NPE when group is assigned with permissions
by emesika＠redhat.com 22 Dec '13

22 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Fixing NPE when group is assigned with permissions ...................................................................... core: Fixing NPE when group is assigned with permissions The patch associated with Idb1a7146c29eb74f97e10043d65b5a67f1430021 introduced a regression in assigning a group permissions. Prior to that patch the entity DbGroup did not exist, hence the CTOR of LdapGroup that has DbGroup did not exist as well. The memberOf initialization is fixed here for cases that the flows do not set the memberOf attribute Change-Id: If92ce2718a32658b4118e4e7f9334b631fa6c839 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LdapGroup.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If92ce2718a32658b4118e4e7f9334b631fa6c839 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0