- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: fix mock in MoveOrCopyDiskCommand
by amureini＠redhat.com 17 Dec '13

17 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix mock in MoveOrCopyDiskCommand ...................................................................... core: fix mock in MoveOrCopyDiskCommand In mockGetVmsListForDisk() the vm1 was added twice to vmList. Change-Id: Id3f2991d89c37c8c6139f810ca5eebccea89d96f Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22446 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3f2991d89c37c8c6139f810ca5eebccea89d96f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: MoveOrCopyDiskCommand space verification
by amureini＠redhat.com 17 Dec '13

17 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: MoveOrCopyDiskCommand space verification ...................................................................... core: MoveOrCopyDiskCommand space verification This is a part of a series of patches intended to fix storage space allocation validation throughout the system (see bz). Added hasSpaceForClonedDisk(s) in StorageDomainValidator. Applied use in MoveOrCopyDiskCommand (former use is buggy). Change-Id: I951aeb531cb7ff7aaf3f1d50fc55100b6a806059 Bug-url: https://bugzilla.redhat.com/960934 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorFreeSpaceTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java 5 files changed, 127 insertions(+), 32 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22447 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I951aeb531cb7ff7aaf3f1d50fc55100b6a806059 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-3.3]: packaging: setup: handle answerfile correctly
by ydary＠redhat.com 17 Dec '13

17 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: handle answerfile correctly ...................................................................... packaging: setup: handle answerfile correctly Previously if CREATE_READONLY_USER was specified in answer file, the readonly user was not created. Now if CREATE_READONLY_USER is set to yes or true it will be created using validated values from: - READONLY_SECURE - READONLY_USER - READONLY_PASS Change-Id: I1598f4bfaf82b1713f6b0e4ee5b61d1053542702 Bug-Url: https://bugzilla.redhat.com/1040029 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 29 insertions(+), 13 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22473 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1598f4bfaf82b1713f6b0e4ee5b61d1053542702 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[ovirt-3.3]: packaging: do not create db md5 files in production
by ydary＠redhat.com 17 Dec '13

17 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: do not create db md5 files in production ...................................................................... packaging: do not create db md5 files in production this is used only for debug and is stored at datadir which is invalid. Change-Id: Ie1865d15e6c9ab7ffb3cf300f83820435c9df1b8 Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22472 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1865d15e6c9ab7ffb3cf300f83820435c9df1b8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[ovirt-3.3]: packaging: rename config values to match engine convention
by ydary＠redhat.com 17 Dec '13

17 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: rename config values to match engine convention ...................................................................... packaging: rename config values to match engine convention Change-Id: I024121b42103d2a6f721bfc417981b04726a223b Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 8 insertions(+), 8 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I024121b42103d2a6f721bfc417981b04726a223b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[ovirt-3.3]: packaging: remove 10-setup-database-dwh.conf from package
by ydary＠redhat.com 17 Dec '13

17 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: remove 10-setup-database-dwh.conf from package ...................................................................... packaging: remove 10-setup-database-dwh.conf from package conf.d files should not be in packaging. marking these as %config is even worse and will not enable proper upgrade. rename to 10-setup-database.conf as already in dwh folder. Change-Id: I798d59c469067c0eba93a8a19859e07f958baa0b Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M Makefile D packaging/10-setup-database-dwh.conf M packaging/ovirt-engine-dwh-setup.py M packaging/ovirt-engine-dwh.spec.in 4 files changed, 32 insertions(+), 48 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I798d59c469067c0eba93a8a19859e07f958baa0b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[ovirt-3.3]: packaging: packaging: rename /etc/ovirt-engine-dwh/engine-dw...
by ydary＠redhat.com 17 Dec '13

17 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: packaging: rename /etc/ovirt-engine-dwh/engine-dwh.conf.d->/etc/ovirt-engine-dwh/ovirt-engine-dwhd.conf.d ...................................................................... packaging: packaging: rename /etc/ovirt-engine-dwh/engine-dwh.conf.d->/etc/ovirt-engine-dwh/ovirt-engine-dwhd.conf.d the conf.d is of service and should called the same. we keep /etc/ovirt-engine/ovirt-engine-dwh as it going to be obsoleted by the conf.d and simply removed. Change-Id: I7dd02f65532336152f81f73104112e0a8e5333a7 Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M Makefile M packaging/ovirt-engine-dwh-setup.py M packaging/ovirt-engine-dwh.spec.in 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7dd02f65532336152f81f73104112e0a8e5333a7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: do not create db md5 files in production
by ydary＠redhat.com 17 Dec '13

17 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: do not create db md5 files in production ...................................................................... packaging: do not create db md5 files in production this is used only for debug and is stored at datadir which is invalid. Change-Id: Ie1865d15e6c9ab7ffb3cf300f83820435c9df1b8 Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1865d15e6c9ab7ffb3cf300f83820435c9df1b8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: rename config values to match engine convention
by ydary＠redhat.com 17 Dec '13

17 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: rename config values to match engine convention ...................................................................... packaging: rename config values to match engine convention Change-Id: I024121b42103d2a6f721bfc417981b04726a223b Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M packaging/common_utils.py M packaging/ovirt-engine-dwh-setup.py 2 files changed, 8 insertions(+), 8 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I024121b42103d2a6f721bfc417981b04726a223b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: packaging: rename /etc/ovirt-engine-dwh/engine-dw...
by ydary＠redhat.com 17 Dec '13

17 Dec '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: packaging: rename /etc/ovirt-engine-dwh/engine-dwh.conf.d->/etc/ovirt-engine-dwh/ovirt-engine-dwhd.conf.d ...................................................................... packaging: packaging: rename /etc/ovirt-engine-dwh/engine-dwh.conf.d->/etc/ovirt-engine-dwh/ovirt-engine-dwhd.conf.d the conf.d is of service and should called the same. we keep /etc/ovirt-engine/ovirt-engine-dwh as it going to be obsoleted by the conf.d and simply removed. Change-Id: I7dd02f65532336152f81f73104112e0a8e5333a7 Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- M Makefile M packaging/ovirt-engine-dwh-setup.py M packaging/ovirt-engine-dwh.spec.in 3 files changed, 5 insertions(+), 5 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7dd02f65532336152f81f73104112e0a8e5333a7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0