- Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: packaging: setup: Allow static IP on the host
by sbonazzo＠redhat.com 17 Dec '13

17 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Allow static IP on the host ...................................................................... packaging: setup: Allow static IP on the host Change-Id: I108c2202ebed0e90a7d06cfdef1bce8154cfd3fb Bug-Url: https://bugzilla.redhat.com/1013666 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 1 file changed, 23 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I108c2202ebed0e90a7d06cfdef1bce8154cfd3fb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: VmValidationUtils - getter for OsRepository
by derez＠redhat.com 16 Dec '13

16 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: core: VmValidationUtils - getter for OsRepository ...................................................................... core: VmValidationUtils - getter for OsRepository VmValidationUtils -> adding a getter for OsRepository instance (for convenient usage). Change-Id: I9ddb17fb0ed5fa76b1d4c64cd32e1ab6ff22a729 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java 1 file changed, 8 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ddb17fb0ed5fa76b1d4c64cd32e1ab6ff22a729 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: use OsInfo instead of config value
by derez＠redhat.com 16 Dec '13

16 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: core: use OsInfo instead of config value ...................................................................... core: use OsInfo instead of config value Use OsInfo query instead of VirtIoScsiUnsupportedOsList config value: * Added isOsSupportedForVirtIoScsi method to VmValidationUtils. * Modified DiskValidator -> isOsSupportedForVirtIoScsi accordingly. * Removed unused ConfigValues.VirtIoScsiUnsupportedOsList. Change-Id: Idf434c5b7907f413399890a4b2e7d9f63f2bce9a Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 5 files changed, 25 insertions(+), 28 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf434c5b7907f413399890a4b2e7d9f63f2bce9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: more accurate scores for ED weight module
by iheim＠redhat.com 16 Dec '13

16 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: core: more accurate scores for ED weight module ...................................................................... core: more accurate scores for ED weight module Even Distribution (ED) weight module inner calculation score is a real number, and we expose it as an integer by rounding it up. Currently we round it up (Math.ceil), but to be more accurate we should round it to nearest integer (Math.round). To avoid 0 adding 1 to the score. Change-Id: Ib668cf266629eb4e0f2c1cbd5ac893dc7deac19c Bug-Url: https://bugzilla.redhat.com/1040460 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnit.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib668cf266629eb4e0f2c1cbd5ac893dc7deac19c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: vdsm: packaging: always restart libvirtd
by Alon Bar-Lev 16 Dec '13

16 Dec '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: packaging: always restart libvirtd ...................................................................... vdsm: packaging: always restart libvirtd required if vdsm does not restart when asked to configure libvirtd. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1043524 Change-Id: I9be578c00823f50e2eee446f0661aed624d0d909 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/packages.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9be578c00823f50e2eee446f0661aed624d0d909 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: ui: clockwise progress animation
by derez＠redhat.com 16 Dec '13

16 Dec '13

Daniel Erez has submitted this change and it was merged. Change subject: ui: clockwise progress animation ...................................................................... ui: clockwise progress animation Replace dialog's counter-clockwise progress animation with a new clockwise one. Generated using: http://preloaders.net/en/circular Change-Id: I6f0f0901ba88a248d7f448be342b23b39a60ca1e Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/dialog/progress.gif 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f0f0901ba88a248d7f448be342b23b39a60ca1e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: Build pyc/pyo files
by iheim＠redhat.com 16 Dec '13

16 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: Build pyc/pyo files ...................................................................... packaging: Build pyc/pyo files Add to built packages .pyc and .pyo files. This was done so far by rpmbuild if the package redhat-rpm-config was installed. Do this now directly by make. Bug-Url: https://bugzilla.redhat.com/1043397 Change-Id: Ia4098fb7f8f664e6c1df678717c8ee230a3113fe Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22420 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4098fb7f8f664e6c1df678717c8ee230a3113fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: ignore in findbugs EventArgs unconfirmed cast errors
by oourfali＠redhat.com 16 Dec '13

16 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: frontend: ignore in findbugs EventArgs unconfirmed cast errors ...................................................................... frontend: ignore in findbugs EventArgs unconfirmed cast errors Ignore in findbugs errors related to casting EventArgs. Fix existing exclude filters that stopped working due to refactoring introduced in some recent patches that caused the order and the number of anonymous classes that contained findbugs warnings to change. The casting is safe in this case, and a future refactoring will make findbug warning resolved in any case.(RFE #1034844) Change-Id: I60fe6a07a43d4aab804823f7946f17f494339e33 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/exclude-filters.xml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60fe6a07a43d4aab804823f7946f17f494339e33 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend: Avoid IsoPrefix command when no iso attached
by ofrenkel＠redhat.com 16 Dec '13

16 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: backend: Avoid IsoPrefix command when no iso attached ...................................................................... backend: Avoid IsoPrefix command when no iso attached Added check to ImagesHandler.cdPathWindowsToLinux to immediately return when passed empty string and avoid running the IsoPrefixVSDCommand to the same end result. Change-Id: If83986270400fdefd31aa01a1736de350ab6a5ec Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If83986270400fdefd31aa01a1736de350ab6a5ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Fixed buggy profiles in edit network dialog
by iheim＠redhat.com 16 Dec '13

16 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Fixed buggy profiles in edit network dialog ...................................................................... webadmin: Fixed buggy profiles in edit network dialog A recent careless bug fix introduced a couple of bugs to the profiles section of the edit network dialog, e.g. an attempt to create profiles is made every time a network is updated and it is impossible to approve the dialog when the list of profiles is empty. Hopefully this fixed everything. Change-Id: I20ed93c4b0a02118ce9732ce7db3c446b8a07803 Bug-Url: https://bugzilla.redhat.com/1043386 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java 4 files changed, 28 insertions(+), 29 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20ed93c4b0a02118ce9732ce7db3c446b8a07803 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0