- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: allow bricks in root partition
by kmayilsa＠redhat.com 16 Dec '13

16 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: allow bricks in root partition ...................................................................... webadmin: allow bricks in root partition Added a new checkbox to 'allow' the brick directories can be created a in the root partition. This is applicable to adding bricks during volume creation and later. Selecting this option will send a 'force' parameter to backend to bypass the 'root partition' performed by gluster. Change-Id: I55ba2d05422f0a09c242e22e8ae3467e710065b7 Bug-Url: https://bugzilla.redhat.com/1008942 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.ui.xml 7 files changed, 94 insertions(+), 6 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55ba2d05422f0a09c242e22e8ae3467e710065b7 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: add force support to add-bricks
by kmayilsa＠redhat.com 16 Dec '13

16 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: add force support to add-bricks ...................................................................... gluster: add force support to add-bricks 'create volume' and 'add-brick' operation in gluster will fail, if the brick directories are in root partition. 'force' option added to skip the above check if required. It can used to clear the xattrs on the bricks if the user wants to re-use an existing brick. Change-Id: I65b3e96d759a0b09b625da793b6c63b93f8c2131 Bug-Url: https://bugzilla.redhat.com/1008942 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/gluster/GlusterVolumeValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/GlusterVolumeValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/CreateGlusterVolumeParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeBricksActionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/gluster/GlusterFeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/CreateGlusterVolumeVDSParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeBricksActionVDSParameters.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AddBricksToGlusterVolumeVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/CreateGlusterVolumeVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 23 files changed, 338 insertions(+), 18 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65b3e96d759a0b09b625da793b6c63b93f8c2131 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: set Application mode in current when session is reused
by kmayilsa＠redhat.com 16 Dec '13

16 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: restapi: set Application mode in current when session is reused ...................................................................... restapi: set Application mode in current when session is reused When client calls REST API with 'prefer: persistent-auth' header and valid session ID, LoginValidator.validate(String sessionId) will be called. But in this case application mode is not being set in Current. Because of this, rsdl is returned with all the links includeing data center and vm though the engine is running only in GlusterOnly mode. Change-Id: I972d62e2bad77b6674bf8666ed4aa041bf8319e0 Bug-Url: https://bugzilla.redhat.com/1042740 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/security/auth/LoginValidatorTest.java 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/22367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I972d62e2bad77b6674bf8666ed4aa041bf8319e0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add job subject entity when adding job from cli
by kmayilsa＠redhat.com 16 Dec '13

16 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Add job subject entity when adding job from cli ...................................................................... engine: Add job subject entity when adding job from cli When creating a job for a gluster task detected from cli, the job subject entity table needs to be populated as well. This is needed for the gluster_task_steps view to pick the correct entries. Also implemented toString() for GlusterAsyncTask Change-Id: I7996c5b2c52f276f40777fa485cf1a70ba76f381 Bug-Url: https://bugzilla.redhat.com/1040959 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddInternalJobCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddInternalJobParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/gluster/GlusterAsyncTask.java 4 files changed, 89 insertions(+), 47 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/22335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7996c5b2c52f276f40777fa485cf1a70ba76f381 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: ignore in findbugs EventArgs unconfirmed cast errors
by oourfali＠redhat.com 16 Dec '13

16 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: frontend: ignore in findbugs EventArgs unconfirmed cast errors ...................................................................... frontend: ignore in findbugs EventArgs unconfirmed cast errors Ignore in findbugs errors related to casting EventArgs. Fix some existing exclude filters that stopped working due to refactoring introduced in some recent patches that caused the order and the number of anonymous classes that contained findbugs warnings to change. The casting is safe in this case, and a future refactoring will make findbug warning resolved in any case.(RFE #1034844) This is patch #10 following http://gerrit.ovirt.org/#/c/22230/ Change-Id: I1722507982e53f91dfd1f932f9b463cb5e72c2c7 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/exclude-filters.xml M frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml M frontend/webadmin/modules/webadmin/exclude-filters.xml 3 files changed, 20 insertions(+), 20 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1722507982e53f91dfd1f932f9b463cb5e72c2c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Corrected input parameter types
by kmayilsa＠redhat.com 16 Dec '13

16 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: restapi: Corrected input parameter types ...................................................................... restapi: Corrected input parameter types The actions migrate, stopmigrate and activate on gluster bricks collection accept the Action parameter. Corrected the same in RSDL. Change-Id: I5405e80ca670957fd14e85aaa328e4716ff112a9 Bug-Url: https://bugzilla.redhat.com/1038678 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Shubhendu Tripathi: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22118 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5405e80ca670957fd14e85aaa328e4716ff112a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add config value for Gluster task support
by kmayilsa＠redhat.com 16 Dec '13

16 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Add config value for Gluster task support ...................................................................... engine: Add config value for Gluster task support Added database config value for gluster task support. Change-Id: I9a62b558a91c9b52b6a8d7a892e0420f2d1ec51e Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/22287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a62b558a91c9b52b6a8d7a892e0420f2d1ec51e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: TypeAheadListBox to not override acceptable null
by lvernia＠redhat.com 16 Dec '13

16 Dec '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: TypeAheadListBox to not override acceptable null ...................................................................... webadmin: TypeAheadListBox to not override acceptable null Altered ListModelTypeAheadListBox to only visually override null values if they're not allowed, so that when clicking outside of the list box it won't seem like another choice was chosen (when in reality the backing value is still null). Change-Id: I35b34097c9068f2baaa0573c74ec6c930b915f71 Bug-Url: https://bugzilla.redhat.com/1042872 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35b34097c9068f2baaa0573c74ec6c930b915f71 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Build pyc/pyo files
by sbonazzo＠redhat.com 16 Dec '13

16 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Build pyc/pyo files ...................................................................... packaging: Build pyc/pyo files Add to built packages .pyc and .pyo files. This was done so far by rpmbuild if the package redhat-rpm-config was installed. Do this now directly by make. Change-Id: Ia4098fb7f8f664e6c1df678717c8ee230a3113fe Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4098fb7f8f664e6c1df678717c8ee230a3113fe Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Changed semantics of NULL_OPERATION in Setup Networks
by lvernia＠redhat.com 16 Dec '13

16 Dec '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Changed semantics of NULL_OPERATION in Setup Networks ...................................................................... webadmin: Changed semantics of NULL_OPERATION in Setup Networks Changed the semantics of a generic NULL_OPERATION to actually represent a NO-OP. When a generic NULL_OPERATION is performed no message appears in the header of the dialog, thus promoting a feel that no operation is performed (rather than an operation is attempted and failed). Also removed a check whether an interface being dragged is already bonded; when dragging an interface that's part of a bond it is the bond that's dragged anyway, so this check can't return true. Change-Id: Ie5188b3c6ca5838f6e0d6bb184e554970b6f0c0f Bug-Url: https://bugzilla.redhat.com/906313 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java 5 files changed, 10 insertions(+), 13 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5188b3c6ca5838f6e0d6bb184e554970b6f0c0f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0