- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: check vds status on resume paused VM
by ofrenkel＠redhat.com 05 Dec '13

05 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: check vds status on resume paused VM ...................................................................... core: check vds status on resume paused VM Checking whether the VDS that the VM is going to be resumed on is up was missing when resuming a paused VM (regression). Change-Id: Iac123f1758e5ed3dcedab335546df322fd76a0af Bug-Url: https://bugzilla.redhat.com/1035667 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java 2 files changed, 25 insertions(+), 21 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/18245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac123f1758e5ed3dcedab335546df322fd76a0af Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: uicompat: rename 2 members to lowercase in PreparingEnlistment
by oourfali＠redhat.com 05 Dec '13

05 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: uicompat: rename 2 members to lowercase in PreparingEnlistment ...................................................................... uicompat: rename 2 members to lowercase in PreparingEnlistment Change-Id: I85f6c9d0d68a858ecfed8ac61081bac41d93c576 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/PreparingEnlistment.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85f6c9d0d68a858ecfed8ac61081bac41d93c576 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Show correct step type for async tasks
by ofrenkel＠redhat.com 05 Dec '13

05 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: restapi: Show correct step type for async tasks ...................................................................... restapi: Show correct step type for async tasks Earlier the step type details for gluster async tasks was being shown as UNKNOWN for steps like REBALANCING_VOLUME and REMOVE_BRICKS. Corrected the same in StepMapper to correctly map to valid step type. Change-Id: I3cec46a382d05d9294bf7cca562167fd634ef63c Bug-Url: https://bugzilla.redhat.com/1037709 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StepEnum.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StepMapper.java 2 files changed, 15 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22064 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cec46a382d05d9294bf7cca562167fd634ef63c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: print proper message suggesting to run as ...
by sbonazzo＠redhat.com 05 Dec '13

05 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: print proper message suggesting to run as root ...................................................................... packaging: setup: print proper message suggesting to run as root Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1037451 Change-Id: I3850b5c474e7bae47f2b240c19dee690d6c9e3ef Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/setup/bin/ovirt-engine-remove M packaging/setup/bin/ovirt-engine-rename M packaging/setup/bin/ovirt-engine-setup M packaging/setup/bin/ovirt-engine-setup.env.in 5 files changed, 19 insertions(+), 21 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3850b5c474e7bae47f2b240c19dee690d6c9e3ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: build: Allow repeated reinstalls
by sbonazzo＠redhat.com 05 Dec '13

05 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: Allow repeated reinstalls ...................................................................... build: Allow repeated reinstalls Add -f to $(LN_S) so that we may overwrite the symlink created from a previous install. This allows one to reinstall the code without first manually removing the existing symlink. Change-Id: Ia7597e6b206975ead0f0a021c5288061f2798123 Signed-off-by: Adam Litke <alitke(a)redhat.com> --- M src/bin/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21978 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7597e6b206975ead0f0a021c5288061f2798123 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: spec: pull ovirt-host-deploy-1.1.2
by sbonazzo＠redhat.com 05 Dec '13

05 Dec '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: pull ovirt-host-deploy-1.1.2 ...................................................................... packaging: spec: pull ovirt-host-deploy-1.1.2 Bug-Url: https://bugzilla.redhat.com/1032890 Change-Id: I40ae2961800e2e4bab0f052b2c6f51f9093f5200 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40ae2961800e2e4bab0f052b2c6f51f9093f5200 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: correct error message on failure to start remove brick
by kmayilsa＠redhat.com 05 Dec '13

05 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: correct error message on failure to start remove brick ...................................................................... gluster: correct error message on failure to start remove brick The variable type in error message for faliure to start remove brick is changed from Gluster Volume to Gluster Brick(s). And action entry for remove brick start which was missing earlier in one of the file is updated bug url: https://bugzilla.redhat.com/show_bug.cgi?id=1020282 Signed-off-by: ndarshan <dnarayan(a)redhat.com> Change-Id: I10a55829a11fc19e1a43f38f45911e7aaf91d5b8 --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10a55829a11fc19e1a43f38f45911e7aaf91d5b8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: select highest version in new cluster popup
by kmayilsa＠redhat.com 05 Dec '13

05 Dec '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: select highest version in new cluster popup ...................................................................... webadmin: select highest version in new cluster popup While creating a new cluster, select the possible highest version depending on the selected data center. Change-Id: I224b3458e3d4365fa12ea63831952f01e3a5b2f5 Bug-Url: https://bugzilla.redhat.com/975055 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 6 insertions(+), 10 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I224b3458e3d4365fa12ea63831952f01e3a5b2f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: add read only admin role
by oourfali＠redhat.com 05 Dec '13

05 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: add read only admin role ...................................................................... core: add read only admin role Change-Id: Ia00167f08752749b1b01447c5c910e263c6301ce Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- A packaging/dbscripts/upgrade/03_04_0160_create_read_only_admin_role.sql 1 file changed, 27 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia00167f08752749b1b01447c5c910e263c6301ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: rename several methods in CommandsFactory
by emesika＠redhat.com 04 Dec '13

04 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: engine: rename several methods in CommandsFactory ...................................................................... engine: rename several methods in CommandsFactory Rename methods to lowercase per Java naming standards. Solves findbugs warnings. Change-Id: I74412dd0c545f3806db6156964b857756e87b40d Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java 4 files changed, 11 insertions(+), 11 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74412dd0c545f3806db6156964b857756e87b40d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0