- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove unused Bookmark constructors
by amureini＠redhat.com 05 Dec '13

05 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused Bookmark constructors ...................................................................... core: Remove unused Bookmark constructors The two parameterized constructors were unused, and thus could be removed. Once they were removed there was on type keeping the single default constructor. Change-Id: I2e9582b7684892f2a11333d17b44633b84faea4c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Bookmark.java 1 file changed, 0 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e9582b7684892f2a11333d17b44633b84faea4c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm unused IVdsEventListener.restartVds
by amureini＠redhat.com 05 Dec '13

05 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm unused IVdsEventListener.restartVds ...................................................................... core: rm unused IVdsEventListener.restartVds Remove unused method declaration and implementation. Change-Id: Ide358e15504c631299bd0e2660d8ed3cbf5363d5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java 2 files changed, 0 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide358e15504c631299bd0e2660d8ed3cbf5363d5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm unused EventNotificationMethod ctors
by amureini＠redhat.com 05 Dec '13

05 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm unused EventNotificationMethod ctors ...................................................................... core: rm unused EventNotificationMethod ctors Change-Id: I2c148ac817ba66d1295a09e7f0771b841cdb602e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EventNotificationMethod.java 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c148ac817ba66d1295a09e7f0771b841cdb602e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Removed EndedTaskInfo.commandShouldBeLogged
by amureini＠redhat.com 05 Dec '13

05 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed EndedTaskInfo.commandShouldBeLogged ...................................................................... core: Removed EndedTaskInfo.commandShouldBeLogged This member is initialized to true, never modified and never queried, and thus is redundant. This patch removes the data member, its getter and setter, and the single default constructor which did nothing but initialize this member. Change-Id: Idac0e8c7cddf1eb797c856399b08a1cc6c8507e7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/EndedTasksInfo.java 1 file changed, 0 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idac0e8c7cddf1eb797c856399b08a1cc6c8507e7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Removed unused Permissions.tags
by amureini＠redhat.com 05 Dec '13

05 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed unused Permissions.tags ...................................................................... core: Removed unused Permissions.tags Removed unused data member and it's getter/setter pair. Change-Id: I086e0dbbfc59b4b378b4893a8830960d74ec466e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java 1 file changed, 0 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I086e0dbbfc59b4b378b4893a8830960d74ec466e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove redundant null check
by oourfali＠redhat.com 05 Dec '13

05 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: remove redundant null check ...................................................................... core: remove redundant null check This patch removes a redundant null check in BrandingTheme. The getResourceBundle().getString(...) method is called. This method doesn't return null. If the key doesn't exist an exception is thrown, but null is never returned. Thus, the check is redundant. Removing it. Change-Id: Iea4cda8debba202683b4048d9da5ccb86f2ca0d1 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingTheme.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea4cda8debba202683b4048d9da5ccb86f2ca0d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Unit test for RemoveVdsCommand
by ofrenkel＠redhat.com 05 Dec '13

05 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Unit test for RemoveVdsCommand ...................................................................... engine: Unit test for RemoveVdsCommand Added unit tests for RemoveVdsCommand's execute method Change-Id: Ice3e8b7ee1e35d1f96474c23b71d5265d4c00380 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java 2 files changed, 105 insertions(+), 5 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice3e8b7ee1e35d1f96474c23b71d5265d4c00380 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm unused GlusterVolumeDao.updateStripCount
by amureini＠redhat.com 05 Dec '13

05 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm unused GlusterVolumeDao.updateStripCount ...................................................................... core: rm unused GlusterVolumeDao.updateStripCount Change-Id: I07a7e25518effb606868394ea8d82daa9a22c4a7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M packaging/dbscripts/gluster_volumes_sp.sql 3 files changed, 0 insertions(+), 24 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07a7e25518effb606868394ea8d82daa9a22c4a7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Change used configured range for display port to 5900-6923
by ofrenkel＠redhat.com 05 Dec '13

05 Dec '13

Omer Frenkel has submitted this change and it was merged. Change subject: Change used configured range for display port to 5900-6923 ...................................................................... Change used configured range for display port to 5900-6923 this changes the AIO configuration and the database vdc_options for iptables rules. This patch goes together with http://gerrit.ovirt.org/#/c/17058 Change-Id: I1b93517965437b74b88e092d666fe2e91c43a6d3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=983088 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/firewalld/aio/ovirt-aio.xml.in 2 files changed, 14 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b93517965437b74b88e092d666fe2e91c43a6d3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: ignore in findbugs EventArgs unconfirmed cast errors
by amureini＠redhat.com 05 Dec '13

05 Dec '13

Allon Mureinik has submitted this change and it was merged. Change subject: frontend: ignore in findbugs EventArgs unconfirmed cast errors ...................................................................... frontend: ignore in findbugs EventArgs unconfirmed cast errors Ignore in findbugs errors related to casting EventArgs. The casting is safe in this case, and a future refactoring will make findbug warning resolved in any case.(RFE #1034844) This is patch #7 following http://gerrit.ovirt.org/#/c/21957/ Change-Id: I81af99202803fd3599daae4b52396a4a974cd751 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/webadmin/exclude-filters.xml 1 file changed, 39 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81af99202803fd3599daae4b52396a4a974cd751 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0