- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: services: ovirt-engine: enforce log level for ser...
by sbonazzo＠redhat.com 21 Oct '13

21 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: services: ovirt-engine: enforce log level for server.log ...................................................................... packaging: services: ovirt-engine: enforce log level for server.log due to unknown reason there was report that server.log was put into debug level. so let's be consistent and enforce its level as well. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1021346 Change-Id: Id1ec5786ef64986e38e3766b2aabd22f5e544225 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.xml.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1ec5786ef64986e38e3766b2aabd22f5e544225 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Fix problems in engine-backup.sh
by sbonazzo＠redhat.com 21 Oct '13

21 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Fix problems in engine-backup.sh ...................................................................... packaging: Fix problems in engine-backup.sh Backup more files. Change SCOPE's dbonly to db everywhere. Do not fail if some files are missing (e.g. /etc/firewalld/services/ovirt-postgres.xml is not always created by setup). Fix selinux contexts on restore. Refuse to restore if engine service is running. Bug-Url: https://bugzilla.redhat.com/1020277 Change-Id: I464e795627af23712696212e4589e4b8480bb8a0 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 44 insertions(+), 24 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I464e795627af23712696212e4589e4b8480bb8a0 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Disable static IP if equal to hostname
by lvernia＠redhat.com 21 Oct '13

21 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Disable static IP if equal to hostname ...................................................................... webadmin: Disable static IP if equal to hostname This to prevent a user from performing a move that would necessarily cause the engine to lost connectivity to a host. Change-Id: I46836fac331f3d510fc3be8d435bb71fb546d37c Bug-Url: https://bugzilla.redhat.com/989360 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 4 files changed, 27 insertions(+), 4 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46836fac331f3d510fc3be8d435bb71fb546d37c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Improved boot protocol behavior in host network di...
by lvernia＠redhat.com 21 Oct '13

21 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Improved boot protocol behavior in host network dialog ...................................................................... webadmin: Improved boot protocol behavior in host network dialog It used to be that if the address/subnet/gateway fields were edited, they would be committed to the VdsNetworkInterface upon pressing OK even if the chosen boot protocol was for example NONE, in which case it would be expected that these fields wouldn't be committed. So now changes are committed only if the chosen boot protocol is IP_STATIC. Change-Id: I76f3f8d5c3f214927761effa571ca23f2e6c239c Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76f3f8d5c3f214927761effa571ca23f2e6c239c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Modified network static IP validation
by masayag＠redhat.com 21 Oct '13

21 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Modified network static IP validation ...................................................................... engine: Modified network static IP validation It used to not allow changing the management network's IP address whenever the hostname was given as an IP address, but actually problems only arise if the old management network's IP address was equal to the hostname. However, this validation should be applied to ANY network, not just the management network. Also modified the tests accordingly, as well as fixed some logic that was supposed to give existing NICs different IP addresses but I don't think did anything. Change-Id: I85f873fe4e87d16ec60da5bd8f9d6c90ee1e0030 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 87 insertions(+), 30 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85f873fe4e87d16ec60da5bd8f9d6c90ee1e0030 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Fencing flow fails to get to secondery PM...
by iheim＠redhat.com 21 Oct '13

21 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Fencing flow fails to get to secondery PM... ...................................................................... core: Fencing flow fails to get to secondery PM... Fencing flow fails to get to secondary PM (primary is deliberately configured with wrong params) Reason for the thrown exception was an unmatched parenthesis in the log message. The second parameter passed was {2) instead of {2} Change-Id: Iec2e0d6b77f0e01e36c01ea1d397862e293ee7ef Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1013654 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec2e0d6b77f0e01e36c01ea1d397862e293ee7ef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: quota was not enforced in run VM
by dfediuck＠redhat.com 20 Oct '13

20 Oct '13

Doron Fediuck has submitted this change and it was merged. Change subject: engine: quota was not enforced in run VM ...................................................................... engine: quota was not enforced in run VM Since quota uses MLA model, each quota related action should add permission checks for Consume_Quota action group on the specified quota. this was not the case in run VM which override the addQuotaPermissionSubject wrongfully. The reason for that was that the user can create a VM from template and select the template's quota. this quota should be available only if the user has consumption rights for this quota. Last issue is that when failing on no-permission of consume_quota, the err message shouldn't be: 'the user isn't author...' but more suitable one related to quota and consumption. Bug-Url: https://bugzilla.redhat.com/1020201 Change-Id: I053680e61b8f9a0557845d0b5359a022b6473052 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 13 insertions(+), 8 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19994 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I053680e61b8f9a0557845d0b5359a022b6473052 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: scheduling: avoid running external filters in CDA
by dfediuck＠redhat.com 20 Oct '13

20 Oct '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: scheduling: avoid running external filters in CDA ...................................................................... core: scheduling: avoid running external filters in CDA External code is user responsibility, so for the sake of performance, avoiding running external plugins in CanDoAction. Bug-Url: https://bugzilla.redhat.com/1014698 Change-Id: I319ca2a5d9dbbc6634639e7b842beac1cf6c6ad9 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I319ca2a5d9dbbc6634639e7b842beac1cf6c6ad9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: in PM only selecting apc or ipmilan...
by emesika＠redhat.com 20 Oct '13

20 Oct '13

Eli Mesika has submitted this change and it was merged. Change subject: core: in PM only selecting apc or ipmilan... ...................................................................... core: in PM only selecting apc or ipmilan... in PM only selecting apc or ipmilan changes the options, choosing other types is static The reason for that was that fence options mapping were called with 'general' version and since this key is versioned, the static value for this key in ConfigValues.java was returned. This value misses some of the recent agents added in 3.2 and 3.3 and cause this BZ. This patch fix this issue by getting 6the fence options mapping from the database for the given cluster version. Change-Id: I2f815e90d95e8cd21aca51a803dccde8079dee5d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014513 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAgentFenceOptionsQuery.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAgentFenceOptionsQueryParameters.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java 6 files changed, 43 insertions(+), 14 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f815e90d95e8cd21aca51a803dccde8079dee5d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: LocalAdminPassword exception after engine restart
by iheim＠redhat.com 20 Oct '13

20 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: LocalAdminPassword exception after engine restart ...................................................................... core: LocalAdminPassword exception after engine restart After oVirt host comes up from reboot, we see javax.crypto.BadPaddingException: Data must start with zero exception in engine.log: When GetConfigurationValuesQuery is executed it retrives the values for all the versions and returns it. But LOCAL_ADMIN_PASSWD exists only for version general which breaks the logic in DbConfigUtils. This patch introduces a black list of all passwd fields that have values only for version "general". So the backend does not try to extract values for other versions for these ConfigurationValues Change-Id: I000bbb3cf5a6d1d636c49247e85858b02b2f358a Bug-Url: https://bugzilla.redhat.com/994454 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValuesQuery.java 1 file changed, 22 insertions(+), 6 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I000bbb3cf5a6d1d636c49247e85858b02b2f358a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0