- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: core: Fix broken backward compatibility of os ids
by iheim＠redhat.com 20 Oct '13

20 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Fix broken backward compatibility of os ids ...................................................................... core: Fix broken backward compatibility of os ids This fix is about maintaining oss backward compatibility mappings of old os names to the current IDs. Vm Import/Export is using the os unique name instead of the os ID in the OVF and since all unique names streamlined with the REST API representation they all are not identified and fallback ID 0 - "other" pre-osinfo exports would write the OS Windows8 while the new name is windows_8 and so on Solution: Added a backward compatibility section to osinfo-default.properties # Since Unassigned is removed we translate is to other so backwardCompatibility.Unasigned = 0 backwardCompatibility.Other = 0 # represents the current id of old Windows8 os backwardCompatibilty.Windows8 = 20 Bug-Url: https://bugzilla.redhat.com/1006340 Change-Id: I77c51a3bd0f4f0c264e8f895f40fd4d2bf4d689c Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImpl.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImplTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/OsInfoPreferencesLoader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M packaging/conf/osinfo-defaults.properties 6 files changed, 64 insertions(+), 11 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77c51a3bd0f4f0c264e8f895f40fd4d2bf4d689c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Vnic hotplug validation - Patch 1 of 2
by masayag＠redhat.com 20 Oct '13

20 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Vnic hotplug validation - Patch 1 of 2 ...................................................................... core: Vnic hotplug validation - Patch 1 of 2 * This change adds in the osinfo file the description for the nic hotplug support: os.{id}.devices.network.hotplugSupport.value = true os.{id}.devices.network.hotplugSupport.value.3.0 = false * Provided the access in the backend. * Cached the information in the frontend, because in patch 2 of 2 they are used in the constructors of commands. * Renamed the method canPerformHotPlug to canPerformDiskHotPlug, because it is used to disk and not to nic. Change-Id: I09d817323c8b6a7d2ca02c29c200dc4507d6b94c Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OsRepositoryQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepositoryImpl.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/OsQueryParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M packaging/conf/osinfo-defaults.properties 13 files changed, 148 insertions(+), 11 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09d817323c8b6a7d2ca02c29c200dc4507d6b94c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Vnic hotplug validation - Patch 2 of 2
by masayag＠redhat.com 20 Oct '13

20 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Vnic hotplug validation - Patch 2 of 2 ...................................................................... webadmin: Vnic hotplug validation - Patch 2 of 2 * This change prevents the hot (un)plugging of NICs in VMs that do not support it. The parameter used to determine if hotplugging is supported was changed from a field in the configuration table of the database to a property in the osinfo file. * The user may also plug and unplug interfaces when the VM is down (regardless of hotplug support) or create an unplugged NIC in a running VM when there isn't support for hotplug. Change-Id: I2434386f98c31a8d0fe44011ecadecb732ded19a Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditTemplateInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewGuideVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 9 files changed, 87 insertions(+), 20 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2434386f98c31a8d0fe44011ecadecb732ded19a Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: no job desc for AddVmFromSnapshot
by masayag＠redhat.com 20 Oct '13

20 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: core: no job desc for AddVmFromSnapshot ...................................................................... core: no job desc for AddVmFromSnapshot shown as 'AddVmFromSnapshot', changed to Creating VM xxx from Snapshot yyy in Cluster zzz. Change-Id: I28ff6aa5bef6b39122071bee7582af2e74688156 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28ff6aa5bef6b39122071bee7582af2e74688156 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: block editing migraion fields while VM !Down
by gchaplik＠redhat.com 20 Oct '13

20 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: block editing migraion fields while VM !Down ...................................................................... engine: block editing migraion fields while VM !Down While the VM isn't down block editing migration and pinToHost fields in engine, and add a tooltip in UI to explain that. Change-Id: If9fb2fc0755317a8d4be7628b56966d82e9adc3a Bug-Url: https://bugzilla.redhat.com/735260 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 4 files changed, 12 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19937 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9fb2fc0755317a8d4be7628b56966d82e9adc3a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: remove quota comsumer is broken
by gchaplik＠redhat.com 20 Oct '13

20 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: remove quota comsumer is broken ...................................................................... webadmin: remove quota comsumer is broken Although we use MLA dialogs, there is another treatment for consume_quota role (i.e. hiding it). generalizing it with other remove permission dialog creates an error. Change-Id: I794983826b8b6fc9fffc6f504db11fce00788633 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/QuotaModule.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I794983826b8b6fc9fffc6f504db11fce00788633 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: No spaces in /etc/sysconfig/nfs
by oschreib＠redhat.com 20 Oct '13

20 Oct '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: No spaces in /etc/sysconfig/nfs ...................................................................... packaging: setup: No spaces in /etc/sysconfig/nfs Do not put spaces around '=' in lines added to /etc/sysconfig/nfs . Adding them breaks sysvinit-based nfs init sh scripts. Bug-Url: https://bugzilla.redhat.com/1013347 Change-Id: Ib9e1442b764cc9aef88044b7c1595236903edecf Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/system/nfs.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ofer Schreiber: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/20316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9e1442b764cc9aef88044b7c1595236903edecf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: No spaces in /etc/sysconfig/nfs
by oschreib＠redhat.com 20 Oct '13

20 Oct '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: No spaces in /etc/sysconfig/nfs ...................................................................... packaging: setup: No spaces in /etc/sysconfig/nfs Do not put spaces around '=' in lines added to /etc/sysconfig/nfs . Adding them breaks sysvinit-based nfs init sh scripts. Bug-Url: https://bugzilla.redhat.com/1013347 Change-Id: Ib9e1442b764cc9aef88044b7c1595236903edecf Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/system/nfs.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ofer Schreiber: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/20315 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9e1442b764cc9aef88044b7c1595236903edecf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Added missing entries to AbstractGlusterBrokerCommand
by kmayilsa＠redhat.com 18 Oct '13

18 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Added missing entries to AbstractGlusterBrokerCommand ...................................................................... gluster: Added missing entries to AbstractGlusterBrokerCommand Added missing entries into AbstractGlusterBrokerCommand class for gluster async tasks. Change-Id: I66da63298cee49f108cd6a8c967969194939da98 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66da63298cee49f108cd6a8c967969194939da98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Removed check of async task details in volume
by kmayilsa＠redhat.com 18 Oct '13

18 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Removed check of async task details in volume ...................................................................... gluster: Removed check of async task details in volume Removed checking the existence of async task details in volume entity for the purpose of checking the rebalance execution status on a volume. This is not required and we should always depend upon the actual value returned from glusterfs for the rebalance status as that value would be the uptodate and correct value. Change-Id: I54a0f0949cfc8c2fb46bec816519449e583a6b65 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQuery.java 1 file changed, 9 insertions(+), 10 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54a0f0949cfc8c2fb46bec816519449e583a6b65 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0