- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Hide "public" InfoIcon if checkbox hidden
by lvernia＠redhat.com 15 Oct '13

15 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Hide "public" InfoIcon if checkbox hidden ...................................................................... webadmin: Hide "public" InfoIcon if checkbox hidden In previous patches disregarded the fact that the public checkbox could be hidden, in which case the InfoIcon should also be hidden. Change-Id: Ib3dc7a083ca212c7e5dd5e2f2e5ff8b54fa8f573 Bug-Url: https://bugzilla.redhat.com/1000804 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3dc7a083ca212c7e5dd5e2f2e5ff8b54fa8f573 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: build: ovirt-hosted-engine-ha-0.1.0-0.3.1.beta1
by gpadgett＠redhat.com 15 Oct '13

15 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-0.1.0-0.3.1.beta1 ...................................................................... build: ovirt-hosted-engine-ha-0.1.0-0.3.1.beta1 Change-Id: I83dbc1a904a9e4fe5df12c5611e3cd601b6212f5 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Greg Padgett: Verified; Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/20195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83dbc1a904a9e4fe5df12c5611e3cd601b6212f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove non-existent Storage Domain will be rolled forw...
by mlipchuk＠redhat.com 15 Oct '13

15 Oct '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove non-existent Storage Domain will be rolled forward. ...................................................................... core: Remove non-existent Storage Domain will be rolled forward. Removal of a Storage Domain which no longer exists causes a failure in the engine and blocks the user from removing the storage. The following patch validates the storage domain was not removed due to the reason of non existence, and if so it will roll-forward and delete it any how. Change-Id: I9515a5ddfcaa965c2bad1883f0543494915b8c7d Bug-Url: https://bugzilla.redhat.com/1001626 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java 1 file changed, 15 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20158 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9515a5ddfcaa965c2bad1883f0543494915b8c7d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: fix indentation error in rest api test code
by mpastern＠redhat.com 15 Oct '13

15 Oct '13

Michael Pasternak has submitted this change and it was merged. Change subject: gluster: fix indentation error in rest api test code ...................................................................... gluster: fix indentation error in rest api test code fix some intentation errors in methods testSetOptionInvalidParams, testResetOptionInvalidParams Change-Id: I7d86b202556cca4702b9b9fda5e3ce4093cc9fb9 Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResourceTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d86b202556cca4702b9b9fda5e3ce4093cc9fb9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: history-etl: service: update discovery of JAVA_HOME
by ydary＠redhat.com 15 Oct '13

15 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: history-etl: service: update discovery of JAVA_HOME ...................................................................... history-etl: service: update discovery of JAVA_HOME The new implementation uses engine's script /usr/share/ovirt-engine/bin/java-home to detect JAVA_HOME location. Change-Id: I34dd5891cfc76242bb3bb50bf77bb48ad50839c8 Bug-Url: https://bugzilla.redhat.com/1019178 Related-To: https://bugzilla.redhat.com/1009863 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M data-warehouse/history_etl/history_service/history_service.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34dd5891cfc76242bb3bb50bf77bb48ad50839c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Fixed coverity scan failure in GetGlusterVolumeReba...
by kmayilsa＠redhat.com 15 Oct '13

15 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Fixed coverity scan failure in GetGlusterVolumeRebalanceStatusQueryTest ...................................................................... gluster: Fixed coverity scan failure in GetGlusterVolumeRebalanceStatusQueryTest Fixed an coverity scan failure issue in the test case class GetGlusterVolumeRebalanceStatusQueryTest. Change-Id: I767f981cfefa8a783cc636e96cc32675fc17aefc Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQueryTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I767f981cfefa8a783cc636e96cc32675fc17aefc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Populate host name in volume rebalance status
by kmayilsa＠redhat.com 15 Oct '13

15 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Populate host name in volume rebalance status ...................................................................... gluster: Populate host name in volume rebalance status Modified the query to set the host name instead of localhost in gluster volume rebalance status details. Change-Id: If83755d715df3cf116afa9dfa87b2f8680e8fffa Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRebalanceStatusQueryTest.java 2 files changed, 42 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If83755d715df3cf116afa9dfa87b2f8680e8fffa Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Included additional fields in rebalance status
by kmayilsa＠redhat.com 15 Oct '13

15 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Included additional fields in rebalance status ...................................................................... gluster: Included additional fields in rebalance status Included the adiitional fields runtime, filesSkipped and houstUuid in gluster rebalance status entity class. Change-Id: I71a20fbb93a9731ca2ff68ddd401589d319226d4 Bug-Url: https://bugzilla.redhat.com/1011883 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeTaskStatusForHost.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeTaskReturnForXmlRpc.java 2 files changed, 19 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71a20fbb93a9731ca2ff68ddd401589d319226d4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Changed the type of numeric fields to long
by kmayilsa＠redhat.com 15 Oct '13

15 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Changed the type of numeric fields to long ...................................................................... gluster: Changed the type of numeric fields to long Changed the type fo numeric fields in class GlusterVolumeTaskStatusDetail. This is required because numeric fields in status might be holding bigger values and we need long to hold these values. Change-Id: I5c1ade59e328bfcc1440ba8ac410848d296a6a26 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeTaskStatusDetail.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeTaskReturnForXmlRpc.java 2 files changed, 28 insertions(+), 24 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c1ade59e328bfcc1440ba8ac410848d296a6a26 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Fix findbug error - possible NPE
by amureini＠redhat.com 15 Oct '13

15 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Fix findbug error - possible NPE ...................................................................... engine: Fix findbug error - possible NPE FindBug returned this error of possible NPE though the Dao returns an empty list and not null. Change-Id: I73a087ed678f8fffca9aabbb56bf1baacb5a0a44 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73a087ed678f8fffca9aabbb56bf1baacb5a0a44 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0