- Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: etl: fixed etl error when hosts are non-responsive
by ydary＠redhat.com 14 Oct '13

14 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: etl: fixed etl error when hosts are non-responsive ...................................................................... etl: fixed etl error when hosts are non-responsive Change-Id: Idf69b45204930acb22def0c8309c8ce6dc5a79d0 Bug-Url: https://bugzilla.redhat.com/1008370 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/sampletimekeepingjob_3_3/SampleTimeKeepingJob.java M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.3.item M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.3.properties M data-warehouse/history_etl/tos_project/talend.project 4 files changed, 139 insertions(+), 85 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf69b45204930acb22def0c8309c8ce6dc5a79d0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Remove vNIC from external network when necessary
by iheim＠redhat.com 14 Oct '13

14 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Remove vNIC from external network when necessary ...................................................................... engine: Remove vNIC from external network when necessary Removing the vNIC from the external network only when the vNIC is removed or the VM gets somehow removed. This will allow the user of the vNIC to manipulate it on the external network and not lose his changes when the VM stops. Change-Id: I027992f52c35add0afd1ffe207b1adbdb2c5c957 Bug-Url: https://bugzilla.redhat.com/1013491 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/OpenstackNetworkProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java 8 files changed, 96 insertions(+), 52 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I027992f52c35add0afd1ffe207b1adbdb2c5c957 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Utility class for managing external networks
by iheim＠redhat.com 14 Oct '13

14 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Utility class for managing external networks ...................................................................... engine: Utility class for managing external networks This utility class is useful for managing external networks, currently it provides an easy way to deallocate the vNIC from the external network. Change-Id: I1c93d7a74c66bbcae54cd4667744b0a88882622c Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ExternalNetworkManager.java 1 file changed, 61 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c93d7a74c66bbcae54cd4667744b0a88882622c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Lazily initialize VM interfaces list
by iheim＠redhat.com 14 Oct '13

14 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Lazily initialize VM interfaces list ...................................................................... engine: Lazily initialize VM interfaces list In order to deallocate vNICs from external networks, the interfaces list for the VM is necessary. Therefore, the interfaces list will be initialized lazily. Change-Id: Ib2c08ea82134b398344dfed41e5000de2fe98a74 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2c08ea82134b398344dfed41e5000de2fe98a74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: UI: support multi monitor only for cluster 3.3 and up
by shavivi＠redhat.com 14 Oct '13

14 Oct '13

Shahar Havivi has submitted this change and it was merged. Change subject: UI: support multi monitor only for cluster 3.3 and up ...................................................................... UI: support multi monitor only for cluster 3.3 and up When the cluster is less then 3.3 or non Linux OS we set the SinglePCI checkbox to false and hide it. Change-Id: I5f65dd3d5ca1409402b9b0b93e1585f4bfa47a64 Bug-Url: https://bugzilla.redhat.com/1009391 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 32 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f65dd3d5ca1409402b9b0b93e1585f4bfa47a64 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: partial cleanup - db only
by sbonazzo＠redhat.com 14 Oct '13

14 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: partial cleanup - db only ...................................................................... packaging: setup: partial cleanup - db only Before this change, if during cleanup the user only asked to delete only the database, then ran setup again, setup wrongly identified the system as being legacy 3.2 and tried to upgrade, which failed. This change makes the identification of upgrade from 3.2 legacy more strict and in such a situation setup-engine will continue as a new setup. Bug-Url: https://bugzilla.redhat.com/987939 Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/legacy/core.py M packaging/setup/plugins/ovirt-engine-setup/legacy/database.py 3 files changed, 73 insertions(+), 18 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: change formatter "addNewLine" to "insert"
by amureini＠redhat.com 14 Oct '13

14 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: change formatter "addNewLine" to "insert" ...................................................................... engine: change formatter "addNewLine" to "insert" Change the code formatter configuration to have "addNewLine" set to "insert" instead of "do not insert" to align it with the checkstyle validations that fails if there's no new line in the end of file. Change-Id: I495e11e20c315e267e9f8141f7fecf45e39a3363 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M config/engine-code-format.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I495e11e20c315e267e9f8141f7fecf45e39a3363 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add import/export support
by ofrenkel＠redhat.com 14 Oct '13

14 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: add import/export support ...................................................................... core: add import/export support Change-Id: I7e99c737cceb022b8cbd6f026d21181dab3c1f7a Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java 4 files changed, 32 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15592 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e99c737cceb022b8cbd6f026d21181dab3c1f7a Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Add support to search by instance and image types
by ofrenkel＠redhat.com 14 Oct '13

14 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: Add support to search by instance and image types ...................................................................... Add support to search by instance and image types This patch add support to search instance and image types: "InstanceType: .." Change-Id: I1ab8c12b61faa79eadee6ec2dd069f23a7c0c9fa Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/SearchType.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjects.java M packaging/dbscripts/create_views.sql 5 files changed, 64 insertions(+), 5 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ab8c12b61faa79eadee6ec2dd069f23a7c0c9fa Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: use instance type in addVm + permissions
by ofrenkel＠redhat.com 14 Oct '13

14 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: use instance type in addVm + permissions ...................................................................... core: use instance type in addVm + permissions Added new ActionGroup CREATE_INSTANCE that allow user to create only instance, which is more 'weak' than create vm because of the smaller set of parameters the user can set to an instance compared to vm. Added new roles to be used: InstanceCreator and UserInstanceManager which are compatible with vm roles to allow instance manipulation by users. AddVmCommand: handle creation of instance (vm from instance type and image type) Change-Id: If9058907d1021b09981671e905defb91ed645d65 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PredefinedRoles.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_04_0020_add_instance_permissions.sql 14 files changed, 265 insertions(+), 25 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9058907d1021b09981671e905defb91ed645d65 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0