- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3.0.1]: core: support the newly-tagged vdsm-4.13
by iheim＠redhat.com 10 Oct '13

10 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: support the newly-tagged vdsm-4.13 ...................................................................... core: support the newly-tagged vdsm-4.13 vdsm-4.13 would be part of oVirt-3.3.1. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1017285 Change-Id: I12dacd46973cde693105c21ae5bc41aec7fe7863 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Itamar Heim: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12dacd46973cde693105c21ae5bc41aec7fe7863 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.0.1 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: backend: remove vm check from LiveMigrateDiskCommand
by derez＠redhat.com 10 Oct '13

10 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: backend: remove vm check from LiveMigrateDiskCommand ...................................................................... backend: remove vm check from LiveMigrateDiskCommand This patch shifts the VM status check from the LiveMigrateDiskCommand to VmReplicateDiskStartTaskHandler. This will: * prevent CreateImagePlaceholderTaskHandler from failing if the VM crashes during its execution * shift the failure to the appropriate handler (VmReplicateDiskStart) * allow the CreateImagePlaceholderTaskHandler compensation to take place and remove the destination image when necessary Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=957703 Change-Id: Iac42a5d10373a0c1fcf9a224fb902f0ce481d3b7 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStartTaskHandler.java 2 files changed, 12 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac42a5d10373a0c1fcf9a224fb902f0ce481d3b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: import VM - NICs - enable column resizing
by derez＠redhat.com 10 Oct '13

10 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: import VM - NICs - enable column resizing ...................................................................... webadmin: import VM - NICs - enable column resizing Import VM dialog -> NICs table: enable column resizing. Change-Id: I897a1cef966a270b3c9be1bfafb62b456b57a7fe Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I897a1cef966a270b3c9be1bfafb62b456b57a7fe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: import VM - disks - enable column resizing
by derez＠redhat.com 10 Oct '13

10 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: import VM - disks - enable column resizing ...................................................................... webadmin: import VM - disks - enable column resizing Import VM dialog -> disks table: enable column resizing. Change-Id: Iab62f8d6989ca25cdf523645adf9112ed0529b1c Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab62f8d6989ca25cdf523645adf9112ed0529b1c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: import VM - rename disk alias column
by derez＠redhat.com 10 Oct '13

10 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: import VM - rename disk alias column ...................................................................... webadmin: import VM - rename disk alias column Import VM dialog -> disks table: s/Name/Alias Change-Id: Id77574d77a92ebaeb13bdd5d681e2e96880b3154 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 2 files changed, 2 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20057 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id77574d77a92ebaeb13bdd5d681e2e96880b3154 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: bootable column in import VM disks table
by derez＠redhat.com 10 Oct '13

10 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: bootable column in import VM disks table ...................................................................... webadmin: bootable column in import VM disks table Added bootable icon column to disks table in import VM dialog. Change-Id: I7c0e7bf591697c73143343bbfe14beeed0a11c62 Bug-Url: https://bugzilla.redhat.com/1015185 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c0e7bf591697c73143343bbfe14beeed0a11c62 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: adding activities colume to Bricks tab
by kmayilsa＠redhat.com 10 Oct '13

10 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: adding activities colume to Bricks tab ...................................................................... webadmin: adding activities colume to Bricks tab Added a new activities column to Bricks table. This is similar to the Actvities colume in the volumes tab. But the cell in this column is visible only if the task is of type REMOVE_BRICK. Added new icons to show the different stages of remove brick operation. All the brick removal related(stop/commit) operations are moved to the row. The same actions will be available in the volume row as well. Stop/Commit removal command availbility will be decided based on the task type and status. Refactored the code which populates the bricks in the table. Change-Id: I820c8b2e2e948d1c2ce0811d2d5a78784eeafc2b Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationTemplates.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityCompositeCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityStatusCell.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/remove_brick_commit_required.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/remove_brick_failed.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/remove_brick_running.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/remove_brick_stopped.png 14 files changed, 173 insertions(+), 60 deletions(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I820c8b2e2e948d1c2ce0811d2d5a78784eeafc2b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: volume rebalance status icons updated
by kmayilsa＠redhat.com 10 Oct '13

10 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: volume rebalance status icons updated ...................................................................... webadmin: volume rebalance status icons updated Replaced the old volume rebalance status icons with newer ones. Renamed the icon directory to 'glusterAsyncTasks'. Change-Id: Iae29a3582ea98132224f52928d18c63ae4634a8d Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/rebalance_completed.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/rebalance_failed.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/rebalance_running.png A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterAsyncTasks/rebalance_stopped.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterRebalance/rebalance_completed.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterRebalance/rebalance_failed.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterRebalance/rebalance_running.png D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/glusterRebalance/rebalance_stopped.png 9 files changed, 5 insertions(+), 5 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae29a3582ea98132224f52928d18c63ae4634a8d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Sync Template disks with new GUID.
by mlipchuk＠redhat.com 10 Oct '13

10 Oct '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Sync Template disks with new GUID. ...................................................................... core: Sync Template disks with new GUID. Currently ImportVmTemplateCommand use two different kinds of containers when importing a Template, disks GUIDs and image GUIDs. Those two containers are correlated, and should be reflected in a map so it will remain in sync, same as we use in ImportVmCommand. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I5d0ef009e24aac07e2623dbef0fb762ca333888c --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java 3 files changed, 11 insertions(+), 16 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d0ef009e24aac07e2623dbef0fb762ca333888c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Update managed device map when importing a cloned VM.
by mlipchuk＠redhat.com 10 Oct '13

10 Oct '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Update managed device map when importing a cloned VM. ...................................................................... core: Update managed device map when importing a cloned VM. When importing a cloned VM or Template, we generate a new guid for each disk. Those new guids should be correlated with the mangedDeviceMap contained in the VM/Template, so it will keep all the devices configuration as in the old VM/Template. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/976469 Change-Id: I65a99cc0783f670b9288cc9a066cda4d253492a6 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java 5 files changed, 116 insertions(+), 25 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65a99cc0783f670b9288cc9a066cda4d253492a6 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0