- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Create default profile when changing to VM network
by lvernia＠redhat.com 10 Oct '13

10 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Create default profile when changing to VM network ...................................................................... webadmin: Create default profile when changing to VM network When a network is switched from VM to non-VM, its associated profiles are removed. When switching from non-VM to VM, a default profile is now created again in the GUI. Change-Id: Ia6764a5d99a9471e6ae07f31ab8552d41b1c28f6 Bug-Url: https://bugzilla.redhat.com/1007279 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java 3 files changed, 27 insertions(+), 25 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6764a5d99a9471e6ae07f31ab8552d41b1c28f6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Display default vNIC profile in tab
by lvernia＠redhat.com 10 Oct '13

10 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Display default vNIC profile in tab ...................................................................... webadmin: Display default vNIC profile in tab The user currently has no way of knowing we're intending to create this profile, so now by default it's shown in the list of profiles to be created for a network being added. Change-Id: Iaa7b46a5cfd262bfdb9915993af0a1e524362055 Bug-Url: https://bugzilla.redhat.com/1000801 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/EditVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java 4 files changed, 59 insertions(+), 35 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa7b46a5cfd262bfdb9915993af0a1e524362055 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Hide profiles tab if network is non-VM
by lvernia＠redhat.com 10 Oct '13

10 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Hide profiles tab if network is non-VM ...................................................................... webadmin: Hide profiles tab if network is non-VM A non-VM network cannot have profiles associated with it, so the profiles tab of the add/edit network dialog is now hidden whenever the VM network checkbox isn't marked. If the network is non-VM, then whatever's in the (hidden) profiles tab is ignored. Change-Id: I0cb1d77310a88c58d89b997e6fb7a974d06b009e Bug-Url: https://bugzilla.redhat.com/1007286 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java 3 files changed, 22 insertions(+), 4 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cb1d77310a88c58d89b997e6fb7a974d06b009e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Removed unused constructor
by lvernia＠redhat.com 10 Oct '13

10 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Removed unused constructor ...................................................................... webadmin: Removed unused constructor Presumably added before there was a split between NewVnicProfileModel and EditVnicProfileModel, and was forgotten afterwards. Change-Id: I0a35ed37a445a1251fad427b01d133c857e8c316 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a35ed37a445a1251fad427b01d133c857e8c316 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added InfoIcon for "public" profile checkbox
by lvernia＠redhat.com 10 Oct '13

10 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Added InfoIcon for "public" profile checkbox ...................................................................... webadmin: Added InfoIcon for "public" profile checkbox In the add/edit VM dialog, the "public" checkbox in the profiles tab isn't explained, added an InfoIcon for it. Change-Id: I244fbe01be7df305af837aff3ec6c09beec4e36b Bug-Url: https://bugzilla.redhat.com/1000804 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.ui.xml 2 files changed, 23 insertions(+), 9 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/20081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I244fbe01be7df305af837aff3ec6c09beec4e36b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Removed unused variable from VnicProfileWidget
by lvernia＠redhat.com 10 Oct '13

10 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Removed unused variable from VnicProfileWidget ...................................................................... webadmin: Removed unused variable from VnicProfileWidget Change-Id: I0a43a425af36f414c4f6d69d18d487e58aa247b9 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/20080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a43a425af36f414c4f6d69d18d487e58aa247b9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: agent: clean vdsm state if vm dies unexpectedly
by gpadgett＠redhat.com 10 Oct '13

10 Oct '13

Greg Padgett has submitted this change and it was merged. Change subject: agent: clean vdsm state if vm dies unexpectedly ...................................................................... agent: clean vdsm state if vm dies unexpectedly If the hosted engine vm dies unexpectedly, vdsm will hold onto some queryable state for the vm. An attempt to start the vm will be met with an error, "Virtual machine already exists". To prevent this, check for VM state and attempt to clean it before a startup attempt by using the vdsm 'destroy' verb. Change-Id: I52c8f41c28fbc1942a8b392b275359df57c1b5ef Bug-Url: https://bugzilla.redhat.com/1013638 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py 1 file changed, 46 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52c8f41c28fbc1942a8b392b275359df57c1b5ef Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: backend: don't stop tasks on storagePoolUpEvent
by iheim＠redhat.com 10 Oct '13

10 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: backend: don't stop tasks on storagePoolUpEvent ...................................................................... backend: don't stop tasks on storagePoolUpEvent When a new SPM is elected all the tasks are already stopped by definition. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003506 Change-Id: I2014a2e5c839f2c061b67e6b147c9577914f7101 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 4 files changed, 5 insertions(+), 38 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2014a2e5c839f2c061b67e6b147c9577914f7101 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3.0.1]: packaging: ovirt-engine-3.3.0.1
by sbonazzo＠redhat.com 10 Oct '13

10 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.3.0.1 ...................................................................... packaging: ovirt-engine-3.3.0.1 Updated version to 3.3.0.1-1 Change-Id: I47dd2cc5782e4da14c56d3b856555419941f9172 Bug-Url: https://bugzilla.redhat.com/1011800 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M version.mak 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Ofer Schreiber: Looks good to me, but someone else must approve Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47dd2cc5782e4da14c56d3b856555419941f9172 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.0.1 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: DiskSizeRenderer properly handles input size unit
by derez＠redhat.com 10 Oct '13

10 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: DiskSizeRenderer properly handles input size unit ...................................................................... webadmin: DiskSizeRenderer properly handles input size unit Make DiskSizeRenderer correctly handle input in other units than bytes. Change-Id: Ief6751c9fb457e6b43166f39b7f46d30cfb938f2 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief6751c9fb457e6b43166f39b7f46d30cfb938f2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0