- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: core: Adds scheduled job DwhHeartBeat
by iheim＠redhat.com 08 Oct '13

08 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Adds scheduled job DwhHeartBeat ...................................................................... core: Adds scheduled job DwhHeartBeat Adds DwhHeartBeatInterval option to ConfigValues. Adds scheduled job DwhHeartBeat that periodically updates dwhHeart variable in dwh_history_timekeeping table. DwhHeartBeatInterval is editable in engine-config. Change-Id: Ib0db94681e678f10af40e2ffd3399231e0b8e421 Bug-Url: https://bugzilla.redhat.com/962177 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 5 files changed, 75 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0db94681e678f10af40e2ffd3399231e0b8e421 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Adds entity DwhHistoryTimekeeping and variable heartBeat
by iheim＠redhat.com 08 Oct '13

08 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: Adds entity DwhHistoryTimekeeping and variable heartBeat ...................................................................... core: Adds entity DwhHistoryTimekeeping and variable heartBeat Adds store procedures to access dwh_history_timekeeping table. Adds business entity DwhShistoryTimekeeping and its DAO. Adds new variable 'heartBeat' to dwh_history_timekeeping table Change-Id: Ib4f41ed69d77f006ce406f09d20b259ed3335ff9 Bug-Url: https://bugzilla.redhat.com/962177 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DwhHistoryTimekeeping.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DwhHistoryTimekeepingVariable.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/dwh/DwhHistoryTimekeepingDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/dwh/DwhHistoryTimekeepingDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/dwh/DwhHistoryTimekeepingDaoTest.java A packaging/dbscripts/dwh_history_timekeeping_sp.sql A packaging/dbscripts/upgrade/03_03_0930_add_dwh_heartbeat.sql 9 files changed, 296 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4f41ed69d77f006ce406f09d20b259ed3335ff9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: update search string on bookmark selection
by iheim＠redhat.com 08 Oct '13

08 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: update search string on bookmark selection ...................................................................... webadmin: update search string on bookmark selection After editing a bookmark name, that bookmark wasn't being properly cleared of its selection. The UI component was no longer selected, but the model thought it was still selected. So re-clicking that bookmark had no effect. Fixed by properly clearing the bookmark selection on bookmark save. Change-Id: Ic9763ab32eb3fcef7375553e7b9e264899583a1d Bug-Url: https://bugzilla.redhat.com/996611 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/BookmarkModelProvider.java 2 files changed, 28 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19812 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9763ab32eb3fcef7375553e7b9e264899583a1d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Disable external networks in Setup Networks
by iheim＠redhat.com 08 Oct '13

08 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Disable external networks in Setup Networks ...................................................................... webadmin: Disable external networks in Setup Networks Changed the appearance of external networks in Setup Host Networks to look disabled and not be draggable, as they truly shouldn't be statically assigned to the host's interfaces. Did this by extending the hierarchy of related classes. InternalNetworkPanel should behave like a native network, while ExternalNetworkPanel is a disabled variation of it. Common code is housed in the common ancestor NetworkPanel. Also refactored some code around UnassignedNetworksPanel for reuse. Change-Id: I556ec7a330236dbdb204b82b2ff67f86ed4dbea8 Bug-Url: https://bugzilla.redhat.com/990612 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ExternalNetworkPanel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ExternalNetworksPanel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/InternalNetworkPanel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/InternalNetworksPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/UnassignedNetworksPanel.java 12 files changed, 236 insertions(+), 88 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I556ec7a330236dbdb204b82b2ff67f86ed4dbea8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: help icon overflow
by iheim＠redhat.com 08 Oct '13

08 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: help icon overflow ...................................................................... webadmin: help icon overflow - Fixed issue where if a popup header was too long it would cause the help icon to overflow to the next line and look out of place. Re-arranged the header layout a little bit so the title text is in its own div that is moved on top of the title background to allow for flowing onto any background. Signed-off-by: Alexander Wels <awels(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1001554 Change-Id: I10abcbd977df4367584cc22529b47334c4c00d99 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/SimpleDialogPanel.ui.xml M packaging/branding/ovirt.brand/common.css 3 files changed, 32 insertions(+), 42 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10abcbd977df4367584cc22529b47334c4c00d99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: fix tabs shown/hidden when tags selected/unselected
by iheim＠redhat.com 08 Oct '13

08 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: fix tabs shown/hidden when tags selected/unselected ...................................................................... webadmin: fix tabs shown/hidden when tags selected/unselected Fixed tab show logic so that when a tag is selected, only Hosts, VMs, and Users tabs are visible. When no tag is selected, tabs behave as if System node is selected. Change-Id: I6cace6daecef58ee2726a22e880d5c31e03e275f Bug-Url: https://bugzilla.redhat.com/1006282 Bug-Url: https://bugzilla.redhat.com/996594 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 19 insertions(+), 14 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19813 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6cace6daecef58ee2726a22e880d5c31e03e275f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Allowed non-draggable NetworkItemPanel
by iheim＠redhat.com 08 Oct '13

08 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Allowed non-draggable NetworkItemPanel ...................................................................... webadmin: Allowed non-draggable NetworkItemPanel It seems that so far setting draggable to false did nothing, the item would still be draggable; for some reason calling setDraggable(Element.DRAGGABLE_FALSE) adds the draggable property to an element and sets it to true! Added some code to disable the "draggable skin" and the actual drag operation when an item has been constructed as non-draggable. Also, changed bonds to be draggable explicitly, as they have been draggable all this time and I've heard no complaints. Change-Id: I0f130803ce2403cc26297ec8d06ef62d23837b96 Bug-Url: https://bugzilla.redhat.com/990612 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/BondPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java 2 files changed, 20 insertions(+), 17 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f130803ce2403cc26297ec8d06ef62d23837b96 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Changed Boolean argument to boolean
by iheim＠redhat.com 08 Oct '13

08 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Changed Boolean argument to boolean ...................................................................... webadmin: Changed Boolean argument to boolean There was no reason to ever pass null rather than true or false, and no code called these constructors with a null value. Change-Id: Ib99896c52b950dcf56891c5e6e2e8b7b760bc830 Bug-Url: https://bugzilla.redhat.com/990612 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib99896c52b950dcf56891c5e6e2e8b7b760bc830 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: support the newly-tagged vdsm-4.13
by iheim＠redhat.com 08 Oct '13

08 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: support the newly-tagged vdsm-4.13 ...................................................................... core: support the newly-tagged vdsm-4.13 vdsm-4.13 would be part of oVirt-3.3.1. Change-Id: I12dacd46973cde693105c21ae5bc41aec7fe7863 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19973 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12dacd46973cde693105c21ae5bc41aec7fe7863 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: shceduling: destination host isn't guaranteed
by iheim＠redhat.com 08 Oct '13

08 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: shceduling: destination host isn't guaranteed ...................................................................... core: shceduling: destination host isn't guaranteed when migrating VM to a specific host, or running once VM on a specific host, and the specified host isn't suitable for running the VM, another host could be selected. this patch fixes that, and the operation would fail. Change-Id: I6894c0d8d42bd57026ccc36b52d9d266add14384 Bug-Url: https://bugzilla.redhat.com/999630 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 7 files changed, 41 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6894c0d8d42bd57026ccc36b52d9d266add14384 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0