- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3.0.1]: packaging: setup: Do not log passwords
by sbonazzo＠redhat.com 08 Oct '13

08 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Do not log passwords ...................................................................... packaging: setup: Do not log passwords Most of the code already refrains from logging passwords. This change also makes upgrade from legacy 3.2 code not log the db password and also makes otopi not log db password and admin password in dumpEnvironment even if set from an answer file etc. Depends on http://gerrit.ovirt.org/19776 . Bug-Url: https://bugzilla.redhat.com/1014115 Change-Id: I81c7371eaf930b3cc21861deb620c61891ad4d1f Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in M packaging/setup/plugins/ovirt-engine-common/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/config/options.py M packaging/setup/plugins/ovirt-engine-setup/legacy/database.py 4 files changed, 27 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/19939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81c7371eaf930b3cc21861deb620c61891ad4d1f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.0.1 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Gluster task monitoring for tasks started from CLI
by kmayilsa＠redhat.com 08 Oct '13

08 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Gluster task monitoring for tasks started from CLI ...................................................................... engine: Gluster task monitoring for tasks started from CLI Added code to detect tasks started from CLI and create a Job in engine so that these can be monitored and managed from engine The Job created will be of one of 2 action types - REBALANCING_VOLUME or REMOVING_BRICKS and will have the following steps - Executing step and a sub-step under this corresponding to the Gluster task Change-Id: Ibb6385cbcad988351f23bda2294c8e85dde54560 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java 2 files changed, 171 insertions(+), 6 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/19183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb6385cbcad988351f23bda2294c8e85dde54560 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Introduced InternalJob and InternalStep command
by kmayilsa＠redhat.com 08 Oct '13

08 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine: Introduced InternalJob and InternalStep command ...................................................................... engine: Introduced InternalJob and InternalStep command Introduced AddInternalJob and AddInternalStep commands which will be used to add a job and step to monitor operations started outside of engine, but that can be managed by engine. Refactored AddExternalJob and AddExternalStep commands by inheriting from an AddJob and AddStep command. Change-Id: I17074d4317c037fa9fcc680f4b0a7a9b3a6b087a Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalJobCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddInternalJobCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddInternalStepCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddJobCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddStepCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalJobParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalStepParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddInternalJobParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddJobParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddStepParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 16 files changed, 344 insertions(+), 161 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/19182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17074d4317c037fa9fcc680f4b0a7a9b3a6b087a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Do not log passwords
by iheim＠redhat.com 07 Oct '13

07 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: Do not log passwords ...................................................................... packaging: setup: Do not log passwords Most of the code already refrains from logging passwords. This change also makes upgrade from legacy 3.2 code not log the db password and also makes otopi not log db password and admin password in dumpEnvironment even if set from an answer file etc. Depends on http://gerrit.ovirt.org/19776 . Bug-Url: https://bugzilla.redhat.com/1014115 Change-Id: I81c7371eaf930b3cc21861deb620c61891ad4d1f Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in M packaging/setup/plugins/ovirt-engine-common/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/config/options.py M packaging/setup/plugins/ovirt-engine-setup/legacy/database.py 4 files changed, 27 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81c7371eaf930b3cc21861deb620c61891ad4d1f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Suuport aborting migration on qemu error
by rgolan＠redhat.com 07 Oct '13

07 Oct '13

Roy Golan has submitted this change and it was merged. Change subject: core: Suuport aborting migration on qemu error ...................................................................... core: Suuport aborting migration on qemu error following libvirt support[1] and vdsm[2] to abort an on going migration on any error using a flag, adding this to the engine from version >= 3.3 [1] https://bugzilla.redhat.com/972675 [2] https://bugzilla.redhat.com/961154 Change-Id: I048c96f049d24b9793af669d513d1e9f2e1f24ec Bug-Url: https://bugzilla.redhat.com/886416 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 6 files changed, 27 insertions(+), 3 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I048c96f049d24b9793af669d513d1e9f2e1f24ec Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Cannot add hypervisor host when use chinese support
by derez＠redhat.com 07 Oct '13

07 Oct '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Cannot add hypervisor host when use chinese support ...................................................................... webadmin: Cannot add hypervisor host when use chinese support When adding a new host using chinese locale the root user name gets localized leading to error in user name when trying to establish an ssh session Change-Id: Ifdc4a332a297bca1b7c99bc6ede5a5aeacbc6431 Bug-Url: https://bugzilla.redhat.com/1008258 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InstallModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 3 files changed, 3 insertions(+), 5 deletions(-) Approvals: Ravi Nori: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdc4a332a297bca1b7c99bc6ede5a5aeacbc6431 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Typo in welcome page.
by ecohen＠redhat.com 07 Oct '13

07 Oct '13

Einav Cohen has submitted this change and it was merged. Change subject: engine: Typo in welcome page. ...................................................................... engine: Typo in welcome page. - Fixed typo in welcome page, changed Administrator portal, to Administration portal. Change-Id: I6a45d39de3f7268b653d388dab4357839a30ea4c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1011437 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M packaging/branding/ovirt.brand/messages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a45d39de3f7268b653d388dab4357839a30ea4c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: frontend: Correct default time-zone rendering
by iheim＠redhat.com 07 Oct '13

07 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: frontend: Correct default time-zone rendering ...................................................................... frontend: Correct default time-zone rendering TimeZoneModel was returning incorrect display value in case the configured default was invalid. Now it returns display value corresponding to ultimate fallback for given TimeZoneType. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988259 Change-Id: Ic7be050a48c78ffdf2028ea5acfd0123bf4502a7 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TimeZoneModel.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Betak: Verified -- To view, visit http://gerrit.ovirt.org/19929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7be050a48c78ffdf2028ea5acfd0123bf4502a7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: Do not log passwords
by sbonazzo＠redhat.com 07 Oct '13

07 Oct '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Do not log passwords ...................................................................... packaging: setup: Do not log passwords Most of the code already refrains from logging passwords. This change also makes upgrade from legacy 3.2 code not log the db password and also makes otopi not log db password and admin password in dumpEnvironment even if set from an answer file etc. Depends on http://gerrit.ovirt.org/19776 . Bug-Url: https://bugzilla.redhat.com/1014115 Change-Id: I81c7371eaf930b3cc21861deb620c61891ad4d1f Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in M packaging/setup/plugins/ovirt-engine-common/db/connection.py M packaging/setup/plugins/ovirt-engine-setup/config/options.py M packaging/setup/plugins/ovirt-engine-setup/legacy/database.py 4 files changed, 27 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81c7371eaf930b3cc21861deb620c61891ad4d1f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: action to stop brick removal operation
by kmayilsa＠redhat.com 07 Oct '13

07 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: action to stop brick removal operation ...................................................................... webadmin: action to stop brick removal operation Intoduced an action group for brick removal operations. Modified existing 'Remove' action to 'Start' and moved under the new 'Remove' action group. Added a new action 'Stop' to abort the brick removal operation. On clicking this action, a confirmation will shown to make sure the user actually wants to stop. Change-Id: Ia1d1653e168aa00b6b4c17d4608f5d96558aa462 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java 4 files changed, 142 insertions(+), 8 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1d1653e168aa00b6b4c17d4608f5d96558aa462 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0