- Engine-commits - oVirt List Archives

Change in ovirt-guest-agent[master]: Ubuntu Packaging: add python-apt to dependency
by vfeenstr＠redhat.com 01 Oct '13

01 Oct '13

Vinzenz Feenstra has submitted this change and it was merged. Change subject: Ubuntu Packaging: add python-apt to dependency ...................................................................... Ubuntu Packaging: add python-apt to dependency In ovirt-guest-agent/GuestAgentLinux2.py we try to import apt module. This module is provided by python-apt on Debian and Ubuntu. This patch adds python-apt to package dependency. Change-Id: I7a248b43c541ded03a26625896881d89a0d6401d Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> --- M debian/control 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a248b43c541ded03a26625896881d89a0d6401d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: fix sound device check when adding devices from ovf (#...
by iheim＠redhat.com 01 Oct '13

01 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core: fix sound device check when adding devices from ovf (#1004066) ...................................................................... core: fix sound device check when adding devices from ovf (#1004066) When creating vm from ovf, there is a check to add sound device to the vm if it doesn't exist and needed. the existence check was wrong as it used 'device' compared with 'type'. this patch fix the check to use the correct fields (type). Change-Id: I117c18f95db1ed672f6d0a8c4ff5c003d3fb6d4a Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1004066 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I117c18f95db1ed672f6d0a8c4ff5c003d3fb6d4a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3.0.1]: engine: Engine has to delete image from DB after VDSM remove...
by oschreib＠redhat.com 01 Oct '13

01 Oct '13

Ofer Schreiber has submitted this change and it was merged. Change subject: engine: Engine has to delete image from DB after VDSM removed it ...................................................................... engine: Engine has to delete image from DB after VDSM removed it Engine has to delete image from DB after VDSM removed it from storage, but thrown an error in the process. What is really matter in this case is whether the image still exists on the storage or not. VDSM renames the image as a first step to removal. After renaming the image doesn't exist, so if the error is thrown at this point the garbage will stay on the storage, but its safe to remove image from DB. Change-Id: If6e6922b153145de6d4515812c1cfede687544bc Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java 1 file changed, 32 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Sergey Gotliv: Verified -- To view, visit http://gerrit.ovirt.org/19703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6e6922b153145de6d4515812c1cfede687544bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.0.1 Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: agent: Fix python-2.4 compatibility
by bazulay＠redhat.com 01 Oct '13

01 Oct '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Fix python-2.4 compatibility ...................................................................... agent: Fix python-2.4 compatibility Rewrote the use of ternary operator to if since it is not supported in python-2.4. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1006861 Change-Id: I03c63477a2d2bcb9eb4c4307946a3486300663e1 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/OVirtAgentLogic.py 3 files changed, 14 insertions(+), 5 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03c63477a2d2bcb9eb4c4307946a3486300663e1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: add support for ram/vram on QXL device
by ofrenkel＠redhat.com 01 Oct '13

01 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: add support for ram/vram on QXL device ...................................................................... engine: add support for ram/vram on QXL device setting support for qxl device with proper ram/vram attributes: 1 Monitor, Single PCI checked 64MB 32MB 2 Monitors, Single PCI checked 128MB 32MB 4 Monitors, Single PCI checked 256MB 32MB Change-Id: I0d380901daea93c3d6dbdfee48addf190e15ed5a Bug-Url: https://bugzilla.redhat.com/787578 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 3 files changed, 23 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d380901daea93c3d6dbdfee48addf190e15ed5a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: introduce generic file serving
by oschreib＠redhat.com 01 Oct '13

01 Oct '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: introduce generic file serving ...................................................................... packaging: introduce generic file serving current implementation adds a reference for each file within root web.xml, this is inflexible to manage and add new files as needed. new implementation defines maps /ovirt-engine-files URI into /usr/share/ovirt-engine/files, every file within that directory will be exposed to application. packaging can add misc files or symlinks to expose files based on specific location or capabilities. moved: 1. spice 2. spice-html5 3. novnc usbfilter.txt moved out of spice directory as it is application provided and not spice artifact. Change-Id: I1cd8b39ff2647bc006e09d50c9fc7088fcef7434 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M backend/manager/modules/root/src/main/webapp/ovirt-engine-novnc-main.html M backend/manager/modules/root/src/main/webapp/ovirt-engine-spicehtml5-main.html M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M ovirt-engine.spec.in M packaging/conf/ovirt-engine-proxy.conf.v2.in M packaging/services/ovirt-engine/ovirt-engine.conf.in 9 files changed, 41 insertions(+), 144 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cd8b39ff2647bc006e09d50c9fc7088fcef7434 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: osinfo - change OSs audio device
by rgolan＠redhat.com 01 Oct '13

01 Oct '13

Roy Golan has submitted this change and it was merged. Change subject: core: osinfo - change OSs audio device ...................................................................... core: osinfo - change OSs audio device Esentially old OSs[1] supports ac97 emulated sound device while all the new supports ich6 - intell HD audio definition. [1] RHEL 3,4,5, Windows XP, Windows 2003 32/64 Change-Id: I1a614d7be71cae8beaf1df36056b6945f84ae981 Bug-Url: https://bugzilla.redhat.com/1002695 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 16 insertions(+), 9 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a614d7be71cae8beaf1df36056b6945f84ae981 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Removed custom MAC leftovers from dialog
by masayag＠redhat.com 01 Oct '13

01 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Removed custom MAC leftovers from dialog ...................................................................... webadmin: Removed custom MAC leftovers from dialog The code meant to remove the custom MAC address checkbox and explanation label didn't work because it was called asynchronously, and apparently would only get disabled after the widget would get edited and thus have no effect. Change-Id: I5fc1bb2183b87567213ac9c5e8cb83e8a728979a Bug-Url: https://bugzilla.redhat.com/1007506 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fc1bb2183b87567213ac9c5e8cb83e8a728979a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core : DAO Tests fail because of fk_vm_static_quota
by iheim＠redhat.com 30 Sep '13

30 Sep '13

Itamar Heim has submitted this change and it was merged. Change subject: core : DAO Tests fail because of fk_vm_static_quota ...................................................................... core : DAO Tests fail because of fk_vm_static_quota A new foreign key constraint added to vm_static table fk_vm_static_quota requires tests to have a existing quota id and also requires that the quota table be populated before inserting data into vm_static table Change-Id: Ia15cd17950c7b5aa082452a9014ec67ffa0da0da Bug-Url: https://bugzilla.redhat.com/1003839 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 77 insertions(+), 75 deletions(-) Approvals: Doron Fediuck: Looks good to me, approved Gilad Chaplik: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/19699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia15cd17950c7b5aa082452a9014ec67ffa0da0da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: prevent disabling VirtIO-SCSI on edit VM
by derez＠redhat.com 30 Sep '13

30 Sep '13

Daniel Erez has submitted this change and it was merged. Change subject: core: prevent disabling VirtIO-SCSI on edit VM ...................................................................... core: prevent disabling VirtIO-SCSI on edit VM When a disk with VirtIO-SCSI interface is plugged to a VM, disabling VirtIO-SCSI should be prevented. Change-Id: Ic2e6c85a2df434de3180f19a32079f276458d372 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 44 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2e6c85a2df434de3180f19a32079f276458d372 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0