- Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: core, frontend: allow console reconnect incorrectly handled
by iheim＠redhat.com 02 Oct '13

02 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: core,frontend: allow console reconnect incorrectly handled ...................................................................... core,frontend: allow console reconnect incorrectly handled Problems: - it was not dependent on the VM Type - by default it was not checked but since the default VM Type is server it should have been - it was completly ignored on the pool (both on FE and on BE) This patch fixes all of this issues. Change-Id: I16c364133ce5da37517007960ba6fb4af79a6aea Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1005689 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 6 files changed, 8 insertions(+), 4 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16c364133ce5da37517007960ba6fb4af79a6aea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: resatpi: Eliminate Exceptions in Mapper Tests
by oliel＠redhat.com 02 Oct '13

02 Oct '13

Ori Liel has submitted this change and it was merged. Change subject: resatpi: Eliminate Exceptions in Mapper Tests ...................................................................... resatpi: Eliminate Exceptions in Mapper Tests Up until now, mapper tests silently ignored several failures to instantiated new objects using reflection. There were two types of problems: - Instantiation of objects with no empty constructor (namely XMLGregorianCalendar) - Mismatch between plural and singular entity name, e.g: 'Floppies.java' vs 'Floppy.java' (differenct than truncating the suffix 's') All exceptional cases have been handled in this patch, and all methods that had a try/catch clause, which swallowed the exception, were made to 'throw' the exception onward instead. Change-Id: I84cabed0ff38196d8fd57d2f72ffdfe213f2ffed Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/AbstractInvertibleMappingTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/GlusterBrickDetailMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java 3 files changed, 105 insertions(+), 79 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84cabed0ff38196d8fd57d2f72ffdfe213f2ffed Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Improve Performance in mapper tests
by oliel＠redhat.com 02 Oct '13

02 Oct '13

Ori Liel has submitted this change and it was merged. Change subject: restapi: Improve Performance in mapper tests ...................................................................... restapi: Improve Performance in mapper tests Change-Id: I29908ea9d5cf232a3079f28927b70ad0ce37a010 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/NetworkMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 3 files changed, 33 insertions(+), 10 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29908ea9d5cf232a3079f28927b70ad0ce37a010 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Fixed public profile in add/edit network
by iheim＠redhat.com 02 Oct '13

02 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Fixed public profile in add/edit network ...................................................................... webadmin: Fixed public profile in add/edit network Didn't do nothing before, now actually sets whether the profile may be used by all users or not. Change-Id: Ie87563dd45d3343bd963c2f4a1ed228361589823 Bug-Url: https://bugzilla.redhat.com/1000801 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie87563dd45d3343bd963c2f4a1ed228361589823 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: add support for ram/vram on QXL device
by iheim＠redhat.com 02 Oct '13

02 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: add support for ram/vram on QXL device ...................................................................... engine: add support for ram/vram on QXL device setting support for qxl device with proper ram/vram attributes: 1 Monitor, Single PCI checked 64MB 32MB 2 Monitors, Single PCI checked 128MB 32MB 4 Monitors, Single PCI checked 256MB 32MB Change-Id: I0d380901daea93c3d6dbdfee48addf190e15ed5a Bug-Url: https://bugzilla.redhat.com/787578 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 3 files changed, 23 insertions(+), 15 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d380901daea93c3d6dbdfee48addf190e15ed5a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: adding a filter policy for CPU level
by oourfali＠redhat.com 02 Oct '13

02 Oct '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: adding a filter policy for CPU level ...................................................................... core: adding a filter policy for CPU level Change-Id: Ib42b803fe0d2e9389d10196cd44c3fd21342927f Bug-Url: https://bugzilla.redhat.com/1006209 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/PolicyUnitImpl.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuLevelFilterPolicyUnit.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_03_0940_add_cpu_level_policy_unit.sql 8 files changed, 67 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib42b803fe0d2e9389d10196cd44c3fd21342927f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: saving the cpu_name in vm_dynamic
by oourfali＠redhat.com 02 Oct '13

02 Oct '13

Oved Ourfali has submitted this change and it was merged. Change subject: core: saving the cpu_name in vm_dynamic ...................................................................... core: saving the cpu_name in vm_dynamic This patch adds the cpu_name property to the vm_dynamic table, to allow knowing what cpu was configured in the cluster when running the VM Change-Id: I2f13891b3425e4864334851ecb12d1d61a162082 Bug-Url: https://bugzilla.redhat.com/1006209 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_03_0930_add_cpu_name_to_vm_dynamic.sql M packaging/dbscripts/vms_sp.sql 12 files changed, 48 insertions(+), 11 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f13891b3425e4864334851ecb12d1d61a162082 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core+ui: Support lowering cluster CPU level
by oourfali＠redhat.com 02 Oct '13

02 Oct '13

Oved Ourfali has submitted this change and it was merged. Change subject: core+ui: Support lowering cluster CPU level ...................................................................... core+ui: Support lowering cluster CPU level This patch removes the validation of not lowering down the cluster CPU level while VMs are running. A proper warning and confirmation window is displayed instead. Change-Id: I69a32299b5782e69aef8832501dc8969b6dc810c Bug-Url: https://bugzilla.redhat.com/1006209 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNumberOfActiveVmsInVdsGroupByVdsGroupIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 119 insertions(+), 13 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69a32299b5782e69aef8832501dc8969b6dc810c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fixed public profile in add/edit network
by masayag＠redhat.com 02 Oct '13

02 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Fixed public profile in add/edit network ...................................................................... webadmin: Fixed public profile in add/edit network Didn't do nothing before, now actually sets whether the profile may be used by all users or not. Change-Id: Ie87563dd45d3343bd963c2f4a1ed228361589823 Bug-Url: https://bugzilla.redhat.com/1000801 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/19742 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie87563dd45d3343bd963c2f4a1ed228361589823 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Only display gateway if feature supported
by masayag＠redhat.com 02 Oct '13

02 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Only display gateway if feature supported ...................................................................... webadmin: Only display gateway if feature supported Set the visibility of the gateway field, when editing a non-management host network, according to whether the multiple gateway feature is supported, so it wouldn't show in older clusters. Change-Id: Ic31614a9a86e68a0840331f63ec2ac711ab8ac5f Bug-Url: https://bugzilla.redhat.com/1008999 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java 4 files changed, 7 insertions(+), 4 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic31614a9a86e68a0840331f63ec2ac711ab8ac5f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0