- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Use StoragePoolValidator
by amureini＠redhat.com 15 Sep '13

15 Sep '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Use StoragePoolValidator ...................................................................... core: Use StoragePoolValidator Moved validations on UP status to use the validator. Change-Id: Ib178d9a6397552953becabb4e3f6a0b3133bbabf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java 3 files changed, 7 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib178d9a6397552953becabb4e3f6a0b3133bbabf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Update Tx/Rx in Host Interfaces subtab
by derez＠redhat.com 15 Sep '13

15 Sep '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Update Tx/Rx in Host Interfaces subtab ...................................................................... webadmin: Update Tx/Rx in Host Interfaces subtab Was formerly disabled due to exceptions being thrown; at the moment the values seem to be updated well and without causing any trouble. Change-Id: I68e37c6c37480eca3512c84b06690a18aabea2eb Bug-Url: https://bugzilla.redhat.com/746458 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19235 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68e37c6c37480eca3512c84b06690a18aabea2eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: history: added missing user login column to 3.3 views
by ydary＠redhat.com 15 Sep '13

15 Sep '13

Yaniv Dary has submitted this change and it was merged. Change subject: history: added missing user login column to 3.3 views ...................................................................... history: added missing user login column to 3.3 views Change-Id: I4d2fe12931a584bedbf7f82b02712b135da4f8a3 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/historydbscripts_postgres/create_views_3_3.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d2fe12931a584bedbf7f82b02712b135da4f8a3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: restapi: invalidate session only when it expires
by mpastern＠redhat.com 15 Sep '13

15 Sep '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: invalidate session only when it expires ...................................................................... restapi: invalidate session only when it expires Change-Id: Ib85c38dea961b252853bcae48912aa40a4ff7e77 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib85c38dea961b252853bcae48912aa40a4ff7e77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: API: editing host add and update fields - exposing all store...
by mpastern＠redhat.com 15 Sep '13

15 Sep '13

Michael Pasternak has submitted this change and it was merged. Change subject: API: editing host add and update fields - exposing all stored ssh fields ...................................................................... API: editing host add and update fields - exposing all stored ssh fields Change-Id: I640cfca4057ffd65d37afc10bc5ac2e12f1aafd5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=999640 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I640cfca4057ffd65d37afc10bc5ac2e12f1aafd5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3.0]: restapi: invalidate session only when it expires
by mpastern＠redhat.com 15 Sep '13

15 Sep '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: invalidate session only when it expires ...................................................................... restapi: invalidate session only when it expires Change-Id: Ib85c38dea961b252853bcae48912aa40a4ff7e77 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib85c38dea961b252853bcae48912aa40a4ff7e77 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.0 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: invalidate session only when it expires
by mpastern＠redhat.com 15 Sep '13

15 Sep '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: invalidate session only when it expires ...................................................................... restapi: invalidate session only when it expires Change-Id: Ib85c38dea961b252853bcae48912aa40a4ff7e77 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib85c38dea961b252853bcae48912aa40a4ff7e77 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi : Update of power management via cli ignored(#959879)
by mpastern＠redhat.com 15 Sep '13

15 Sep '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Update of power management via cli ignored(#959879) ...................................................................... restapi : Update of power management via cli ignored(#959879) Unable update power management fields via cli, but the same works from web admin portal This patch fixes all fields common between agents and the power management model Change-Id: Ifece398fd70a5928665c6f0c96a80450a6866f59 Bug-Url: https://bugzilla.redhat.com/959879 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java 1 file changed, 76 insertions(+), 24 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifece398fd70a5928665c6f0c96a80450a6866f59 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3.0]: core: Take into account command transactivity scope when...
by yzaslavs＠redhat.com 15 Sep '13

15 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Take into account command transactivity scope when... ...................................................................... core: Take into account command transactivity scope when... Take into account command transactivity scope when creating new task duing persistence of place holder. If the command is transactive - create the place holder in a new transaction, so the record will be recognized when there will be association between VDSM task ID and db task ID. This will solve the bug in which removal of template causes some records with empty VDSM task ID to be left after command ends. Change-Id: I97c27cbb8c869182edeefbd3f2cc8c8d466aa29e Bug-Url: https://bugzilla.redhat.com/990543 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 19 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97c27cbb8c869182edeefbd3f2cc8c8d466aa29e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.0 Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: unescape cell tooltips string values
by derez＠redhat.com 15 Sep '13

15 Sep '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: unescape cell tooltips string values ...................................................................... webadmin: unescape cell tooltips string values SafeHtmlCellWithTooltip -> getTooltip: Unescaping title's text value to prevent tooltips with escaped characters/html tags (unrendered) [it should be safe since browsers natively render title attributes as string]. Example screenshots: * escaped (current) - http://imgur.com/8aNIouV unescaped - http://imgur.com/nQFP0jx * escaped (current) - http://imgur.com/9HxHA4H unescaped - http://imgur.com/8wzOUVE Change-Id: I2da6812694737c212352afda48fa9a50e97f8d60 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1001851 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SafeHtmlCellWithTooltip.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/TextCellWithTooltip.java 2 files changed, 16 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2da6812694737c212352afda48fa9a50e97f8d60 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0