- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Avoid XSS in RedirectServlet
by ecohen＠redhat.com 12 Sep '13

12 Sep '13

Einav Cohen has submitted this change and it was merged. Change subject: core: Avoid XSS in RedirectServlet ...................................................................... core: Avoid XSS in RedirectServlet Currently the RedirectServlet composes JavaScript code to show error messages using text provided by the user in a request parameter. This text isn't sanitized and thus can be used by maliciuous users to execute arbitrary JavaScript code. To avoid this situation this patch changes the servlet so that it doesn't receive any parameter, thus the problem is completely avoided. Signed-off-by: Alexander Wels <awels(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> Change-Id: Ie77e6a063e1522b2e108076a240939ca1dae272e --- D backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/redirect/ReportsRedirectServlet.java M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml M packaging/branding/ovirt.brand/welcome_page.template 4 files changed, 48 insertions(+), 112 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie77e6a063e1522b2e108076a240939ca1dae272e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Add audit log messages to GetAlignmentScanCommand
by amureini＠redhat.com 12 Sep '13

12 Sep '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Add audit log messages to GetAlignmentScanCommand ...................................................................... engine: Add audit log messages to GetAlignmentScanCommand Change-Id: I4400aea34bd848416e67b7bb77a92b4fd581ff1e Bug-Url: https://bugzilla.redhat.com/1006326 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 20 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4400aea34bd848416e67b7bb77a92b4fd581ff1e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Cheryn Tan <cheryntan(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.3]: log: write only errors on stderr
by sbonazzo＠redhat.com 12 Sep '13

12 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: log: write only errors on stderr ...................................................................... log: write only errors on stderr Previously the logging system wrote all the messages to the standard error. Now only errors are logged to the standard error, all the other message are logged to standard output. Change-Id: I4e6cde74421c5b513cba0c2b56fa73acfa212e87 Bug-Url: https://bugzilla.redhat.com/1006792 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 19 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19196 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e6cde74421c5b513cba0c2b56fa73acfa212e87 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Expose additional AuditLog fields to UI plugins
by vszocs＠redhat.com 12 Sep '13

12 Sep '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Expose additional AuditLog fields to UI plugins ...................................................................... webadmin: Expose additional AuditLog fields to UI plugins This change will allow additional fields in the AuditLog(Event) object to be accessible by the plugin API. The new fields are as follows: correlationId message callStack customEventId toString Change-Id: I846b1e46e26dbff0d6b8c62eee0471555edc9bbf Signed-off-by: Spenser Shumaker <sshumake(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/entity/EntityObject.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Spenser Shumaker: Looks good to me, but someone else must approve Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I846b1e46e26dbff0d6b8c62eee0471555edc9bbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Spenser Shumaker <sshumake(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Spenser Shumaker <sshumake(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[master]: log: write only errors on stderr
by sbonazzo＠redhat.com 12 Sep '13

12 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: log: write only errors on stderr ...................................................................... log: write only errors on stderr Previously the logging system wrote all the messages to the standard error. Now only errors are logged to the standard error, all the other message are logged to standard output. Change-Id: I4e6cde74421c5b513cba0c2b56fa73acfa212e87 Bug-Url: https://bugzilla.redhat.com/1006792 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 19 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e6cde74421c5b513cba0c2b56fa73acfa212e87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.3]: log: write only errors on stderr
by sbonazzo＠redhat.com 12 Sep '13

12 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: log: write only errors on stderr ...................................................................... log: write only errors on stderr Previously the logging system wrote all the messages to the standard error. Now only errors are logged to the standard error, all the other message are logged to standard output. Also addresses minor pep8 issues preventing make check to exit with success. Bug-Url: https://bugzilla.redhat.com/956518 Change-Id: Iee176b539dc7bcecc64b26e3c05db7c8a7ee86d6 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py M src/config.py.in.in 2 files changed, 29 insertions(+), 13 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee176b539dc7bcecc64b26e3c05db7c8a7ee86d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-log-collector[master]: log: write only errors on stderr
by sbonazzo＠redhat.com 12 Sep '13

12 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: log: write only errors on stderr ...................................................................... log: write only errors on stderr Previously the logging system wrote all the messages to the standard error. Now only errors are logged to the standard error, all the other message are logged to standard output. Also addresses minor pep8 issues preventing make check to exit with success. Bug-Url: https://bugzilla.redhat.com/956518 Change-Id: Iee176b539dc7bcecc64b26e3c05db7c8a7ee86d6 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py M src/config.py.in.in 2 files changed, 29 insertions(+), 13 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee176b539dc7bcecc64b26e3c05db7c8a7ee86d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[ovirt-iso-uploader-3.3]: upload: nfs: handle rename errors
by sbonazzo＠redhat.com 12 Sep '13

12 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: upload: nfs: handle rename errors ...................................................................... upload: nfs: handle rename errors Uploading to a NFS destination, if an error were encountered while renaming the used temporary file to the final destination, the application displayed: uploaded successfully. Now the application exits with exit status 3 (upload error) and display an error message. Added also a debug log for recording the rename action in the verbose log. Change-Id: I8fc993d0fdc36924cbf3dd7ed50569ccdcfc75b5 Bug-Url: https://bugzilla.redhat.com/1005100 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 42 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fc993d0fdc36924cbf3dd7ed50569ccdcfc75b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: ovirt-iso-uploader-3.3 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-iso-uploader[master]: upload: nfs: handle rename errors
by sbonazzo＠redhat.com 12 Sep '13

12 Sep '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: upload: nfs: handle rename errors ...................................................................... upload: nfs: handle rename errors Uploading to a NFS destination, if an error were encountered while renaming the used temporary file to the final destination, the application displayed: uploaded successfully. Now the application exits with exit status 3 (upload error) and display an error message. Added also a debug log for recording the rename action in the verbose log. Change-Id: I8fc993d0fdc36924cbf3dd7ed50569ccdcfc75b5 Bug-Url: https://bugzilla.redhat.com/1005100 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 42 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fc993d0fdc36924cbf3dd7ed50569ccdcfc75b5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3.0]: pacakging: bump rpm release to 3
by oschreib＠redhat.com 12 Sep '13

12 Sep '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pacakging: bump rpm release to 3 ...................................................................... pacakging: bump rpm release to 3 Bump release in order to force upgrade of current public RPM Change-Id: Id2bb980b16231d5d33f81c81c00ddc82cfe68ee7 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M version.mak 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2bb980b16231d5d33f81c81c00ddc82cfe68ee7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3.0 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0