- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: MaxVmNameLength(Non)Windows ignored
by tjelinek＠redhat.com 12 Sep '13

12 Sep '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: MaxVmNameLength(Non)Windows ignored ...................................................................... frontend: MaxVmNameLength(Non)Windows ignored It has already been fixed but not completly correctly. There is still a chance that the static variables will be inited sooner than the cache from which the values are taken. Fixed by moving the corresponding logic to AsyncDataProvider which is anyway a better place for it and postpone the calling of it until it is really needed so the cache will be inited for sure (otherwise it would be not possible to reach to the code which uses it). Change-Id: I9a1ac29aadc731f6fe4a0e62db7e78a5160ededa Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/PoolNameLengthValidation.java 4 files changed, 16 insertions(+), 18 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18989 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a1ac29aadc731f6fe4a0e62db7e78a5160ededa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: application touches a file to detect un orderly shut...
by yzaslavs＠redhat.com 11 Sep '13

11 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: application touches a file to detect un orderly shutdown ...................................................................... engine: application touches a file to detect un orderly shutdown Used to diagnose unexpected engine stop by the notification service. Previously we used the pid file, buy this solution becomes irrelevant for systemd. Change-Id: Ic8de64637299e7932a5a2761c7bb495373c418aa Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=743660 Signed-off-by: Mooli Tayer <mtayer(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M packaging/services/ovirt-engine/ovirt-engine.conf.in M packaging/services/ovirt-engine/ovirt-engine.py 4 files changed, 37 insertions(+), 14 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8de64637299e7932a5a2761c7bb495373c418aa Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Revert "engine : VdsUpdateRuntimeInfo updates the data of a ...
by yzaslavs＠redhat.com 11 Sep '13

11 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Revert "engine : VdsUpdateRuntimeInfo updates the data of a specific VDS." ...................................................................... Revert "engine : VdsUpdateRuntimeInfo updates the data of a specific VDS." This reverts commit ada255ebded1bf71f0e19c005dd2982914309173. Change-Id: I0c1d190fc24c0c31d871c3269bd7faee25a721ea Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterOptionDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkStatisticsDaoDbFacadeImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 17 files changed, 67 insertions(+), 233 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c1d190fc24c0c31d871c3269bd7faee25a721ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: sort domain list query results
by ecohen＠redhat.com 11 Sep '13

11 Sep '13

Einav Cohen has submitted this change and it was merged. Change subject: engine: sort domain list query results ...................................................................... engine: sort domain list query results Changed the domain list query results to be sorted alphabetically, with the special case of "internal" always appearing at the bottom. Change-Id: Ia7e9f80b47a5b65924d7f78d7f658cf5db478ed1 Bug-Url: https://bugzilla.redhat.com/785555 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDomainListQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginDomainComparator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/LoginDomainComparatorTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java 4 files changed, 120 insertions(+), 2 deletions(-) Approvals: Einav Cohen: Looks good to me, approved Greg Sheremeta: Verified -- To view, visit http://gerrit.ovirt.org/18727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7e9f80b47a5b65924d7f78d7f658cf5db478ed1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rename methods to lowercase in storage commands
by amureini＠redhat.com 11 Sep '13

11 Sep '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rename methods to lowercase in storage commands ...................................................................... core: rename methods to lowercase in storage commands Change-Id: Ic90230c11cf11fe510c803c69ffa2bac0b0c2982 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DisconnectStorageServerVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DiscoverSendTargetsVDSCommand.java 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic90230c11cf11fe510c803c69ffa2bac0b0c2982 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix not closing statement resource leak
by amureini＠redhat.com 11 Sep '13

11 Sep '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix not closing statement resource leak ...................................................................... core: fix not closing statement resource leak Fix a resource leak caused by not closing a statement by adding a "try with resource" statement. It was possible because Statement implements AutoCloseable. Change-Id: Ibaeaa0c162bf9171a51e19ae95cf9689efd9fe04 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibaeaa0c162bf9171a51e19ae95cf9689efd9fe04 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: ExternalSchedulerDiscoveryResult map iter
by amureini＠redhat.com 11 Sep '13

11 Sep '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: ExternalSchedulerDiscoveryResult map iter ...................................................................... core: ExternalSchedulerDiscoveryResult map iter Replaced keySet() iteration with entrySet() iteration to improve performance. This patch fixes the WMI_WRONG_MAP_ITERATOR FindBugs warning on this class. Change-Id: I27d1a45bbc184bf467a283f0932a27db8c880831 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryResult.java 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27d1a45bbc184bf467a283f0932a27db8c880831 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: Replaced String check with string conversion
by bazulay＠redhat.com 11 Sep '13

11 Sep '13

Barak Azulay has submitted this change and it was merged. Change subject: Replaced String check with string conversion ...................................................................... Replaced String check with string conversion Currently the string_check is destroying the data when the system is not able to convert them properly. This is now fixed by allowing unicode strings as they are and an attempt of decoding input (non-unicode) strings based on the prefered locale encoding. If this will fail, the replacement of unknown characters are applied. In any case an unicode string is created. If the string is not convertible, the return value will be "????" as a replacement. This however is the last resort, to allow at least some level of data to go through. (e.g. when the application list contains one invalid data string currently it would cause the whole list NOT to be sent. Now it will be sent) Please also note that this commit will fix the failing unit tests. Change-Id: Ie277069cbfa39f9735a2b85b9e9da9c3fcfe5938 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/VirtIoChannel.py 1 file changed, 8 insertions(+), 9 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19053 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie277069cbfa39f9735a2b85b9e9da9c3fcfe5938 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: AddTemplate: Remove unused dest sd handling
by amureini＠redhat.com 11 Sep '13

11 Sep '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: AddTemplate: Remove unused dest sd handling ...................................................................... core: AddTemplate: Remove unused dest sd handling Change-Id I523814cd3c1f64c1ae40624ba50f239f2cebaed7 removed the setting of the destinationId in the constructor. This left that variable unused, so it can safely be removed. Change-Id: Id8440f9ece2fbe21c5bca6acde43d3a45ac2126a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8440f9ece2fbe21c5bca6acde43d3a45ac2126a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine : VdsUpdateRuntimeInfo updates the data of a specific...
by yzaslavs＠redhat.com 11 Sep '13

11 Sep '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : VdsUpdateRuntimeInfo updates the data of a specific VDS. ...................................................................... engine : VdsUpdateRuntimeInfo updates the data of a specific VDS. This change migrates all VM updates the VdsUpdateRuntimeInfo process does to batch updates - improving performance. Change-Id: Ie3e9735f4174ebabbe293d397d931aba72bbbd7b Signed-off-by: lzelkha(a)redhat.com <liran.zelkha(a)gmail.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/MassOperationsGenericDaoDbFacade.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterOptionDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterServerServiceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkStatisticsDaoDbFacadeImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 17 files changed, 233 insertions(+), 67 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16066 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie3e9735f4174ebabbe293d397d931aba72bbbd7b Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zelkha(a)gmail.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0