- Engine-commits - oVirt List Archives

Change in ovirt-engine[engine_3.2]: pki: upgrade: do not overwrite apache certificate and key
by oschreib＠redhat.com 11 Jun '13

11 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: upgrade: do not overwrite apache certificate and key ...................................................................... pki: upgrade: do not overwrite apache certificate and key Fix missing existence condition before duplicate the apache certificate and key. This will overwrite 3rd party certificate (if installed) at upgrade from 3.2 to more recent 3.2. Change-Id: I638e9193fdda7ca9a88313ba1890e9c1a76179af Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=969755 --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 8 insertions(+), 7 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I638e9193fdda7ca9a88313ba1890e9c1a76179af Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: pki: set ownership of apache key to root
by oschreib＠redhat.com 11 Jun '13

11 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: set ownership of apache key to root ...................................................................... pki: set ownership of apache key to root Apache reads the keys before dropping privileges, correct permissions are read by root. Change-Id: I7f3ab38f6e3f4e03244878877d4bab0fd72bc3c4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f3ab38f6e3f4e03244878877d4bab0fd72bc3c4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: support umask 0077
by oschreib＠redhat.com 11 Jun '13

11 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: support umask 0077 ...................................................................... pki: support umask 0077 Change-Id: I5938b0e75777a4d56674b8e55b8694e2d385e0d1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/etc/pki/CreateCA.sh M packaging/etc/pki/SignReq.sh M packaging/etc/pki/installCA.sh 3 files changed, 7 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5938b0e75777a4d56674b8e55b8694e2d385e0d1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: pki: always reset ca db owner after signature
by oschreib＠redhat.com 11 Jun '13

11 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: always reset ca db owner after signature ...................................................................... pki: always reset ca db owner after signature openssl always put the running user as owner, we need to have ovirt. Change-Id: I0cf23c849d086da62e4896a0146205e528b603f1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/etc/pki/CreateCA.sh M packaging/etc/pki/SignReq.sh 2 files changed, 13 insertions(+), 4 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cf23c849d086da62e4896a0146205e528b603f1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: pki: subject is actually optional
by oschreib＠redhat.com 11 Jun '13

11 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: subject is actually optional ...................................................................... pki: subject is actually optional Change-Id: Idf0935e62af682090e952d1695ca3f41bddcbbbb Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/etc/pki/SignReq.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf0935e62af682090e952d1695ca3f41bddcbbbb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: pki: exit SignReq with error if invalid usage
by oschreib＠redhat.com 11 Jun '13

11 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: exit SignReq with error if invalid usage ...................................................................... pki: exit SignReq with error if invalid usage Change-Id: Ic19dadf046fd7c20ba36759fbc1d3c7421f239b6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/etc/pki/SignReq.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic19dadf046fd7c20ba36759fbc1d3c7421f239b6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: setup: support older psycopg2
by oschreib＠redhat.com 11 Jun '13

11 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: support older psycopg2 ...................................................................... packaging: setup: support older psycopg2 rhel and centos have version 2.0.14 with autocommit unsupported. also allow autocommit in a middle of transaction for specific statement. Change-Id: Icf94f83d3ebf5d121ef7bff3552bccfa09a99ec1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/database.py 1 file changed, 29 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf94f83d3ebf5d121ef7bff3552bccfa09a99ec1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: pki: remove database config upgrade
by oschreib＠redhat.com 11 Jun '13

11 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: remove database config upgrade ...................................................................... pki: remove database config upgrade BACKGROUND There is a bug in engine-config that existed since beginning of time, it does not take the CABaseDirectory into account. However, both the setup and the upgrade set full path for all pki artifacts, this is why this bug has been never discovered. DESCRIPTION The database upgrade script puts two values per default, these are relative: select fn_db_update_config_value('keystoreUrl','keys/engine.p12','general'); select fn_db_update_config_value('TruststoreUrl','.truststore','general'); When system is upgraded from 3.1, after database upgrade the engine-upgrade script will convert keys to PKCS#12 format, and overwrite database settings. However, if you upgrade from 3.2 to 3.2, then the engine-upgrade script does not overwrite the setting, leaving relative paths. WORKAROUND Modify keystoreUrl and truststoreUrl within database to absolute paths. Change-Id: Iec8bb367033b5ec03b5b97bd183fc5683523ccd9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=968906 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec8bb367033b5ec03b5b97bd183fc5683523ccd9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fix unit tests that were broken by multiple gateways
by alkaplan＠redhat.com 11 Jun '13

11 Jun '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine: Fix unit tests that were broken by multiple gateways ...................................................................... engine: Fix unit tests that were broken by multiple gateways Multiple gateways feature broke two unit test. Commit 663243e46549d3796fd50fa362520e0e20cf45b5 fixed the broken tests. This patch adds some improvements to the fixes were done. 1. In SetupNetworkHelper gateway validation now checks the ConfigValues.MultipleGatewaysSupported- a mock was added to fix the test. 2. Gateway validation was removed from NetworkInterfaceValidator- fix the test to emphasisthere are case we support gateway for non management network. Change-Id: I1d453ea1efe736dd16dea9b793d784bee4225af8 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java 2 files changed, 29 insertions(+), 7 deletions(-) Approvals: Alona Kaplan: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d453ea1efe736dd16dea9b793d784bee4225af8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: add gateway to edit network from setup networks di...
by alkaplan＠redhat.com 10 Jun '13

10 Jun '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: add gateway to edit network from setup networks dialog ...................................................................... webadmin: add gateway to edit network from setup networks dialog When editing an IP configuration, we need to enable the gateway field for all networks, not only ovirtmgmt. If the user chose static IP, then the gateway field should be added and be editable. If DHCP was chosen then the gateway field should be visible and display the gateway configured via DHCP. Change-Id: Ie87f8fa3827b216483b553a8e36011382930585c Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java 11 files changed, 44 insertions(+), 13 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie87f8fa3827b216483b553a8e36011382930585c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0