- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: resatpi: Wrong Links In Group (#967547)
by mpastern＠redhat.com 10 Jun '13

10 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: resatpi: Wrong Links In Group (#967547) ...................................................................... resatpi: Wrong Links In Group (#967547) Links to tags, permissions, roles within Group included domain: wrong: .../api/domain/xxx/group/yyy/tags (404 not found) after fix: .../api/groups/yyy/tags (good) Bug-Url: http://bugzilla.redhat.com/967547 Change-Id: I1106470e0a6dbbf804f949f2d0959ef914717bde Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceBase.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15515 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1106470e0a6dbbf804f949f2d0959ef914717bde Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Hide checkbox in reinit dc with no SDs
by tnisan＠redhat.com 10 Jun '13

10 Jun '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Hide checkbox in reinit dc with no SDs ...................................................................... webadmin: Hide checkbox in reinit dc with no SDs Hide "approve operation" checkbox in reinitialize Data Center dialog when there are no storage domains available to select for reinitialize. In that case there is no operation to be performed, thus the checkbox is meaningless and misleading. Change-Id: I9f02e55411a9a2a9ad873efb671306f8bc0f8ba5 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f02e55411a9a2a9ad873efb671306f8bc0f8ba5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: tools: expose GlusterRefreshRateHooks in engine-config
by kmayilsa＠redhat.com 10 Jun '13

10 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: tools: expose GlusterRefreshRateHooks in engine-config ...................................................................... tools: expose GlusterRefreshRateHooks in engine-config Exposing Gluster hooks refresh rate in engine-config tool Change-Id: Ie5911076395a78a1e498eb371e7c24fb6de29e49 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5911076395a78a1e498eb371e7c24fb6de29e49 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Changed xml key for hook mimetype
by kmayilsa＠redhat.com 10 Jun '13

10 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Changed xml key for hook mimetype ...................................................................... gluster: Changed xml key for hook mimetype Changed xml key from type to mimetype to get hook's content type based on vdsm change http://gerrit.ovirt.org/#/c/15331/ Change-Id: I46a71c22907ed8eb33b7fccbb35b2f414965b16e Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHooksListReturnForXmlRpc.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/15407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46a71c22907ed8eb33b7fccbb35b2f414965b16e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: update spec deps
by mpastern＠redhat.com 10 Jun '13

10 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: update spec deps ...................................................................... sdk: update spec deps Change-Id: I99c47d884dfa58a85d11aa00826df94d5686eb03 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99c47d884dfa58a85d11aa00826df94d5686eb03 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Bll command to refresh gluster hooks in engine
by kmayilsa＠redhat.com 10 Jun '13

10 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Bll command to refresh gluster hooks in engine ...................................................................... gluster: Bll command to refresh gluster hooks in engine Used to manually trigger a sync of gluster hooks in gluster cluster with values stored in engine database. This is needed because the default sync interval is set to 1 hour as hooks are not expected to change frequently. If admin wishes to see updated status, can trigger refresh of hooks from UI. Change-Id: I4713ca800432aee302f913d0c8aa06a35a5b2db2 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterHooksCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterHooksCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterClusterParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 14 files changed, 253 insertions(+), 23 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/15312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4713ca800432aee302f913d0c8aa06a35a5b2db2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-guest-agent[master]: agent: Do not install Windows files on linux
by bazulay＠redhat.com 10 Jun '13

10 Jun '13

Barak Azulay has submitted this change and it was merged. Change subject: agent: Do not install Windows files on linux ...................................................................... agent: Do not install Windows files on linux Change-Id: Ic7cdb66b2b154901541010135ddf118893182ec9 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M ovirt-guest-agent/Makefile.am 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7cdb66b2b154901541010135ddf118893182ec9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: class name is the same as it super class
by shavivi＠redhat.com 10 Jun '13

10 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: class name is the same as it super class ...................................................................... findbugs: ignore: class name is the same as it super class findbugs complains that we are using the same class name as it super-class currently PopupPanel and MenuBar are deeply coded in GWT. we will ignore findbugs warning for now findbugs reason: Nm: Class names shouldn't shadow simple name of superclass (NM_SAME_SIMPLE_NAME_AS_SUPERCLASS) Change-Id: I17c5a70a75f41295cb2b68a1c86babadf1188974 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/exclude-filters.xml 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17c5a70a75f41295cb2b68a1c86babadf1188974 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: some params on make template ignored
by tjelinek＠redhat.com 10 Jun '13

10 Jun '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: some params on make template ignored ...................................................................... userportal,webadmin: some params on make template ignored The make template ignored some parameters. - In UserPortal the usb policy has been taken from an incorrect place - In both UserPortal and WebAdmin the Boot Options -> Attach CD was ignored - In engine the allow console reconnect and iso path has been ignored in new template Change-Id: Ibf4c0610688ae773e86190d4bd2d73cd7c74b1e6 bug-url: https://bugzilla.redhat.com/952712 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 5 files changed, 26 insertions(+), 18 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf4c0610688ae773e86190d4bd2d73cd7c74b1e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core : update of bootable disk
by amureini＠redhat.com 10 Jun '13

10 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core : update of bootable disk ...................................................................... core : update of bootable disk when updating a bootable disk, a CDA message was always shown because of a check that the vms that the disk is attached to doesn't contain boot disk - this disk shouldn't be done if the disk was already bootable before the update operation. Change-Id: Ibc0e96274e408306d2444f8fa01a45daf38724f7 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc0e96274e408306d2444f8fa01a45daf38724f7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0