- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: Updated the order for db config updates
by juan.hernandez＠redhat.com 03 Jun '13

03 Jun '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated the order for db config updates ...................................................................... packaging: Updated the order for db config updates This patch reverses the order between "generateConf" and "updateConf" calls so that configuration generation precedes update. Change-Id: Id4eb89f624df46fb2aa372e30a4e9ad52b30f809 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4eb89f624df46fb2aa372e30a4e9ad52b30f809 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: config: added backward compatibilty
by sbonazzo＠redhat.com 03 Jun '13

03 Jun '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: config: added backward compatibilty ...................................................................... config: added backward compatibilty Added backward compatibility supporting upgrade from 3.1 version which used the keyword rhevm instead of engine. The old config files will be backed up during the upgrade. cherry picked with modifications from 5872ba1398647e0d5f2b3c471d198c54b8ef8d9c Change-Id: I781493d9a224e412edbf1816579718de39ce0f54 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 40 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Kiril Nesenko: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I781493d9a224e412edbf1816579718de39ce0f54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove empty CDA
by mlipchuk＠redhat.com 03 Jun '13

03 Jun '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove empty CDA ...................................................................... core: Remove empty CDA 1. Move type initialization from the CDA to setActionMessageParameters method. 2. After moving the type, CDA only calls super, so removing it from the abstract class. Change-Id: I2f273f19ce882fbcd5483863d0755143d7b77a88 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StoragePoolManagementCommandBase.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f273f19ce882fbcd5483863d0755143d7b77a88 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove call to super CDA(2)
by mlipchuk＠redhat.com 03 Jun '13

03 Jun '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove call to super CDA(2) ...................................................................... core: Remove call to super CDA(2) 1) Remove call to super CDA after it was removed from StoragePoolManagementCommandBase in the previous patch. 2) moved initialization for action type from the CDA to setActionMessageParameters method. Change-Id: I7b777f9f7c5778fd696a04350381f4587022b469 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b777f9f7c5778fd696a04350381f4587022b469 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove call to super CDA
by mlipchuk＠redhat.com 03 Jun '13

03 Jun '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove call to super CDA ...................................................................... core: Remove call to super CDA 1) Remove call to super CDA after it was removed from StoragePoolManagementCommandBase in the previous patch. 2) Moved initialization action type from the CDA to setActionMessageParameters. Change-Id: I33046daed409f8a0d7ad1680191ba7824087402a Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33046daed409f8a0d7ad1680191ba7824087402a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change type and action when attaching a domain
by mlipchuk＠redhat.com 03 Jun '13

03 Jun '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Change type and action when attaching a domain ...................................................................... core: Change type and action when attaching a domain Replacing "Cannot edit Repository" with "Cannot attach domain", when user try to attach a domain to pool. Change-Id: Icab303deab183edebda3b754e0d19e44c07b2515 Bug-Url: https://bugzilla.redhat.com/951905 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icab303deab183edebda3b754e0d19e44c07b2515 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Power Management failed if no proxy ...
by emesika＠redhat.com 03 Jun '13

03 Jun '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Power Management failed if no proxy ... ...................................................................... core: Power Management failed if no proxy ... core: Power Management failed if no proxy preferences is defined for the host Power Management failed if no pm_proxy preferences is defined for the host. The pm_proxy_preferences is a per-host field in vds_static that defines how to look for a proxy host. (cluster then DC or vice versa) In case that pm_proxy preference is not defined , it should be taken from the FenceProxyDefaultPreferences configuration value which is defaulted to "cluster,dc" However, the code that checks for existence of pm_proxy preferences checks for null only and if it is an empty string , it is used The error on the log is : 2013-06-02 13:04:25,013 ERROR [org.ovirt.engine.core.bll.FenceExecutor] Illegal value in PM Proxy Preferences string , skipped Change-Id: Id1b96b115dc586e6ebbdacd44e0a034e91609841 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=969778 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1b96b115dc586e6ebbdacd44e0a034e91609841 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-host-deploy[master]: core: modify copyright of base po
by Alon Bar-Lev 03 Jun '13

03 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: modify copyright of base po ...................................................................... core: modify copyright of base po Change-Id: I07d755cd498084d9ec1f8d48c2e4297ded8d2ee2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M po/Makevars 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07d755cd498084d9ec1f8d48c2e4297ded8d2ee2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: core: modify copyright of base po
by Alon Bar-Lev 03 Jun '13

03 Jun '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: modify copyright of base po ...................................................................... core: modify copyright of base po Change-Id: I5b2d97d18b2fac3a15920da1bb5f6fc547f336aa Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M po/Makevars 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b2d97d18b2fac3a15920da1bb5f6fc547f336aa Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix quota count for Template with multiple SD
by dfediuck＠redhat.com 02 Jun '13

02 Jun '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix quota count for Template with multiple SD ...................................................................... core: Fix quota count for Template with multiple SD When deleting a template which have a multiple domain disk, the disk size was only released from the quota once. RemoveVmTemplateCommand was changed to support multiple storage domain disks when removing templates. Change-Id: Id2f5051218405753dc86b997aaa47f488f159350 Bug-Url: https://bugzilla.redhat.com/963587 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2f5051218405753dc86b997aaa47f488f159350 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0