- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: implicit quota defs in Common.gwt.xml
by amureini＠redhat.com 02 Jun '13

02 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: implicit quota defs in Common.gwt.xml ...................................................................... webadmin: implicit quota defs in Common.gwt.xml Removed the explicit entries for quota queries and actions, as they are covered by "common/queries/*.java" and "common/action/*.java", respectively. Change-Id: I6a6a9c62fddb9a281b9ffd0d36368d56b14b0cbc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a6a9c62fddb9a281b9ffd0d36368d56b14b0cbc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused classes from uioverrides
by amureini＠redhat.com 02 Jun '13

02 Jun '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused classes from uioverrides ...................................................................... core: Remove unused classes from uioverrides Removed async_tasks, Encoding and StringBuilderCompat from uioverrides, as they are no longer required, and just slow down the build. Change-Id: Id3c9c0cff51f39f47f5b30bd1668b36b8e1ad812 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/common/businessentities/async_tasks.java D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/Encoding.java D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/StringBuilderCompat.java 3 files changed, 0 insertions(+), 149 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3c9c0cff51f39f47f5b30bd1668b36b8e1ad812 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Disable Get Groups For Non-Admin User
by mpastern＠redhat.com 02 Jun '13

02 Jun '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Disable Get Groups For Non-Admin User ...................................................................... restapi: Disable Get Groups For Non-Admin User Getting Groups for non-admin user is wrongly implemented. It currently returns - instead of all groups which the user is authorized to see - exactly one User entity, (the user himself). Needless to say this is very far from the intended result. Until new implementation will be avaliable, I am removing this wrong implementation. For now the outcome will now be: user will fail due to insufficient permission. Change-Id: I932a197271ccfa52418276ec4ddfb4c5db95e0a0 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java 1 file changed, 1 insertion(+), 8 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14894 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I932a197271ccfa52418276ec4ddfb4c5db95e0a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding disk_id as a secondary order-by column
by derez＠redhat.com 02 Jun '13

02 Jun '13

Daniel Erez has submitted this change and it was merged. Change subject: core: adding disk_id as a secondary order-by column ...................................................................... core: adding disk_id as a secondary order-by column Disks search default order by column is disk_alias. Since disk alias is not unique, the search query might return disks in a different order when they are manipulated (e.g. status changes). Hence, in order to prevent unpredicted order, added disk_id as a secondary order-by column. Change-Id: I7e62b44cab4065c41dc7273fc527415b9fba002f Bug-Url: https://bugzilla.redhat.com/953154 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e62b44cab4065c41dc7273fc527415b9fba002f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Reset statusconflict flag on enable/disable
by kmayilsa＠redhat.com 02 Jun '13

02 Jun '13

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Reset statusconflict flag on enable/disable ...................................................................... gluster: Reset statusconflict flag on enable/disable Reset the status conflict flag on enable/disable of gluster hooks. After resetting of flag, if conflict status is 0, remove the entries of conflicting server hooks as conflicts have been resolved Removed code that added entries to server hooks as we now only maintain conflicting server hook entries Refactored the command class to use GlusterHookParameters class. Change-Id: I9913900175e0f5be33bb1ec45b882e770a09fde4 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DisableGlusterHookCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DisableGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterHookStatusChangeParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGlusterHookListModel.java 9 files changed, 50 insertions(+), 137 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9913900175e0f5be33bb1ec45b882e770a09fde4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: fix issue with conflict of latest two independent...
by oschreib＠redhat.com 02 Jun '13

02 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: fix issue with conflict of latest two independent merges ...................................................................... packaging: fix issue with conflict of latest two independent merges Change-Id: I1e297aaba1847b5623461486255295ae334f53ff Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine.xml.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Looks good to me, approved Ohad Basan: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e297aaba1847b5623461486255295ae334f53ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: upgrade: do not overwrite apache certificate and key
by oschreib＠redhat.com 02 Jun '13

02 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: upgrade: do not overwrite apache certificate and key ...................................................................... pki: upgrade: do not overwrite apache certificate and key Fix missing existence condition before duplicate the apache certificate and key. This will overwrite 3rd party certificate (if installed) at upgrade from 3.2 to more recent 3.2. Change-Id: I638e9193fdda7ca9a88313ba1890e9c1a76179af Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=969755 --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 8 insertions(+), 7 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I638e9193fdda7ca9a88313ba1890e9c1a76179af Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: toString return null
by shavivi＠redhat.com 02 Jun '13

02 Jun '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: toString return null ...................................................................... findbugs: toString return null its a bad practice and may cause to runtime exception when returning null in toString() findbugs reason NP: toString method may return null (NP_TOSTRING_COULD_RETURN_NULL) Change-Id: Ib7385775b938054a5fd713c458706271b20573ad Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Uri.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UriAuthority.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/UriTest.java 4 files changed, 8 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7385775b938054a5fd713c458706271b20573ad Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: support lexical parsing of configuration
by oschreib＠redhat.com 02 Jun '13

02 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: support lexical parsing of configuration ...................................................................... packaging: setup: support lexical parsing of configuration the configuration file format is shell like format, it should be parsed by shell, python and java. current implementation does not parse the value using lexical method, so escape of characters is impossible, and there may be other side effects like comments that should remain within quotes. new implementation uses primitive but sufficient parsing of literals. sync implementation between java and python and sync implementation of service parser to match this of setup. Change-Id: I945c8ddbe5de512ab330153c27802bb71964b76f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/LocalConfigTest.java A backend/manager/modules/utils/src/test/resources/localconfig.conf A backend/manager/modules/utils/src/test/resources/localconfig.conf.ref M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-upgrade.py M packaging/services/ovirt-engine-logging.properties.in M packaging/services/ovirt-engine-notifier.py M packaging/services/ovirt-engine.py M packaging/services/ovirt-engine.xml.in M packaging/services/ovirt-websocket-proxy.py M packaging/services/service.py M packaging/setup/ovirt_engine_setup/util.py M packaging/setup/plugins/ovirt-engine-setup/config/ca.py M packaging/setup/plugins/ovirt-engine-setup/config/database.py 15 files changed, 417 insertions(+), 260 deletions(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I945c8ddbe5de512ab330153c27802bb71964b76f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: remove obsolete and dead code
by oschreib＠redhat.com 02 Jun '13

02 Jun '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: remove obsolete and dead code ...................................................................... packaging: setup: remove obsolete and dead code Change-Id: I9e336e7701d9ef70e5aa41455197ec499eaf8f36 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/ca.py 1 file changed, 0 insertions(+), 58 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e336e7701d9ef70e5aa41455197ec499eaf8f36 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0