- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Add new parameter class for CollectNetworkData
by masayag＠redhat.com 30 May '13

30 May '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Add new parameter class for CollectNetworkData ...................................................................... engine: Add new parameter class for CollectNetworkData The VDS command CollectVdsNetworkData will require a new parameter class in order to provide a new parameter to the command: skipMgmtNetwork which is designed to specify if a management network should be considered while checking host networks validity. Change-Id: If6986cc378e7d36213da9cb200e8a6098b0d604f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AddBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/AttachNetworkToVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RemoveBondCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CollectVdsNetworkDataVDSCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java 8 files changed, 42 insertions(+), 16 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6986cc378e7d36213da9cb200e8a6098b0d604f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Allow engine to configure management network
by masayag＠redhat.com 30 May '13

30 May '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Allow engine to configure management network ...................................................................... engine: Allow engine to configure management network The patch eliminates* the need of ovirt-host-deploy to create the management network on top of the installed host. The management network will be created as the last step of the installation process, by the logical network definition in the data-center. Since the network creation relies on the setupNetworks, no further action will be taken for non-supported cluster versions. * ovirt-nodes are the exceptional in this process and for them (regardless their version), the ovirt-host-deploy will create the management bridge (regardless the logical network definition). If the network is defined otherwise, the admin will have to use the 'Sync Network' option via the setupNetworks dialog to enable it. Once ovirt-node will not create the br* bridges, the engine will be able to use the same logic for configuring the management network on the node. Change-Id: Iaf82e10481e595d690e7ce894283b4ed5b9b3269 Bug-Url: https://bugzilla.redhat.com/891056 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VersionSupport.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 6 files changed, 415 insertions(+), 51 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf82e10481e595d690e7ce894283b4ed5b9b3269 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Martin Pavlik <xpavli44(a)gmail.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Refresh stops session timeout.
by tjelinek＠redhat.com 30 May '13

30 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: Refresh stops session timeout. ...................................................................... userportal: Refresh stops session timeout. - Fixed issue where the automatic refresh of VM and templates would reset the session timeout due to not passing in the proper parameters. Change-Id: I499dfc3cd2ce4385bb81a62133124accfbfebfbd Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalTemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmBasicDiskListModel.java 5 files changed, 15 insertions(+), 10 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I499dfc3cd2ce4385bb81a62133124accfbfebfbd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "engine: Fix for BZ#967890 - enhance logging of JndiA...
by yzaslavs＠redhat.com 30 May '13

30 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Revert "engine: Fix for BZ#967890 - enhance logging of JndiAction level in dEBUG mode" ...................................................................... Revert "engine: Fix for BZ#967890 - enhance logging of JndiAction level in dEBUG mode" This reverts commit 6cdaa01d5d5e0c4904f6079f9987669cb0784354 A compiliation problem --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8ac1e03f7272aa658427db6bdaa521cb6b16e69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: ignore unused host variable in parse dns r...
by shavivi＠redhat.com 30 May '13

30 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: ignore unused host variable in parse dns record ...................................................................... findbugs: ignore: ignore unused host variable in parse dns record findbugs complains that host variable is never used its true but this method parse host and port and we may need the use of host address in the future. findbugs reason: DLS: Dead store to local variable (DLS_DEAD_LOCAL_STORE) Change-Id: Iab73f4f2b502af08e8485e00a20c974d1a472433 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/exclude-filters.xml 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab73f4f2b502af08e8485e00a20c974d1a472433 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, webadmin: Renamed Repository to Data Center
by yzaslavs＠redhat.com 30 May '13

30 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core,webadmin: Renamed Repository to Data Center ...................................................................... core,webadmin: Renamed Repository to Data Center Renamed Repository to Data Center in english texts. Change-Id: Ie454187c34a11699040d493ac006c4a736be9cf5 Bug-Url: https://bugzilla.redhat.com/950659 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie454187c34a11699040d493ac006c4a736be9cf5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fix for BZ#967890 - enhance logging of JndiAction le...
by yzaslavs＠redhat.com 30 May '13

30 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: Fix for BZ#967890 - enhance logging of JndiAction level in dEBUG mode ...................................................................... engine: Fix for BZ#967890 - enhance logging of JndiAction level in dEBUG mode Enhanced logging possibility for JndiAction class in debug mode. This enables user to view more detailed info on what query path, URI and user was used to perform the authentication and ticket creation. Change-Id: Ia6c2504ba7d6f77492862e6ccf6c0770fdab0fd7 Bug-Url: https://bugzilla.redhat.com/967890 Signed-off-by: Tomas Dosek <tdosek(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15139 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6c2504ba7d6f77492862e6ccf6c0770fdab0fd7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomáš Došek <tdosek(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Tomáš Došek <tdosek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : Cookies are being set even when not using persiste...
by mpastern＠redhat.com 29 May '13

29 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Cookies are being set even when not using persistent authentication ...................................................................... restapi : Cookies are being set even when not using persistent authentication API sets jsession id when not using persistent authentication. This patch creates a session only when persistent authentication header is passed in the request. Change-Id: Ieb004fefbd9a276efacb2ce6fa8b7a48a9516c6e Bug-Url: https://bugzilla.redhat.com/962730 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb004fefbd9a276efacb2ce6fa8b7a48a9516c6e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: SEAT compensate - prevent IndexOutOfBounds
by derez＠redhat.com 29 May '13

29 May '13

Daniel Erez has submitted this change and it was merged. Change subject: core: SEAT compensate - prevent IndexOutOfBounds ...................................................................... core: SEAT compensate - prevent IndexOutOfBounds CommandBase -> hasTaskHandlers: * compensate: setExecutionReason to ROLLBACK_FLOW for ensuring internalEndWithFailure flow as in revertPreviousHandlers. * internalEndWithFailure: verifying executionIndex >= 0 to prevent index underflow. * revertPreviousHandlers: when executionIndex < 0 set command as succeeded (to ensure tasks clean up). Change-Id: I7af9f3ab3bfce91b114d82145957909ba1ee7819 Bug-Url: https://bugzilla.redhat.com/966153 Bug-Url: https://bugzilla.redhat.com/966618 Bug-Url: https://bugzilla.redhat.com/965676 Bug-Url: https://bugzilla.redhat.com/962497 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 13 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7af9f3ab3bfce91b114d82145957909ba1ee7819 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: fix localstate plugin directories
by oschreib＠redhat.com 29 May '13

29 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: fix localstate plugin directories ...................................................................... packaging: setup: fix localstate plugin directories Change-Id: I9ce025ec2d975fb41ee53e77740917d8a0c945fd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/config.py.in M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/system/localstate.py 3 files changed, 10 insertions(+), 15 deletions(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ce025ec2d975fb41ee53e77740917d8a0c945fd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0