- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: findbugs: ignore: findbugs complain of unused field in class...
by shavivi＠redhat.com 30 May '13

30 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: findbugs complain of unused field in class. ...................................................................... findbugs: ignore: findbugs complain of unused field in class. This is a GWT classes and use to generate code findbugs reason: UuF: Unused field (UUF_UNUSED_FIELD) Change-Id: I536a80c26a03bb263dc6a2e667cfa762fdf29bd5 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/exclude-filters.xml M frontend/webadmin/modules/gwt-common/pom.xml A frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/exclude-filters.xml 5 files changed, 346 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15204 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I536a80c26a03bb263dc6a2e667cfa762fdf29bd5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: remove unused fields
by shavivi＠redhat.com 30 May '13

30 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: remove unused fields ...................................................................... findbugs: remove unused fields findbugs reason: UuF: Unused field (UUF_UNUSED_FIELD) Change-Id: I2a0826a3dbe860b7c1fcbbdd4358f64e528304c7 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeOptionsInfoQueryTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/test/util/TestHelper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 5 files changed, 0 insertions(+), 11 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a0826a3dbe860b7c1fcbbdd4358f64e528304c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: config: added backward compatibilty
by sbonazzo＠redhat.com 30 May '13

30 May '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: config: added backward compatibilty ...................................................................... config: added backward compatibilty Added backward compatibility supporting upgrade from 3.1 version which used the keyword rhevm instead of engine. The old config files will be backed up during the upgrade. Change-Id: I781493d9a224e412edbf1816579718de39ce0f54 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 40 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Alex Lourie: Looks good to me, but someone else must approve Yedidyah Bar David: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I781493d9a224e412edbf1816579718de39ce0f54 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Integrate noVNC support
by tjelinek＠redhat.com 30 May '13

30 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Integrate noVNC support ...................................................................... engine: Integrate noVNC support This patch integrates noVNC support in the engine. Firstly it adds noVNC HTML5 client into the engine to be served by jBoss. Secondly it adds websockify script customized for oVirt. In production mode, this script must be able to verify signatures issued by the engine (for validating vnc connection data). The behavior of VNC console invocation now depends on configuration in db - option noVncProxy. The possible values are: - 'Off' - feature is turned off - default. - 'Host[:port]' - feature is on - engine assumes the proxy is deployed on each host. port is optional, default is 6080. - 'Engine[:port]' - feature is on - engine assumes the proxy is deployed on itself. port is optional, default is 6080. - host_fqdn_or_ip:port - feature is on, engine then assumes that the proxy is deployed on the machine specified by host_fqdn_or_ip:port. Things changed against last patchset: - switched to plain ws protocol (only until the certificate creation is integrated!) - enabled logs for websockify Things to be done: - generating certificate for tls communication between proxy and client - testing Change-Id: I44e9870b88537360a1886e89c08f18865eae2ef0 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=838468 --- M Makefile M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SignStringQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SignStringParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml A backend/manager/modules/root/src/main/webapp/ovirt-engine-novnc-main.html A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/TicketUtils.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractVnc.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/VncNativeImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/INoVnc.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IVnc.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IVncNative.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java M ovirt-engine.spec.in M packaging/conf/engine.conf.defaults.in M packaging/conf/ovirt-engine-proxy.conf.in A packaging/conf/ovirt-websocket-proxy.conf.defaults A packaging/conf/ovirt-websocket-proxy.conf.defaults.in M packaging/etc/engine-config/engine-config.properties M packaging/services/config.py.in A packaging/services/ovirt-websocket-proxy.py A packaging/services/ovirt-websocket-proxy.systemd.in A packaging/services/ovirt-websocket-proxy.sysv.in 29 files changed, 1,086 insertions(+), 20 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/13931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I44e9870b88537360a1886e89c08f18865eae2ef0 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Correct timezone default in New/Edit VM dialog
by tjelinek＠redhat.com 30 May '13

30 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Correct timezone default in New/Edit VM dialog ...................................................................... webadmin: Correct timezone default in New/Edit VM dialog Correct setting of default timezone for windows type OSs with vdc_option DefaultWindowsTimeZone. (renamed from DefaultTimeZone) Also added new vdc_option DefaultGeneralTimeZone for default value of timezone for general OSs (non-windows) using standard java timezone format. Changed renderer to render the null field representing default engine timezone with descriptive string to user. Refactored majority of timezone-handling code from VmModelBehaviorBase to newly created TimeZoneModel that caches all timezones and defaults, resulting in improved performance of the dialog. cleanup: All references to TimeZoneInfo were replaced by usage of DefaultWindowsTimeZone (or DefaultGeneralTimeZone, depending on OS type) and the class itself was removed. Removed the class TimeZoneMapping and its usage in REST api mappers since the mapping was incomplete (there is no one-to-one mapping between Windows and Linux/Java timezones, you can only have correct windows->java translation) and even the usage of it was incorrect because it was converting the timezones to windows format regardless of the OS-type. Change-Id: Iaccb31f5634c16583004a79b9b47b83ff994088a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=873795 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDefualtTimeZoneQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetTimeZonesQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDefualtTimeZoneQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetTimeZonesQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/TimeZoneQueryParams.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/TimeZoneInfo.java D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/TimeZoneMapping.java D backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/TimeZoneMappingTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TimeZoneModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 32 files changed, 306 insertions(+), 437 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Martin Beták: Verified -- To view, visit http://gerrit.ovirt.org/14248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaccb31f5634c16583004a79b9b47b83ff994088a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ConnectAllHostsToLun shouldn't run within transaction
by amureini＠redhat.com 30 May '13

30 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: ConnectAllHostsToLun shouldn't run within transaction ...................................................................... core: ConnectAllHostsToLun shouldn't run within transaction The following command shouldn't run within transaction, it performs vdsm operations only and no db updates - Running it within transaction can cause to timeout and leave unneeded connections. Change-Id: I6d3bcbc8a61102439fdf732f7c969b1baf8ad8bf Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d3bcbc8a61102439fdf732f7c969b1baf8ad8bf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: unsynchronized initialization of non-volatile stat...
by shavivi＠redhat.com 30 May '13

30 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: unsynchronized initialization of non-volatile static field ...................................................................... findbugs: unsynchronized initialization of non-volatile static field This method contains an unsynchronized lazy initialization of a non-volatile static field. Because the compiler or processor may reorder instructions we need to make the field volatile findbugs reason: LI: Incorrect lazy initialization of static field (LI_LAZY_INIT_STATIC) Change-Id: I1e0f8e380edd20d9a9ae3f99dfb82df5736786f9 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/TypeConversionHelper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e0f8e380edd20d9a9ae3f99dfb82df5736786f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: ignore: absolute pathname in test case
by shavivi＠redhat.com 30 May '13

30 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: ignore: absolute pathname in test case ...................................................................... findbugs: ignore: absolute pathname in test case findbugs complain that the code is using absolute path in File object, the FileServletTest is using it to test input path findbugs reason: DMI: Code contains a hard coded reference to an absolute pathname (DMI_HARDCODED_ABSOLUTE_FILENAME) Change-Id: Ic14b42211fbae45408f78e1efeb148bd1b0dba45 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- A backend/manager/modules/root/exclude-filters.xml M backend/manager/modules/root/pom.xml 2 files changed, 26 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic14b42211fbae45408f78e1efeb148bd1b0dba45 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Command to update gluster hook on servers
by ofrenkel＠redhat.com 30 May '13

30 May '13

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: Command to update gluster hook on servers ...................................................................... gluster: Command to update gluster hook on servers This patch adds a command to update hook content on servers where the content's different. Either the engine content or content from a server is used - depending on parameters - to update content on servers. If content from server is used, the engine's copy of hook content is updated as well. Also, refactored the GlusterHookParameters class and GlusterHookCommandBase class Change-Id: Ibccccbbed1e07d471dc472c41843f46767b9e083 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DisableGlusterHookCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DisableGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterHookManageParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterHookParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterHookStatusChangeParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterHookEntity.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGlusterHookListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 25 files changed, 569 insertions(+), 57 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibccccbbed1e07d471dc472c41843f46767b9e083 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove mgmt network setup from host activation
by masayag＠redhat.com 30 May '13

30 May '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove mgmt network setup from host activation ...................................................................... engine: Remove mgmt network setup from host activation The management network setup will be removed from the host activation flow. Configuring management network will be executed from host installation flow. Change-Id: If642cd5d52571ff29d50569c07de8ebd1bf3018c Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 3 files changed, 5 insertions(+), 119 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If642cd5d52571ff29d50569c07de8ebd1bf3018c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0