- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: handle failed import of template
by amureini＠redhat.com 22 May '13

22 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: handle failed import of template ...................................................................... core: handle failed import of template When failing during the import of a template, the engine should attempt to delete the created images and not just remove it from the db to avoid storage leak and possible CDA message/inconsistent data during another try to import the template with same image guids. If any images are failed to be removed, they would remain with ILLEGAL status - an attempt to import again with the same ID will result in CDA message. Change-Id: If90414b6c50d922b510a10e20e0774bdbec9c05b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908327 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TestHelperImportVmTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java 8 files changed, 99 insertions(+), 75 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If90414b6c50d922b510a10e20e0774bdbec9c05b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: increase ram in blank template
by lhornyak＠redhat.com 22 May '13

22 May '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: increase ram in blank template ...................................................................... engine: increase ram in blank template This patch increases the ram ro 1024 MB in existing installations in the blank template. Change-Id: I49d8f5c9b5dc23c35b497618c498e8c049c82b1b Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_03_0160_increase_guest_ram.sql 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14982 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I49d8f5c9b5dc23c35b497618c498e8c049c82b1b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Small changes in spice descriptor generating
by tjelinek＠redhat.com 22 May '13

22 May '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Small changes in spice descriptor generating ...................................................................... frontend: Small changes in spice descriptor generating 1, Adding delete-this-file option in spice descriptor to ensure deletion after reading. 2, tls-ciphers row will not be generated when the ciphersuite is null. Change-Id: I7ed05adcd3fa8c6f93ebe6e77a02710a291f6159 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=965179 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/14830 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ed05adcd3fa8c6f93ebe6e77a02710a291f6159 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: fix otopi implementation version locking h...
by oschreib＠redhat.com 22 May '13

22 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: fix otopi implementation version locking handling ...................................................................... packaging: setup: fix otopi implementation version locking handling engine-setup-2 avoid to replace version locking list file engine-cleanup-2 removes ovirt-engine lines from locking list file introducing the possibility of removing lines from modified file lists. Change-Id: Ib1b9142088cfa7def37f6d1ad3d2a4204aebe8ae Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-remove/files/simple.py M packaging/setup/plugins/ovirt-engine-setup/core/uninstall.py M packaging/setup/plugins/ovirt-engine-setup/distro-rpm/versionlock.py 4 files changed, 116 insertions(+), 6 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1b9142088cfa7def37f6d1ad3d2a4204aebe8ae Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Generify & IoC provider proxy factory
by mkolesni＠redhat.com 22 May '13

22 May '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Generify & IoC provider proxy factory ...................................................................... engine: Generify & IoC provider proxy factory To support multiple provider & provider proxy types, this factory should be generic and return the correct type. Also turned the factory into a singleton which returns an instance that can be used for DI, so that interacting classes don't have to rely on a static relationship with the factory class. Change-Id: I79d80c28921e417e9cfbb35bb621bbdb751c667a Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxyFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/TestProviderConnectivityCommand.java 2 files changed, 18 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14967 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79d80c28921e417e9cfbb35bb621bbdb751c667a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix missing sub tab panel
by vszocs＠redhat.com 22 May '13

22 May '13

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Fix missing sub tab panel ...................................................................... webadmin: Fix missing sub tab panel In order for sub tab presenters and their parent presenters to receive proper (consistent) life-cycle callbacks, we must clear sub tab panel slot in MainContentPresenter when hiding the sub tab panel from the view. If we don't do the above, MainContentPresenter's sub tab panel slot will still be occupied with obsolete sub tab presenter, which will mess up sub tab presenter life-cycle callbacks, such as onReveal not called each time when sub tab view is shown in the view. Change-Id: Ifc67def5083889deb360c9d48adf4d9e3b6786a9 Bug-Url: https://bugzilla.redhat.com/964949 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractSubTabPanelPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/MainContentPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabEventPresenter.java 5 files changed, 18 insertions(+), 8 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc67def5083889deb360c9d48adf4d9e3b6786a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: codegen: update pom deps
by mpastern＠redhat.com 22 May '13

22 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: update pom deps ...................................................................... codegen: update pom deps Change-Id: I3c601c01e16e8f3238aff36804b377b0734d618b Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java-codegen/pom.xml 1 file changed, 1 insertion(+), 28 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c601c01e16e8f3238aff36804b377b0734d618b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: regenerate against the latest api
by mpastern＠redhat.com 22 May '13

22 May '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: regenerate against the latest api ...................................................................... sdk: regenerate against the latest api - fixed docs for GlusterBricks add|update - fixed docs for add|update Tag - added [network.usages.usage] to ClusterNetworks - in add TemplateNICs, network.id|name is no longer mandatory - StorageDomainVM can be removed asynchronously now - removed DataCenterQuota.add|delete (yet not supported) Change-Id: Id55611c1922f9139b4a1e9450f409f367abd41e1 Signed-off-by: Michael pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/Api.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterGlusterVolumeGlusterBricks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/ClusterNetworks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterNetworks.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterQuota.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterQuotas.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/StorageDomainVM.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Tag.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Tags.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/TemplateNICs.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Agent.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/BaseResource.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Body.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Boot.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/CPU.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/CpuTopology.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/CustomProperty.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Header.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/IP.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Link.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/LogicalUnit.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/MAC.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/MemoryOverCommit.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/OperatingSystem.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Option.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Parameter.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Payload.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/PayloadFile.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/PowerManagement.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ProductInfo.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/RSDL.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/SchedulingPolicyThresholds.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/StorageManager.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VCpuPin.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VLAN.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Values.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Version.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VolumeGroup.java 39 files changed, 1,459 insertions(+), 1,472 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id55611c1922f9139b4a1e9450f409f367abd41e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: gluster: Update gluster hook content during sync
by sanjal＠redhat.com 22 May '13

22 May '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Update gluster hook content during sync ...................................................................... gluster: Update gluster hook content during sync Insert content of hook when a new hook is detected during the sync process. Refactored code by extracting methods for save/update hooks Change-Id: Ie7c951f9c370b49557d7ca037185b098fa869fde Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJobTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 113 insertions(+), 46 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14773 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7c951f9c370b49557d7ca037185b098fa869fde Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine : Added GetGlusterHookById query
by kmayilsa＠redhat.com 22 May '13

22 May '13

Kanagaraj M has submitted this change and it was merged. Change subject: engine : Added GetGlusterHookById query ...................................................................... engine : Added GetGlusterHookById query This will query will return corresponding hook entity. The hook entity will contain the server hooks only if the flag includeServerHooks in true.Added dao method and test case for the same. Added serverName to GlusterServerHooks entity. created a new view gluster_server_hooks_view to include server name. Change-Id: I9b428d9cebfb9565250c57926561ffa73df7c179 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/gluster_hooks_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterHookByIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServerHook.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterHookQueryParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoTest.java 9 files changed, 149 insertions(+), 4 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b428d9cebfb9565250c57926561ffa73df7c179 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0