- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: gluster: Change sp name for hook content read
by yzaslavs＠redhat.com 21 May '13

21 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: gluster: Change sp name for hook content read ...................................................................... gluster: Change sp name for hook content read There's an issue with using same procedure with different row mappers. The procedure name - row mapper is cached and causes exception. So changed code to use different procedure for getting hook content Change-Id: Icd3c74bea322edf636fd166eb93785eceec0ed57 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/dbscripts/gluster_hooks_sp.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDaoDbFacadeImpl.java 2 files changed, 13 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd3c74bea322edf636fd166eb93785eceec0ed57 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: domain validation changes
by oschreib＠redhat.com 21 May '13

21 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: domain validation changes ...................................................................... packaging: setup: domain validation changes 1. perform reverse lookup only if AIO plugin is installed, as it is not required unless libvirt is trying to perform migration. 2. allow names without suffix, warn in this case. 3. split out hostname logic from protocols. Change-Id: I7276d3e9088fd370458846bfdcee7166331935e4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/all-in-one/core.py M packaging/setup/plugins/ovirt-engine-setup/config/__init__.py A packaging/setup/plugins/ovirt-engine-setup/config/hostname.py M packaging/setup/plugins/ovirt-engine-setup/config/protocols.py 5 files changed, 362 insertions(+), 294 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7276d3e9088fd370458846bfdcee7166331935e4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: cleanup warnings
by oschreib＠redhat.com 21 May '13

21 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: cleanup warnings ...................................................................... packaging: setup: cleanup warnings Change-Id: Ib042324c006b874c4e6a376dceffb87e500de6a3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/releasepreview/misc.py 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib042324c006b874c4e6a376dceffb87e500de6a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Removed obsolete add_fn_db_get_async_tasks_functi...
by oschreib＠redhat.com 21 May '13

21 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Removed obsolete add_fn_db_get_async_tasks_function.sql ...................................................................... packaging: Removed obsolete add_fn_db_get_async_tasks_function.sql This patch removes an obsolete code loading into the DB during upgrade flows. Change-Id: Ic0ca20ff2da1bdf8f6037e877b3697b7af8443c2 Bug-Url: https://bugzilla.redhat.com/951092 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile M ovirt-engine.spec.in D packaging/fedora/setup/add_fn_db_get_async_tasks_function.sql M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-upgrade.py 5 files changed, 0 insertions(+), 82 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0ca20ff2da1bdf8f6037e877b3697b7af8443c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Change remove message
by ecohen＠redhat.com 20 May '13

20 May '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal,webadmin: Change remove message ...................................................................... userportal,webadmin: Change remove message - Change the 'Are you sure you want to remove the following {0}?' with 'Are you sure you want to remove the following items?' Change-Id: Ia934e33d1a975e0235e1a1ffae0c8a4a7af66f10 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.java 3 files changed, 3 insertions(+), 6 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia934e33d1a975e0235e1a1ffae0c8a4a7af66f10 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: import vm - fix SD selection
by derez＠redhat.com 20 May '13

20 May '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: import vm - fix SD selection ...................................................................... webadmin: import vm - fix SD selection Fix storage domain selection on import VM dialog. Change-Id: I82edae9beaecbcba67bcd4aedeb1e47e1916c9f4 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82edae9beaecbcba67bcd4aedeb1e47e1916c9f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: import dialog doesnt open
by derez＠redhat.com 20 May '13

20 May '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: import dialog doesnt open ...................................................................... webadmin: import dialog doesnt open Moving 'initSubTabLayoutPanel' call from the ctr to 'edit' method to make sure the model is already initialized (importModel initialization is done on 'edit'). Change-Id: I1cbce0ba41b17d449d910c301e9cd8fd4193dc5d Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cbce0ba41b17d449d910c301e9cd8fd4193dc5d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: doc: document dao tests
by yzaslavs＠redhat.com 20 May '13

20 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: packaging: doc: document dao tests ...................................................................... packaging: doc: document dao tests Change-Id: Ifc5280b2d202f2efa55c8db67bc8a769207ff576 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README.developer 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc5280b2d202f2efa55c8db67bc8a769207ff576 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: use valueOf instead of number constructor
by shavivi＠redhat.com 20 May '13

20 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: use valueOf instead of number constructor ...................................................................... findbugs: use valueOf instead of number constructor findbugs code: Bx: Method invokes inefficient Number constructor; use static valueOf instead Change-Id: If77d88f1862d2e75871b28695f7d8631eb30cc91 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ObjectUtilsTest.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If77d88f1862d2e75871b28695f7d8631eb30cc91 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: use platform specific line separator for String.Fo...
by shavivi＠redhat.com 20 May '13

20 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: use platform specific line separator for String.Format ...................................................................... findbugs: use platform specific line separator for String.Format findbugs code: FS: Format string should use %n rather than \n Change-Id: I38b80e67df8c1618cbca3f0de722aef412e50664 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/EventSenderMailImpl.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/MessageHelper.java 4 files changed, 10 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38b80e67df8c1618cbca3f0de722aef412e50664 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0