- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: findbugs: Random object should be used more then once for be...
by shavivi＠redhat.com 20 May '13

20 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: Random object should be used more then once for better random ...................................................................... findbugs: Random object should be used more then once for better random findbugs code: DMI: Random object created and used only once Change-Id: I6e8c345507542829b6b31a7be5f482ec00f71397 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdGroupsSearchParametersTest.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/AdUsersSearchParametersTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/CustomMapSqlParameterSourceTest.java 3 files changed, 24 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e8c345507542829b6b31a7be5f482ec00f71397 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: returning local variable that is not written
by shavivi＠redhat.com 20 May '13

20 May '13

Shahar Havivi has submitted this change and it was merged. Change subject: findbugs: returning local variable that is not written ...................................................................... findbugs: returning local variable that is not written findbugs code: UwF: Unwritten field Change-Id: I33cf80871e5c0567ccb47d307342fbcf36911d4c Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/UiCommandButtonDefinition.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33cf80871e5c0567ccb47d307342fbcf36911d4c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: dal: tests: remove the redundant escaped connection url
by yzaslavs＠redhat.com 20 May '13

20 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: dal: tests: remove the redundant escaped connection url ...................................................................... dal: tests: remove the redundant escaped connection url Change-Id: Id2f6f5979795f34e2fd495140e38b18bdd4f8d4a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/dal/src/test/filters/pgsql.properties M backend/manager/modules/dal/src/test/resources/test-database.properties 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2f6f5979795f34e2fd495140e38b18bdd4f8d4a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: fix typo in variable name
by tnisan＠redhat.com 20 May '13

20 May '13

Tal Nisan has submitted this change and it was merged. Change subject: restapi: fix typo in variable name ...................................................................... restapi: fix typo in variable name Fix variable name from storageForamt to storageFormat in StorageDomainMapper. Change-Id: I5d22a30eeec06b6bdfc71c1de0fdd158ecb0f250 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d22a30eeec06b6bdfc71c1de0fdd158ecb0f250 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: support for PrepareForHibernation status
by ofrenkel＠redhat.com 20 May '13

20 May '13

Omer Frenkel has submitted this change and it was merged. Change subject: frontend: support for PrepareForHibernation status ...................................................................... frontend: support for PrepareForHibernation status Show the newly added VM status PrepareForHibernation exactly as SavingState in the webadmin and user portal. Change-Id: I841c75f309bfa8983a84d354632327a3996922fa Bug-Url: https://bugzilla.redhat.com/949281 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/VmStatusColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14512 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I841c75f309bfa8983a84d354632327a3996922fa Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: lock the vds manager while calling hibernate verb
by ofrenkel＠redhat.com 20 May '13

20 May '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: lock the vds manager while calling hibernate verb ...................................................................... core: lock the vds manager while calling hibernate verb It is needed to lock the vds manager so that no statuses will be updated while calling the hibernate verb in vdsm and setting the status of the VM to SavingState afterwards. The previous HibernateVDSCommand is changed to HibernateBrokerVDSCommand, and a new HibernateVDSCommand that calls it after the vds manager is locked, is added. Change-Id: I2537fffccd15cb5fa30f99793c803373886c633f Bug-Url: https://bugzilla.redhat.com/949281 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HibernateVDSCommand.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HibernateBrokerVDSCommand.java 3 files changed, 62 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/14520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2537fffccd15cb5fa30f99793c803373886c633f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: FQCN imports in the compat package
by amureini＠redhat.com 20 May '13

20 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: FQCN imports in the compat package ...................................................................... core: FQCN imports in the compat package Replaced * imports with FQCN imports, as per project conventions. Change-Id: I581e2b51162ea86539a1cd2b0879412f3a7124aa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlNamespaceManager.java M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/NGuidTest.java 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I581e2b51162ea86539a1cd2b0879412f3a7124aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: FQCN imports in action parameter classes
by amureini＠redhat.com 20 May '13

20 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: FQCN imports in action parameter classes ...................................................................... core: FQCN imports in action parameter classes Replaced * import statement with FQCN imports, as per project conventions. Change-Id: Icab6e95e181cab3db2ed091817b6750da4737a30 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AdElementParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmToPoolParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachEntityToTagParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachVdsToTagParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/BookmarksOperationParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/BookmarksParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ChangeDiskCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateCloneOfTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateImageTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DisplayNetworkToVdsGroupParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/EventSubscriptionParametesBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ExtendSANStorageDomainParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsManualyParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HibernateVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LogoutUserParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MaintenanceNumberOfVdssParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MaintenanceVdsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmToServerParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MonitorCommandParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveTagParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/PermissionsOperationsParametes.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RecoveryStoragePoolParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveAllVmImagesParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromImportExportParamenters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromPoolParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmInterfaceParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RestoreAllSnapshotsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RoleWithActionGroupsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetStoragePoolStatusParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetVmTicketParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ShutdownVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StopVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageDomainPoolParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StoragePoolWithStoragesParameter.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TagsActionParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TagsOperationParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TagsVmMapParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TryBackToAllSnapshotsOfVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVdsActionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsActionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsGroupOperationParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsGroupParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolParametersBase.java 46 files changed, 71 insertions(+), 66 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icab6e95e181cab3db2ed091817b6750da4737a30 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove GetAllVmSnapshotsByDriveReturnValue
by amureini＠redhat.com 20 May '13

20 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Remove GetAllVmSnapshotsByDriveReturnValue ...................................................................... engine: Remove GetAllVmSnapshotsByDriveReturnValue Removed GetAllVmSnapshotsByDriveReturnValue and its custom serializer, as it is not used anywhere in the project. Change-Id: Ib80a3318f0595d95860c38386027491d05cb4501 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmSnapshotsByDriveQueryReturnValue.java D frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/GetAllVmSnapshotsByDriveQueryReturnValue_CustomFieldSerializer.java 2 files changed, 0 insertions(+), 65 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib80a3318f0595d95860c38386027491d05cb4501 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed unused parameter classes
by amureini＠redhat.com 20 May '13

20 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Removed unused parameter classes ...................................................................... core: Removed unused parameter classes Removed the action parameter classes which are no longer in use. Change-Id: Ib95c0221db515e98aad16e932a77033f007519f4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AdGroupElementParametersBase.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmAndAttachToUserParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ExportVmParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ExportVmTemplateParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LogoffVmParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetAdGroupRoleParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetDedicatedVmParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetUserRoleParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsClusterParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolToAdGroupParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmToAdGroupParameters.java 11 files changed, 0 insertions(+), 338 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib95c0221db515e98aad16e932a77033f007519f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0