- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Corrections to Event.equal to avoid confusions and u...
by asaf＠redhat.com 16 Feb '13

16 Feb '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: engine: Corrections to Event.equal to avoid confusions and unexpected behaviors. ...................................................................... engine: Corrections to Event.equal to avoid confusions and unexpected behaviors. - Changed the covariant version of the Event.equals(Event other) to override standard java Object.equals(Object other), the equality is a natural identity and is based on the privateName & privateOwnerType properties. - Generated a hashCode() method which is compatible with the equals implementation. - Renamed Event.equals(EventDefinition ed) to Event.matchesDefinition(EventDefinition ed) as the name of the method overloads java standard Object.equals(Object other) method which is risky and may cause unexpected behaviors. Change-Id: Idca42d6a61454162db412429e55898f15152c12d Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/LoginModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MoveHost.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModelBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/tags/TagListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModelErrorEventListener.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/MigrateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Event.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 29 files changed, 93 insertions(+), 71 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idca42d6a61454162db412429e55898f15152c12d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: AsyncTaskDAO proper newline logging
by amureini＠redhat.com 16 Feb '13

16 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: AsyncTaskDAO proper newline logging ...................................................................... core: AsyncTaskDAO proper newline logging Used the %n platform independent newline instead of the platform specific \n in AsyncTaskDAODbFacadeImpl's logging. This addresses the VA_FORMAT_STRING_USES_NEWLINE FindBugs warning. Change-Id: I1bf28f3006b24f121d1c97ac1034f03e62c51d6e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bf28f3006b24f121d1c97ac1034f03e62c51d6e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: gwt-maven-plugin POM cleanup
by asaf＠redhat.com 15 Feb '13

15 Feb '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin,userportal: gwt-maven-plugin POM cleanup ...................................................................... webadmin,userportal: gwt-maven-plugin POM cleanup This patch eliminates some duplicities in WebAdmin and UserPortal POM files and adds new feature with regard to 'gwtdev' profile. 1. Common properties used with GWT compilation moved to parent POM's <properties> 2. Common gwt-maven-plugin plugin configuration moved to parent POM's <pluginManagement> 3. 'all-langs' profile definition moved to parent POM's <profiles> 4. Activating 'gwtdev' profile when compiling GWT application (not debugging) will produce 'DETAILED' JavaScript output and enable draft compile (should be faster) Item 4. makes it a bit easy to analyze/profile GWT application during development. Change-Id: I1d064980ac3269373b1c17040bcc1b5cd704445f Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml 3 files changed, 81 insertions(+), 133 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12071 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d064980ac3269373b1c17040bcc1b5cd704445f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Fix NPE on Jboss startup
by tnisan＠redhat.com 15 Feb '13

15 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix NPE on Jboss startup ...................................................................... restapi: Fix NPE on Jboss startup Fixed an NPE on Jboss startup caused by trying to get the wrong key from the stats map, the name was changed along with the StorageDomain entity name change but was supposed to remain the same since the stat name is hardcoded in GetSystemStatisticsQuery Change-Id: I66643eb750dd1f7d7054db387a24a843b211a7c5 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66643eb750dd1f7d7054db387a24a843b211a7c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: codegen: move to template oriented concept
by mpastern＠redhat.com 15 Feb '13

15 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: move to template oriented concept ...................................................................... codegen: move to template oriented concept Change-Id: I999f64d74f09a813d16ec5877efa8a4949db18c2 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/collection/collection.py M src/codegen/collection/collectionexceptions.py D src/codegen/collection/resource.py M src/codegen/common/icodegen.py M src/codegen/doc/documentation.py M src/codegen/entrypoint/entrypoint.py D src/codegen/imp/imprt.py R src/codegen/imprt/__init__.py A src/codegen/imprt/imprt.py D src/codegen/infrastructure/collection.py D src/codegen/infrastructure/resource.py M src/codegen/infrastructure/staticdataholder.py C src/codegen/resource/__init__.py A src/codegen/resource/resource.py M src/codegen/rsdl/abstractrsdlcodegen.py M src/codegen/rsdl/rsdlcodegen.py M src/codegen/subcollection/subcollection.py D src/codegen/subcollection/subresource.py C src/codegen/subresource/__init__.py A src/codegen/subresource/subresource.py C src/codegen/templates/__init__.py A src/codegen/templates/abstracttemplate.py A src/codegen/templates/collectionaddtemplate A src/codegen/templates/collectionaddtemplate.py A src/codegen/templates/collectiongetcapabilitiestemplate A src/codegen/templates/collectiongetcapabilitiestemplate.py A src/codegen/templates/collectiongetdiskstemplate A src/codegen/templates/collectiongetdiskstemplate.py A src/codegen/templates/collectiongetnotsearchabletemplate A src/codegen/templates/collectiongetnotsearchabletemplate.py A src/codegen/templates/collectiongetsearchabletemplate A src/codegen/templates/collectiongetsearchabletemplate.py A src/codegen/templates/collectionlistcapabilitiestemplate A src/codegen/templates/collectionlistcapabilitiestemplate.py A src/codegen/templates/collectionlistnotsearchabletemplate A src/codegen/templates/collectionlistnotsearchabletemplate.py A src/codegen/templates/collectionlistsearchabletemplate A src/codegen/templates/collectionlistsearchabletemplate.py A src/codegen/templates/collectiontemplate A src/codegen/templates/collectiontemplate.py A src/codegen/templates/copyrighttemplate A src/codegen/templates/copyrighttemplate.py A src/codegen/templates/entrypointdyinamicmethodtemplate A src/codegen/templates/entrypointdyinamicmethodtemplate.py A src/codegen/templates/entrypointheadtemplate A src/codegen/templates/entrypointheadtemplate.py A src/codegen/templates/entrypointmethodstemplate A src/codegen/templates/entrypointmethodstemplate.py A src/codegen/templates/entrypointstaticmethodtemplate A src/codegen/templates/entrypointstaticmethodtemplate.py A src/codegen/templates/entrypointtemplate A src/codegen/templates/entrypointtemplate.py A src/codegen/templates/importstemplate A src/codegen/templates/importstemplate.py A src/codegen/templates/itemplate.py A src/codegen/templates/resourceactiontemplate A src/codegen/templates/resourceactiontemplate.py A src/codegen/templates/resourcedeletetemplate A src/codegen/templates/resourcedeletetemplate.py A src/codegen/templates/resourcedeletewithbodyandparamstemplate A src/codegen/templates/resourcedeletewithbodyandparamstemplate.py A src/codegen/templates/resourcedeletewithbodytemplate A src/codegen/templates/resourcedeletewithbodytemplate.py A src/codegen/templates/resourcedeletewithparamstemplate A src/codegen/templates/resourcedeletewithparamstemplate.py A src/codegen/templates/resourcetemplate A src/codegen/templates/resourcetemplate.py A src/codegen/templates/resourceupdatetemplate A src/codegen/templates/resourceupdatetemplate.py A src/codegen/templates/subcollectionaddtemplate A src/codegen/templates/subcollectionaddtemplate.py A src/codegen/templates/subcollectiongettemplate A src/codegen/templates/subcollectiongettemplate.py A src/codegen/templates/subcollectionlisttemplate A src/codegen/templates/subcollectionlisttemplate.py A src/codegen/templates/subcollectionlistwithparamstemplate A src/codegen/templates/subcollectionlistwithparamstemplate.py A src/codegen/templates/subcollectiontemplate A src/codegen/templates/subcollectiontemplate.py A src/codegen/templates/subresourceactiontemplate A src/codegen/templates/subresourceactiontemplate.py A src/codegen/templates/subresourcecollectionactiontemplate A src/codegen/templates/subresourcecollectionactiontemplate.py A src/codegen/templates/subresourcedeletetemplate A src/codegen/templates/subresourcedeletetemplate.py A src/codegen/templates/subresourcedeletewithbodytemplate A src/codegen/templates/subresourcedeletewithbodytemplate.py A src/codegen/templates/subresourcedeletewithurlparamsandbodytemplate A src/codegen/templates/subresourcedeletewithurlparamsandbodytemplate.py A src/codegen/templates/subresourcedeletewithurlparamstemplate A src/codegen/templates/subresourcedeletewithurlparamstemplate.py A src/codegen/templates/subresourcetemplate A src/codegen/templates/subresourcetemplate.py A src/codegen/templates/subresourceupdatetemplate A src/codegen/templates/subresourceupdatetemplate.py A src/codegen/utils/paramscontainer.py R src/codegen/xsd/README M src/codegen/xsd/abstractxsdcodegen.py R src/codegen/xsd/genparams.py R src/codegen/xsd/paramsconf.py M src/codegen/xsd/xsdcodegen.py M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/infrastructure/common.py M src/ovirtsdk/web/connection.py M src/ovirtsdk/web/httpsconnection.py 106 files changed, 7,529 insertions(+), 2,890 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I999f64d74f09a813d16ec5877efa8a4949db18c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: using search backend to find Up server in cluster
by sanjal＠redhat.com 15 Feb '13

15 Feb '13

Shireesh Anjal has submitted this change and it was merged. Change subject: webadmin: using search backend to find Up server in cluster ...................................................................... webadmin: using search backend to find Up server in cluster To find whether there are any host in Up staus in a cluster, SearchQuery is used with Status=Up and MaxCount 1 . The code is refactored to use the new technique rather than fetching the full host list of a cluster and iterating through them. Change-Id: Ib2ba449d2fa43d0c2e510ec4d0b51d3dc359b6ae Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java 2 files changed, 37 insertions(+), 15 deletions(-) Approvals: Shireesh Anjal: Looks good to me, approved Kanagaraj M: Verified -- To view, visit http://gerrit.ovirt.org/11995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2ba449d2fa43d0c2e510ec4d0b51d3dc359b6ae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix replicate bricks confirmation not closing
by sanjal＠redhat.com 15 Feb '13

15 Feb '13

Shireesh Anjal has submitted this change and it was merged. Change subject: webadmin: Fix replicate bricks confirmation not closing ...................................................................... webadmin: Fix replicate bricks confirmation not closing When adding bricks to a replicate volume, if the bricks of a sub-volume resides in the same machine a confirmation will be shown. The confirmation dialog was not getting closed after clicking yes, this is fixed now. Change-Id: Ib4d7e76e5e82329bac4cb0368f45caccacc2b62d Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Shireesh Anjal: Looks good to me, approved Kanagaraj M: Verified -- To view, visit http://gerrit.ovirt.org/11948 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4d7e76e5e82329bac4cb0368f45caccacc2b62d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix db upgrade in PostgreSQL 8.x
by amureini＠redhat.com 14 Feb '13

14 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix db upgrade in PostgreSQL 8.x ...................................................................... core: Fix db upgrade in PostgreSQL 8.x PostgreSQL 8.x and 9.x have a different behaviour regarding when inline SQL queries in PL/pgSQL code is evaluated (see http://wiki.postgresql.org/wiki/What%27s_new_in_PostgreSQL_9.0#PL.2FpgSQL_c…) The current problem in upgrading the database in PostgreSQL 8.x is the min_refresh_rate column added in 03_02_0440_materialized_views_extensions.sql. The relevant parts of current flow (before the patch): 1. pre_upgrade script 30 creates the materialized_views table 2. materialized view functions are created 3. [various upgrade scripts] 4. 03_02_0440_materialized_views_extensions.sql - add a column to materialized_views. In 8.x variants, stage (2) will fail since the function can not compile due to the missing column. This patch changes the flow as follows: 1. pre_upgrade script 30 creates the materialized_views table 2. pre_upgrade script 40 adds the missing column 3. materialized view functions are created 4. [various upgrade scripts] Note that the original dbscripts/upgrade/03_02_0440_materialized_views_extensions.sql is preserved for backwards compatibility. Since it is reentrant (the column is only created if it did not previously exist), this is the safest way to go. Change-Id: Ifc40a2d40c067b1ace123c565cada27ddd26cc5c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A backend/manager/dbscripts/upgrade/pre_upgrade/0040_materialized_views_extensions.sql 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc40a2d40c067b1ace123c565cada27ddd26cc5c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Refactored base Model class probihition reason opt...
by tnisan＠redhat.com 14 Feb '13

14 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Refactored base Model class probihition reason option ...................................................................... webadmin: Refactored base Model class probihition reason option Changed the base ui model prohibition reason from a list of Strings which was only used with a single value to a string Also fixed places in which the prohibition reason was not displayed correctly due to the reason being set only after the changability property change thus setting the reason after the rendering of the element as disabled Change-Id: Idda39fe051b2547c202dab9a0a1970779001b70e Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HasEnabledWithHints.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/WidgetWithLabelEditor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmData.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java 23 files changed, 84 insertions(+), 123 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idda39fe051b2547c202dab9a0a1970779001b70e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Remove some notifier dependencies
by juan.hernandez＠redhat.com 14 Feb '13

14 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: tools: Remove some notifier dependencies ...................................................................... tools: Remove some notifier dependencies The script that starts the notifier adds to the classpath some dependencies that are not needed, this patch removes them. Change-Id: I592f0c0150b5f7f252ddca9666aa1fa68a0d30e3 Bug-Url: https://bugzilla.redhat.com/911216 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/tools/src/main/conf/engine-notifier.conf M backend/manager/tools/src/main/shell/engine-notifier.sh M backend/manager/tools/src/test/resources/conf/connection-test-notifier.conf M backend/manager/tools/src/test/resources/conf/error-notifier.conf 4 files changed, 0 insertions(+), 42 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I592f0c0150b5f7f252ddca9666aa1fa68a0d30e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0