- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: tools: engine-config enable get key by alternateKey name
by ofrenkel＠redhat.com 14 Feb '13

14 Feb '13

Omer Frenkel has submitted this change and it was merged. Change subject: tools: engine-config enable get key by alternateKey name ...................................................................... tools: engine-config enable get key by alternateKey name Enable to use $ engine-config -g AlternateKeyName Change-Id: If42e7f15df3153a4163abcf14c57a045a9b9ae58 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Martin Beták: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If42e7f15df3153a4163abcf14c57a045a9b9ae58 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: Application Mode option in installer
by oschreib＠redhat.com 14 Feb '13

14 Feb '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Application Mode option in installer ...................................................................... packaging: Application Mode option in installer Application Mode option added to engine-setup, Engine can be configured as gluster only, virtualization only or both. This new prompt can be disabled by setting USE_DEFAULT_APPLICATION_MODE_WITHOUT_PROMPT to True in basedef.py Also introduced a Constant(CONST_DEFAULT_APPLICATION_MODE) in basedef.py to set the default application mode. Now USE_DEFAULT option can be dynamic, so function name can be specified instead of value. Initially USE_DEFAULT contains True or False, now function name can be given instead of Boolean which helps to decide usage depending on the other questions answered. Modified NFS options override in plugins/all_in_one_100.py since those options can be managed by setting USE_DEFAULT dynamically. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=901443 Change-Id: I2c958205727905d00f6e407779ee64f5c5eb5a1a Signed-off-by: Aravinda VK <avishwan(a)redhat.com> (cherry picked from commit 3dde9fbe2792e54d5c6c93d0e88cf8ab84f95367) --- M backend/manager/dbscripts/inst_sp.sql M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/output_messages.py M packaging/fedora/setup/plugins/all_in_one_100.py 6 files changed, 117 insertions(+), 13 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c958205727905d00f6e407779ee64f5c5eb5a1a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Aravinda VK <avishwan(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com> Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: BackendExportDomainDisksResourceTest build
by mpastern＠redhat.com 14 Feb '13

14 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: BackendExportDomainDisksResourceTest build ...................................................................... restapi: BackendExportDomainDisksResourceTest build Fix the build break introduced in change-id I83fd4b046f72f73bb516615137522ac40028a7f0I83fd4b046f72f73bb516615137522ac40028a7f0 (using setimageStatus instead of setImageStatus). Change-Id: I7e1a303a00826d3d1f07b648ef97bd5d8c07a21b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendExportDomainDisksResourceTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e1a303a00826d3d1f07b648ef97bd5d8c07a21b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : error when adding disk with missing parameters(#89...
by mpastern＠redhat.com 14 Feb '13

14 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : error when adding disk with missing parameters(#890524) ...................................................................... restapi : error when adding disk with missing parameters(#890524) When trying to add disk with missing parameters we get error with superfluous 0: Disk [format, interface] required for invoke0 This patch fixes the error message by returning the right operation name in the message Change-Id: I754786cf3f916bc3e34bda71073ff3ebcaca94d1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=890524 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I754786cf3f916bc3e34bda71073ff3ebcaca94d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : error when adding disk with missing parameters(#89...
by mpastern＠redhat.com 14 Feb '13

14 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : error when adding disk with missing parameters(#890524) ...................................................................... restapi : error when adding disk with missing parameters(#890524) When trying to add disk with missing parameters we get error with superfluous 0: Disk [format, interface] required for invoke0 This patch fixes the error message by returning the right operation name in the message Change-Id: I2969ea3234296f5d3583ca70b86b8bfa93dc53ed Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=890524 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2969ea3234296f5d3583ca70b86b8bfa93dc53ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : close api gaps for operation using id and name (#8...
by mpastern＠redhat.com 14 Feb '13

14 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : close api gaps for operation using id and name (#890329) ...................................................................... restapi : close api gaps for operation using id and name (#890329) Update host can use cluster id and not cluster name This patch lets the user specify cluster id or name for updating a vm. Change-Id: I0827f5984d630db540f2415e32c1e8e685996b38 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=890329 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java 3 files changed, 52 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0827f5984d630db540f2415e32c1e8e685996b38 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : close api gaps for operation using id and name (#8...
by mpastern＠redhat.com 14 Feb '13

14 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : close api gaps for operation using id and name (#890329) ...................................................................... restapi : close api gaps for operation using id and name (#890329) Update host can use cluster id and not cluster name This patch lets the user specify cluster id or name for updating a vm. Change-Id: I93a423f01fd6b140482d17558e058604b6009a2a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=890329 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java 3 files changed, 53 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/11947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93a423f01fd6b140482d17558e058604b6009a2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Move encryption utilities to utils
by juan.hernandez＠redhat.com 14 Feb '13

14 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Move encryption utilities to utils ...................................................................... core: Move encryption utilities to utils We have only two utility classes in the engineencryptutils project, and they fit will in the utils project. Change-Id: I26a1583969ef714712a02e1da911a2e497c5799b Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQuery.java M backend/manager/modules/bll/src/test/resources/log4j.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DomainsPasswordMap.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DomainsPasswordMapTest.java D backend/manager/modules/engineencryptutils/pom.xml D backend/manager/modules/engineencryptutils/src/test/java/ca.der D backend/manager/modules/engineencryptutils/src/test/java/ca.pfx D backend/manager/modules/engineencryptutils/src/test/resources/key.p12 D backend/manager/modules/engineencryptutils/src/test/resources/log4j.xml M backend/manager/modules/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/pki/PKIResourceServlet.java M backend/manager/modules/utils/pom.xml R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EncryptionUtils.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/OpenSSHUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/EngineSSHDialog.java R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/EncryptionUtilsTest.java R backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/crypt/OpenSSHUtilsTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHDialogTest.java M backend/manager/modules/utils/src/test/resources/log4j.xml M backend/manager/tools/pom.xml M backend/manager/tools/src/main/conf/engine-config-log4j.xml M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/tools/common/db/StandaloneDataSource.java M backend/manager/tools/src/main/shell/engine-config.sh M backend/manager/tools/src/main/shell/engine-manage-domains.sh M backend/manager/tools/src/main/shell/engine-notifier.sh M ear/pom.xml M packaging/fedora/spec/ovirt-engine.spec.in 35 files changed, 20 insertions(+), 146 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11924 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26a1583969ef714712a02e1da911a2e497c5799b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : Missing opertions for snapshots in RESTAPI(#867339...
by mpastern＠redhat.com 14 Feb '13

14 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Missing opertions for snapshots in RESTAPI(#867339) ...................................................................... restapi : Missing opertions for snapshots in RESTAPI(#867339) In RESTAPI some opertions for snapshot are missing which are available in webadmin. This patch adds preview, commit and undo operations to the snapshot resource. Change-Id: If2bbf6ba2c3f71230d3fdd98ca60c0c3d0f902fb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=867339 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/SnapshotResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResourceTest.java 4 files changed, 140 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2bbf6ba2c3f71230d3fdd98ca60c0c3d0f902fb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Host life cycle improvement - InitVdsOnUp
by mkublin＠redhat.com 14 Feb '13

14 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Host life cycle improvement - InitVdsOnUp ...................................................................... engine: Host life cycle improvement - InitVdsOnUp InitVdsOnUp is called from VdsManager.OnTimer, vds object can be passed directly we don't need to pass id and after that retrieve an object again from DB. Less queries we use - much faster we run. Change-Id: I4b3e883dd365d9f036a1103a44b771e14116bcbf Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostStoragePoolParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 5 files changed, 19 insertions(+), 16 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b3e883dd365d9f036a1103a44b771e14116bcbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0