- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove LdapIsComputerWithTheSameNameExists
by amureini＠redhat.com 03 Feb '13

03 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove LdapIsComputerWithTheSameNameExists ...................................................................... core: Remove LdapIsComputerWithTheSameNameExists This command is just dead code - its executeQuery() method is completely commented out, and it has no entry in VdcActionType, so there is no way of calling it. Change-Id: Id8db1e4174922d353ebcc1fc415b677e8ec69930 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapIsComputerWithTheSameNameExistsCommand.java 1 file changed, 0 insertions(+), 54 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id8db1e4174922d353ebcc1fc415b677e8ec69930 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: fix locking issue in GlusterMultipleActionsRunner
by sanjal＠redhat.com 03 Feb '13

03 Feb '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: fix locking issue in GlusterMultipleActionsRunner ...................................................................... engine: fix locking issue in GlusterMultipleActionsRunner GlusterMultipleActionsRunner#executeValidatedCommands() had code to re-acquire the lock released at the end of canDoAction. However, this should not happen in case the CanDoAction had failed, as MultipleActionsRunner#executeValidatedCommand() doesn't even execute the command in this case. Performed a minor refactoring in MultipleActionsRunner as follows: - renamed executeValidatedCommands() to executeValidatedCommand() - executeValidatedCommand() gets called only when canDoAction was success Change-Id: I100603d7155deb67bb2f0a8b451732a0003fbf55 Bug-Url: https://bugzilla.redhat.com/905904 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GlusterMultipleActionsRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java 3 files changed, 21 insertions(+), 20 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I100603d7155deb67bb2f0a8b451732a0003fbf55 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove AuditLogableBaseMockUtils
by amureini＠redhat.com 03 Feb '13

03 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove AuditLogableBaseMockUtils ...................................................................... core: Remove AuditLogableBaseMockUtils AuditLogableBaseMockUtils was used to mock VmDAO in tests for bll commands. since this can now be done directly, this class is not longer required. Change-Id: Ib44258e3679ef3cd1d05aa4326ec09fff4c9d2bd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveDisksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveQuotaCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseMockUtils.java 15 files changed, 17 insertions(+), 55 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11606 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib44258e3679ef3cd1d05aa4326ec09fff4c9d2bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: RemoveStorageDomainTest: simplify msg check
by amureini＠redhat.com 03 Feb '13

03 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveStorageDomainTest: simplify msg check ...................................................................... core: RemoveStorageDomainTest: simplify msg check Simplified the way canDoAction messages are asserted in the test. Change-Id: I134240763353c88d14948bea535e362c3db42fd1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainTest.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I134240763353c88d14948bea535e362c3db42fd1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com>

1 0

Change in ovirt-engine[master]: cleanup: update .gitignore
by juan.hernandez＠redhat.com 01 Feb '13

01 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: cleanup: update .gitignore ...................................................................... cleanup: update .gitignore 1. python objects. 2. build generated files. Change-Id: Ie766950c96bfb36f210e9792437adc5b9c326693 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M .gitignore 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie766950c96bfb36f210e9792437adc5b9c326693 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: encryptpasswd: remove unneeded pushd/popd
by juan.hernandez＠redhat.com 01 Feb '13

01 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: pki: encryptpasswd: remove unneeded pushd/popd ...................................................................... pki: encryptpasswd: remove unneeded pushd/popd Change-Id: I04ead54d0db7847b65dbab415d98b2ed460738e9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/conf/ca/encryptpasswd.sh 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04ead54d0db7847b65dbab415d98b2ed460738e9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: install private directories not world readable
by juan.hernandez＠redhat.com 01 Feb '13

01 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: pki: install private directories not world readable ...................................................................... pki: install private directories not world readable This will enable to drop the permission change at setup. Change-Id: I9928cff3f16633e2bea8064b6ee9672f5043fab0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9928cff3f16633e2bea8064b6ee9672f5043fab0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: process template files not in-place
by juan.hernandez＠redhat.com 01 Feb '13

01 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: pki: process template files not in-place ...................................................................... pki: process template files not in-place Change-Id: Iaba7b66633eb92b0b6602fb17218d5e844256dd3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile R backend/manager/conf/ca/cacert.template.in R backend/manager/conf/ca/cert.template.in M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/spec/ovirt-engine.spec.in 6 files changed, 26 insertions(+), 11 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaba7b66633eb92b0b6602fb17218d5e844256dd3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: compat: convert to base64 without line feed
by tjelinek＠redhat.com 01 Feb '13

01 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: compat: convert to base64 without line feed ...................................................................... compat: convert to base64 without line feed This is regression of change Ie7a540d9c69, as the ticketing base64 conversion should not contain line feed. Change-Id: I33790b47ede99eade178b488a66cd8cc280cb872 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Ticketing.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33790b47ede99eade178b488a66cd8cc280cb872 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Make dependency on commons-collections explicit
by juan.hernandez＠redhat.com 01 Feb '13

01 Feb '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Make dependency on commons-collections explicit ...................................................................... core: Make dependency on commons-collections explicit The code imports classes from the org.apache.commons.collections package, so the dependency must be included. Change-Id: Id46b4d7a360348a67fa7430b4af0eefa3d76fe2a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/utils/pom.xml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id46b4d7a360348a67fa7430b4af0eefa3d76fe2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0