- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: executing squartz job immediately
by mkublin＠redhat.com 03 Feb '13

03 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: core: executing squartz job immediately ...................................................................... core: executing squartz job immediately This patch adds an option in the SchedulerUtil API to execute scheduled job immediately. SchedulerUtil#triggerJob method, that executes immediately the job with the given id, was added. Relevant unit test was added and set to be disabled like the rest of the similar tests which already exists. Change-Id: I4661691ae970e7517a4e3a43ae87736ebd1cc15f Bug-Url: https://bugzilla.redhat.com/888396 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/beans/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java M backend/manager/modules/beans/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java M backend/manager/modules/beans/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java 3 files changed, 70 insertions(+), 0 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11636 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4661691ae970e7517a4e3a43ae87736ebd1cc15f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Frontend class formatting
by tnisan＠redhat.com 03 Feb '13

03 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Frontend class formatting ...................................................................... webadmin: Frontend class formatting Change-Id: I346993b83db0985903933bc09e39ba4b72f78d5d Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java 1 file changed, 57 insertions(+), 49 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I346993b83db0985903933bc09e39ba4b72f78d5d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Cleanup of Frontend class
by tnisan＠redhat.com 03 Feb '13

03 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Cleanup of Frontend class ...................................................................... webadmin: Cleanup of Frontend class - Remove of unused methods and members - Remove return types from unsupported sync methods and mark them as deprecated Change-Id: I2799eed79b4534d103fbbc53a6658ecc950c43f0 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/FindDesktopModel.java 5 files changed, 23 insertions(+), 129 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2799eed79b4534d103fbbc53a6658ecc950c43f0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Disable global transaction at ExtendSANStorageDomain
by mkublin＠redhat.com 03 Feb '13

03 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Disable global transaction at ExtendSANStorageDomain ...................................................................... engine: Disable global transaction at ExtendSANStorageDomain During investigation on some bug, I noticed that we have too many transaction time out exceptions on ExtendSANStorageDomainCommand. The problem is that following command is trying to open a global transaction, this is a mistake, transaction is a global resource and should be kept as short as possible. The change is: 1. Disable global transaction 2. Start to use compensation in order to keep flow correct Change-Id: I78c4c43c259a58c746caa0402bf5beb004e9a8c2 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java 1 file changed, 34 insertions(+), 18 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78c4c43c259a58c746caa0402bf5beb004e9a8c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine-manage-domains: Adding man page
by yzaslavs＠redhat.com 03 Feb '13

03 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine-manage-domains: Adding man page ...................................................................... engine-manage-domains: Adding man page Adding engine-manage-domains.8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=742421 Change-Id: I26e69ce1410ce1ffd0c8ce242ea519ff3c5daee6 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M Makefile A packaging/engine-manage-domains.8 2 files changed, 52 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26e69ce1410ce1ffd0c8ce242ea519ff3c5daee6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed misbranded resources
by ydary＠redhat.com 03 Feb '13

03 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed misbranded resources ...................................................................... reports: fixed misbranded resources Change-Id: I60fa180002e28db89d6e2df71922270b082b676c Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M manifest/ovirt-reports-manifest.csv M server-customizations/WEB-INF/decorators/decorator.jsp M server-customizations/WEB-INF/decorators/minimalDecorator.jsp M server-customizations/WEB-INF/jsp/modules/login/login.jsp 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I60fa180002e28db89d6e2df71922270b082b676c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Enable remove quota when quota is not enforced
by derez＠redhat.com 03 Feb '13

03 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: core: Enable remove quota when quota is not enforced ...................................................................... core: Enable remove quota when quota is not enforced In current implementation there is no way to remove all quota from the DC once a quota was assigned to some entities. The CanDoAction logic of removing quota was changed so that when a DC is in 'Disabled' Quota enforcement mode a quota could be removed (regardless of it been assigned to some entities). Change-Id: I95ff993b0db21a17e62e3258338bd524c5c8b957 Bug-Url: https://bugzilla.redhat.com/895237 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 6 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95ff993b0db21a17e62e3258338bd524c5c8b957 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: handle error when iso domain in maintenance
by mlipchuk＠redhat.com 03 Feb '13

03 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: handle error when iso domain in maintenance ...................................................................... core: handle error when iso domain in maintenance The bug started from code inserted in change I9d24c94c. Currently, when iso domain cannot be accessed for any reason, it's considered a problematic domain and is mentioned in the event log. This patch adds a check that if the domain is not active, it is not attempted to be refreshed, hence not adding in event log the error (because it's expected it cannot be accessed) Change-Id: Ide53f42c087ffbc9240cccc033e809ff8117ec8c Bug-Url: https://bugzilla.redhat.com/902246 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java 1 file changed, 26 insertions(+), 25 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide53f42c087ffbc9240cccc033e809ff8117ec8c Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replacing use of Quartz scheduler by ThreadPool duri...
by mkublin＠redhat.com 03 Feb '13

03 Feb '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Replacing use of Quartz scheduler by ThreadPool during SPM election ...................................................................... engine: Replacing use of Quartz scheduler by ThreadPool during SPM election The following patch will use a thread pool util instead of quartz scheduler for running immediate job. Change-Id: Ice54e028545ea6772528c9ab30abc7ff5c5276c7 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 26 insertions(+), 20 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice54e028545ea6772528c9ab30abc7ff5c5276c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix sql grammar for calculateallstorageusage
by yzaslavs＠redhat.com 03 Feb '13

03 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fix sql grammar for calculateallstorageusage ...................................................................... core: Fix sql grammar for calculateallstorageusage SQL grammar of calculateallstorageusage() function was changed to be compatible with older postgres versions (under 9.1). Change-Id: I1dd5d9532357f7dd267850ea76afae0f6c9d6257 Bug-Url: https://bugzilla.redhat.com/905891 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/dbscripts/create_functions.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: ofri masad: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11552 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dd5d9532357f7dd267850ea76afae0f6c9d6257 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0