- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: User queries improvements
by yzaslavs＠redhat.com 31 Dec '12

31 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: User queries improvements ...................................................................... engine: User queries improvements The following patch contains two improvements: 1. Removed unneeded calls to some functions at permissions_view, by creating the internal_permissions_view - permissions_view should be used for UI purposes , for engine/internal permission check, internal_permissions_view should be used. 2. Introduction of new splitter function. Bug-Url: https://bugzilla.redhat.com/880969 Change-Id: I62fa797fbf286513183f0a3c4409ce79bec35342 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/dbscripts/async_tasks_sp.sql M backend/manager/dbscripts/create_functions.sql M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/multi_level_administration_sp.sql M backend/manager/dbscripts/storages_sp.sql M backend/manager/dbscripts/tags_sp.sql M backend/manager/dbscripts/tags_vm_pool_map_sp.sql M backend/manager/dbscripts/user_sp.sql M backend/manager/dbscripts/vms_sp.sql 9 files changed, 87 insertions(+), 152 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62fa797fbf286513183f0a3c4409ce79bec35342 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: add GetGuestAgentQueryExpectations to the missed te...
by alkaplan＠redhat.com 31 Dec '12

31 Dec '12

Alona Kaplan has submitted this change and it was merged. Change subject: restapi: add GetGuestAgentQueryExpectations to the missed tests ...................................................................... restapi: add GetGuestAgentQueryExpectations to the missed tests setGetGuestAgentQueryExpectations was missing in some of the new tests. Change-Id: I7556528a2cd1cc85c550dc9418a97335f2b90633 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResourceTest.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7556528a2cd1cc85c550dc9418a97335f2b90633 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: create db fails on rhel 6.4 using postgres..
by emesika＠redhat.com 31 Dec '12

31 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: core: create db fails on rhel 6.4 using postgres.. ...................................................................... core: create db fails on rhel 6.4 using postgres.. create db fails on rhel 6.4 using postgresql-8.4.13-1.el6_3.x86_64 This patch fix a failure on postgres 8.4 that fails to update a parameter to a SP on postgres 8.4 while the same modification is OK for postgres 9.x. The solution uses a local SO variable to do the modifications and be used later on on the INSERT statement. This patch also modified the message data type to be text and not varchar(4000) to match the audit_table definitions. Change-Id: I4451f5bdf118efc02bb9100c59e0729283c4c2b5 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=890982 --- M backend/manager/dbscripts/audit_log_sp.sql 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4451f5bdf118efc02bb9100c59e0729283c4c2b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix error message when exporting to a non export domai...
by tnisan＠redhat.com 31 Dec '12

31 Dec '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix error message when exporting to a non export domain ...................................................................... core: Fix error message when exporting to a non export domain Change-Id: Iffe15389360d6233655056dcfd94880f8033b741 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 6 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffe15389360d6233655056dcfd94880f8033b741 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: history: added storage domain status to dwh views (#846272)
by emesika＠redhat.com 31 Dec '12

31 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: history: added storage domain status to dwh views (#846272) ...................................................................... history: added storage domain status to dwh views (#846272) Bug-Url: https://bugzilla.redhat.com/846272 Change-Id: I4e729c99bb16ad0e6e16e392719a0670c771166b Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M backend/manager/dbscripts/create_dwh_views.sql 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e729c99bb16ad0e6e16e392719a0670c771166b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Guest Agent Network Devices of Nic
by msalem＠redhat.com 31 Dec '12

31 Dec '12

Muli Salem has submitted this change and it was merged. Change subject: restapi: Guest Agent Network Devices of Nic ...................................................................... restapi: Guest Agent Network Devices of Nic This patch adds the Guest Agent information to a Nic, according to the feature design in: http://www.ovirt.org/Feature/ReportingVnicInformation. The nic holds a list of reported devices according to mac address. Change-Id: Ieb968da0b0ea5eecb3ad5e2670224cb9b6d0c360 Signed-off-by: Muli Salem <msalem(a)redhat.com> Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmNicResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNicsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendNicsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResourceTest.java 8 files changed, 102 insertions(+), 1 deletion(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb968da0b0ea5eecb3ad5e2670224cb9b6d0c360 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Report Guest Agent Network Devices of VM
by msalem＠redhat.com 31 Dec '12

31 Dec '12

Muli Salem has submitted this change and it was merged. Change subject: restapi: Report Guest Agent Network Devices of VM ...................................................................... restapi: Report Guest Agent Network Devices of VM This patch adds the Vm Guest Agent information to a VM, according to the feature design in: http://www.ovirt.org/Feature/ReportingVnicInformation Change-Id: I23d40e653ed4b23cc92a489b97966868bd01ae10 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/ReportedDeviceType.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmReportedDeviceResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmReportedDevicesResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmReportedDeviceResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmReportedDevicesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmReportedDeviceResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmReportedDevicesResourceTest.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/IpVersion.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ReportedDeviceMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/ReportedDeviceMapperTest.java 16 files changed, 592 insertions(+), 4 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10346 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23d40e653ed4b23cc92a489b97966868bd01ae10 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Organize imports
by msalem＠redhat.com 31 Dec '12

31 Dec '12

Muli Salem has submitted this change and it was merged. Change subject: restapi: Organize imports ...................................................................... restapi: Organize imports The patch organizes the imports of the files about to be modified by the following patches. Change-Id: Ie8bcf4004a823b6e813427dd52dc8a912174df3b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java 2 files changed, 13 insertions(+), 15 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8bcf4004a823b6e813427dd52dc8a912174df3b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine, restapi, webadmin: refactor VmNetworkInterface.active ...
by alkaplan＠redhat.com 31 Dec '12

31 Dec '12

Alona Kaplan has submitted this change and it was merged. Change subject: engine,restapi,webadmin: refactor VmNetworkInterface.active to plugged ...................................................................... engine,restapi,webadmin: refactor VmNetworkInterface.active to plugged The "active" property on VmNetworkInterface repersents if the vnic is plugged to the vm, not if the vnic is active. A vnic is active just if it is plugged, linked and the vm is up. Change-Id: Ieda87b2045bc247f817db6b305bc0b049e056ae1 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/AddVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterface.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAODbFacadeImpl.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/NicActivateStatusColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/PoolInterfaceListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/BaseEditVmInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java 14 files changed, 28 insertions(+), 29 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieda87b2045bc247f817db6b305bc0b049e056ae1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Port mirroring was disabled if it wasn't set.
by alkaplan＠redhat.com 31 Dec '12

31 Dec '12

Alona Kaplan has submitted this change and it was merged. Change subject: restapi: Port mirroring was disabled if it wasn't set. ...................................................................... restapi: Port mirroring was disabled if it wasn't set. If port mirroring is not set, it shouldn't be changed. Change-Id: I9c75ed210c51241358e33b69669b9c6faae13bd1 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c75ed210c51241358e33b69669b9c6faae13bd1 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0