- Engine-commits - oVirt List Archives

Change in ovirt-reports[master]: packaging: changed reports version to 3.2.0
by ydary＠redhat.com 27 Dec '12

27 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: changed reports version to 3.2.0 ...................................................................... packaging: changed reports version to 3.2.0 Change-Id: I3dede5385f5b4df85be42123899a4323e6c6dc12 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-reports.spec.in M pom.xml M reports/jars/ChartsCustomizers/pom.xml M reports/jars/EngineAuthentication/pom.xml M reports/jars/ReportsLineBarChartTheme/pom.xml M reports/jars/ReportsPieChartTheme/pom.xml M reports/jars/WebadminLineBarChartTheme/pom.xml M reports/jars/pom.xml M reports/pom.xml 9 files changed, 16 insertions(+), 16 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3dede5385f5b4df85be42123899a4323e6c6dc12 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Fix memory icon in user portal
by gchaplik＠redhat.com 27 Dec '12

27 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: Fix memory icon in user portal ...................................................................... userportal: Fix memory icon in user portal In the user portal resources side tab the icon for memory was wrong (vm icon). Icon source was fixed. Change-Id: I27b3ad740e431df86fe0f506f89f21963ef15d1c Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27b3ad740e431df86fe0f506f89f21963ef15d1c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fast update quota cache
by dfediuck＠redhat.com 27 Dec '12

27 Dec '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fast update quota cache ...................................................................... core: Fast update quota cache Monitoring Quota requires full cache in QuotaManager. Current way of fetching each quota to cache individually and calculation consumption for each quota individually is very inefficient. New store-procedures and DAO methods were added in order to support simultaneous consumption calculation of all quotas. New API (updateQuotaCache) was added to QuotaManager. New Quartz-job added to Backend to call the update every 10 (configurable) minutes. Change-Id: Id3db08957e413d2f1e0480b764334dd7268c8221 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/dbscripts/create_functions.sql M backend/manager/dbscripts/quota_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAODbFacadeImpl.java 7 files changed, 275 insertions(+), 1 deletion(-) Approvals: Doron Fediuck: Looks good to me, approved ofri masad: Verified -- To view, visit http://gerrit.ovirt.org/10159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3db08957e413d2f1e0480b764334dd7268c8221 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup VDSError - adhere to java convention
by rgolan＠redhat.com 27 Dec '12

27 Dec '12

Roy Golan has submitted this change and it was merged. Change subject: core: cleanup VDSError - adhere to java convention ...................................................................... core: cleanup VDSError - adhere to java convention Change-Id: If74985c7a37e03b6636954e110fd513abeb167e2 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VDSError.java 1 file changed, 12 insertions(+), 13 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10355 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If74985c7a37e03b6636954e110fd513abeb167e2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: remove usb check from round trip tests
by mpastern＠redhat.com 27 Dec '12

27 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: remove usb check from round trip tests ...................................................................... restapi: remove usb check from round trip tests Remove the check whether the usb's enabled state remains the same in round trip mapping test of VmMapper and TemplateMapper. This check is incorrect because: 1. in case the received usb setting is enabled but with no valid type, it could be mapped to disabled (if it's a request to add new entity or if the previous usb setting of the entity was disabled) and remains disabled while mapping it back to rest api VM. thus checking that the enabled state of the given usb setting remains the same in the round trip mapping without checking that its type is valid is wrong. 2. the usb mapping was removed from the map methods of VmMapper and TemplateMapper classes, as it's overridden by the caller anyway (because the usb mapping requires information that cannot be access from inside of the map methods). so it makes no sense to check the usb settings it in this test that tests the map methods. Change-Id: Ib7ce32dca6821a8b6eb8d69fe18413c87a6f0b3f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7ce32dca6821a8b6eb8d69fe18413c87a6f0b3f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Filter Non-Operational DCs when adding new domain
by asaf＠redhat.com 27 Dec '12

27 Dec '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: Filter Non-Operational DCs when adding new domain ...................................................................... webadmin: Filter Non-Operational DCs when adding new domain Filter Data Centers which their status is Non-Operational In the UI level when adding new storage domains. Change-Id: I8848c8bbd419b93e2e9ae1be5ebfd91baf28ed7e Bug-Url: https://bugzilla.redhat.com/841148 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModelBehavior.java 2 files changed, 19 insertions(+), 2 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8848c8bbd419b93e2e9ae1be5ebfd91baf28ed7e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move template network queries to network package
by masayag＠redhat.com 27 Dec '12

27 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Move template network queries to network package ...................................................................... engine: Move template network queries to network package Moved template network related queries to their correct package. Change-Id: Id90e6c15a748e2cdb108471bac0ba232352b58bd Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/GetTemplateInterfacesByTemplateIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/template/GetVmTemplatesAndNetworkInterfacesByNetworkIdQuery.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/template/GetTemplateInterfacesByTemplateIdQueryTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/template/GetVmTemplatesAndNetworkInterfacesByNetworkIdQueryTest.java 4 files changed, 8 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id90e6c15a748e2cdb108471bac0ba232352b58bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move VM network queries to network package
by masayag＠redhat.com 27 Dec '12

27 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Move VM network queries to network package ...................................................................... engine: Move VM network queries to network package Moved VM network related queries to their correct package. Change-Id: I247559c292173aa160d28fb5999669042158ffc9 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/GetVmInterfacesByVmIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/GetVmsAndNetworkInterfacesByNetworkIdQuery.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/GetVmInterfacesByVmIdQueryTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/GetVmsAndNetworkInterfacesByNetworkIdQueryTest.java 4 files changed, 8 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I247559c292173aa160d28fb5999669042158ffc9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move host network queries to network package
by masayag＠redhat.com 27 Dec '12

27 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Move host network queries to network package ...................................................................... engine: Move host network queries to network package Moved host network related queries to their correct package. Change-Id: I902b4336d130000c7df48e6a16e1d13efe03ee92 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllChildVlanInterfacesQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetAllSiblingVlanInterfacesQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetManagementInterfaceAddressByVmIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsFreeBondsByVdsIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsInterfacesByVdsIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVdsWithoutNetworkQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/GetVlanParanetQuery.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetManagementInterfaceAddressByVmIdQueryTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetVdsAndNetworkInterfacesByNetworkIdQueryTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/GetVdsWithoutNetworkQueryTest.java 11 files changed, 22 insertions(+), 11 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I902b4336d130000c7df48e6a16e1d13efe03ee92 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move cluster network queries to network package
by masayag＠redhat.com 27 Dec '12

27 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Move cluster network queries to network package ...................................................................... engine: Move cluster network queries to network package Moved cluster network related queries to their correct package. Change-Id: I73ffad03df34139a29edb6c9a6cb996005df84a2 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/GetAllNetworksByClusterIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/GetNetworkDisplayByClusterIdQuery.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/GetVdsGroupsAndNetworksByNetworkIdQuery.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/GetAllNetworksByClusterIdQueryTest.java R backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/GetVdsGroupsAndNetworksByNetworkIdQueryTest.java 5 files changed, 10 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73ffad03df34139a29edb6c9a6cb996005df84a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0