- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Moved VM NIC commands to their package
by mkolesni＠redhat.com 27 Dec '12

27 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Moved VM NIC commands to their package ...................................................................... engine: Moved VM NIC commands to their package Moved VM NIC related commands to their correct package. Change-Id: I407633698acb9e9bd11c77f4a737482e24cd743e Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java 4 files changed, 14 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I407633698acb9e9bd11c77f4a737482e24cd743e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Move DC network commands to their package
by mkolesni＠redhat.com 27 Dec '12

27 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Move DC network commands to their package ...................................................................... engine: Move DC network commands to their package Moved DC network related commands to their correct package. Change-Id: Ic739407f435c20e7a91e19d046a7e671665bb64d Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 4 files changed, 5 insertions(+), 4 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic739407f435c20e7a91e19d046a7e671665bb64d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add network command packages to factory
by mkolesni＠redhat.com 27 Dec '12

27 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add network command packages to factory ...................................................................... engine: Add network command packages to factory Added to factory to allow creating command that are in org.ovirt.engine.core.bll.network packages. Change-Id: I08936f9e16e205c2f39c72a41ec14b85f4f1c320 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08936f9e16e205c2f39c72a41ec14b85f4f1c320 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:fixing GeneralDbDAOTest
by yzaslavs＠redhat.com 26 Dec '12

26 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core:fixing GeneralDbDAOTest ...................................................................... core:fixing GeneralDbDAOTest Adding @size annotation to new field added : pmProxyPreferences Change-Id: I32c2bbe32f721f53aeff326f51f3f46251a5acf1 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32c2bbe32f721f53aeff326f51f3f46251a5acf1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: added logging to common utils
by ydary＠redhat.com 26 Dec '12

26 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added logging to common utils ...................................................................... packaging: added logging to common utils - Also added defaults to db values. - Get db config will now return false instead of exception if value not found. Change-Id: I7c6e6c51ce7958dea45c91cb19dcdc8a6d93fe8b Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/common_utils.py 1 file changed, 28 insertions(+), 4 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c6e6c51ce7958dea45c91cb19dcdc8a6d93fe8b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: changed version checking in setup time
by ydary＠redhat.com 26 Dec '12

26 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: changed version checking in setup time ...................................................................... packaging: changed version checking in setup time Change-Id: I262e06294247b4483545c84023211a57160ffd20 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I262e06294247b4483545c84023211a57160ffd20 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Validation added in Import Cluster
by sanjal＠redhat.com 26 Dec '12

26 Dec '12

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Validation added in Import Cluster ...................................................................... engine: Validation added in Import Cluster - Validation added to check whether the given server or any server in the importing cluster is already part of the existing cluster by checking with the database. - Renamed GetGlusterServersQuery to GetGlusterServersForImportQuery, since it is related to import cluster operation. Change-Id: I8323f2dcc4f278dfbc01f99ebe18b0f2bd0296ca Bug-Url: https://bugzilla.redhat.com/884292 Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQuery.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQueryTest.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 7 files changed, 150 insertions(+), 87 deletions(-) Approvals: Shireesh Anjal: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/9784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8323f2dcc4f278dfbc01f99ebe18b0f2bd0296ca Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UpdateVmDiskCommand canDoAction cleanup
by tnisan＠redhat.com 26 Dec '12

26 Dec '12

Tal Nisan has submitted this change and it was merged. Change subject: core: UpdateVmDiskCommand canDoAction cleanup ...................................................................... core: UpdateVmDiskCommand canDoAction cleanup Change-Id: Id74d24f991a1c00b92dec72125148a6a9fa75d5f Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 70 insertions(+), 72 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id74d24f991a1c00b92dec72125148a6a9fa75d5f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: fix usb mapping on update vm call
by mpastern＠redhat.com 26 Dec '12

26 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: fix usb mapping on update vm call ...................................................................... restapi: fix usb mapping on update vm call Change the way usb policy is set on update vm/template request which is received through rest api. The full mapping is described in the bug-url. Specifically, the new mapping states that if no usb setting is defined in the update request, the previous usb policy will remain as is (instead of being set to DISABLED as it was before), thus it solves bug #875881. UsbResourceUtils class methods moved to VmMapper class, and it was removed on the way (the same was done for UsbResourceUtilsTest class, its methods moved to VmMapperTest class). Change-Id: If74bf6ede2fc0f932db8dfcd7951b6bcf90b7744 Bug-Url: https://bugzilla.redhat.com/875881 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java D backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/UsbResourceUtils.java D backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/utils/test/UsbResourceUtilsTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 9 files changed, 334 insertions(+), 146 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If74bf6ede2fc0f932db8dfcd7951b6bcf90b7744 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: added packaging to ovirt reports.
by ydary＠redhat.com 26 Dec '12

26 Dec '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added packaging to ovirt reports. ...................................................................... packaging: added packaging to ovirt reports. - now has make file and setup. - included python3 compatibility for 'make tarball'. - add project version to pom.xml Change-Id: I96cffaebfa0ae93e004be717b547b4d3496220e4 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A Makefile A packaging/common_utils.py A packaging/decorators.py A packaging/default_master.properties A packaging/ovirt-engine-reports-setup.py A packaging/ovirt-engine-reports.spec.in M pom.xml M reports/jars/pom.xml A server-customizations/META-INF/MANIFEST.MF A server-customizations/WEB-INF/applicationContext-logging.xml A server-customizations/WEB-INF/applicationContext-security-web.xml A server-customizations/WEB-INF/applicationContext.xml A server-customizations/WEB-INF/classes/jasperreports.properties A server-customizations/WEB-INF/decorators/decorator.jsp A server-customizations/WEB-INF/decorators/minimalDecorator.jsp A server-customizations/WEB-INF/jsp/modules/login/login.jsp A server-customizations/WEB-INF/log4j.properties A server-customizations/WEB-INF/web.xml 18 files changed, 4,771 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96cffaebfa0ae93e004be717b547b4d3496220e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0