- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add NetworkLinking support to OvfVm.
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add NetworkLinking support to OvfVm. ...................................................................... core: Add NetworkLinking support to OvfVm. - Support null networkName of a vnic. - New "Linked" property on a vnic- * Should be written to the ovf. * Should be read from the ovf if exists (backward compatibility). Change-Id: If739dd0a2140fd714867c79389fe6efe133529ed Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfVmWriterTest.java 4 files changed, 46 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If739dd0a2140fd714867c79389fe6efe133529ed Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add NetworkLinking support to OvfTemplate.
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add NetworkLinking support to OvfTemplate. ...................................................................... core: Add NetworkLinking support to OvfTemplate. - Support null networkName of a vnic. - New "Linked" property on a vnic- * Should be written to the ovf. * Should be read from the ovf if exists (backward compatibility). Change-Id: Ia11fe29f87836e43bd4de240da9160857b144605 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java 2 files changed, 15 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia11fe29f87836e43bd4de240da9160857b144605 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: copy "linked" property on VmNetworkInterface clone...
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: copy "linked" property on VmNetworkInterface cloner. ...................................................................... webadmin: copy "linked" property on VmNetworkInterface cloner. "linked" boolean is a new property added to VmNetworkInterface. It should also be copied by the cloner. Change-Id: Ic00991d1919234716f6f984ba3f27af41d620786 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic00991d1919234716f6f984ba3f27af41d620786 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding "linked" property to VmNetworkInterface
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: adding "linked" property to VmNetworkInterface ...................................................................... core: adding "linked" property to VmNetworkInterface adding linked property to- - VmNetworkInterface class - vm_interface table - vm_interface_view Change-Id: I9c8d965b66201506d7e4b82d5b53012fd0bf7d61 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/dbscripts/network_sp.sql A backend/manager/dbscripts/upgrade/03_02_0130_add_linked_to_vm_interface.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterface.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 7 files changed, 40 insertions(+), 10 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c8d965b66201506d7e4b82d5b53012fd0bf7d61 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove obsolete StorageDomainTemplateQuery
by derez＠redhat.com 23 Dec '12

23 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: core: remove obsolete StorageDomainTemplateQuery ...................................................................... core: remove obsolete StorageDomainTemplateQuery Cleanup - removing obsolete query: StorageDomainTemplateQuery Change-Id: I9e090b64dd8b47a9c79dc8ad6a1c3caab62031b6 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/dbscripts/disk_images_sp.sql D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesByStorageDomainAndTemplateQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageDomainTemplateQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAOWrapperImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOTest.java 8 files changed, 0 insertions(+), 106 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e090b64dd8b47a9c79dc8ad6a1c3caab62031b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: log message on evaluateCorrelationId failure
by derez＠redhat.com 23 Dec '12

23 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: core: log message on evaluateCorrelationId failure ...................................................................... core: log message on evaluateCorrelationId failure Added a log message warning for evaluateCorrelationId() failure reasons (the method validates correlationId). Change-Id: I4e9916d549709dc83df29f1df642aef141b80e24 Bug-Url: https://bugzilla.redhat.com/886824 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e9916d549709dc83df29f1df642aef141b80e24 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: local storage - missing correlation ID
by derez＠redhat.com 23 Dec '12

23 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: local storage - missing correlation ID ...................................................................... webadmin: local storage - missing correlation ID Configure local storage: added correlation ID for AddEmptyStoragePool action. Change-Id: Ic7f331fb34238b85030e8be0bbed64998395121c Bug-Url: https://bugzilla.redhat.com/886824 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f331fb34238b85030e8be0bbed64998395121c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: VmInterfaceListModelTable style modifications
by derez＠redhat.com 23 Dec '12

23 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: VmInterfaceListModelTable style modifications ...................................................................... webadmin: VmInterfaceListModelTable style modifications Modified inner panels' margins in VmInterfaceListModelTable (removed redundant custom styling). Change-Id: I867c7b3ce7971539cfe90f0e3d3c4161d63199d9 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmInterfaceListModelTable.ui.xml 1 file changed, 2 insertions(+), 12 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Daniel Erez: Verified -- To view, visit http://gerrit.ovirt.org/10324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I867c7b3ce7971539cfe90f0e3d3c4161d63199d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: VmSnapshotListModelTable style modifications
by derez＠redhat.com 23 Dec '12

23 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: VmSnapshotListModelTable style modifications ...................................................................... webadmin: VmSnapshotListModelTable style modifications Modified inner panels' margins in VmSnapshotListModelTable (removed redundant custom styling). Change-Id: Ie2b98ab6136c483ca4740a2e088efc225a2b0a15 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.ui.xml 1 file changed, 2 insertions(+), 12 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2b98ab6136c483ca4740a2e088efc225a2b0a15 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: bridge: remove unused true always enabled
by Alon Bar-Lev 23 Dec '12

23 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: bridge: remove unused true always enabled ...................................................................... vdsm: bridge: remove unused true always enabled Change-Id: I0784d0fdcc89f4774fdc883512d7ee2dafe0b49c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/bridge.py 1 file changed, 4 insertions(+), 13 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0784d0fdcc89f4774fdc883512d7ee2dafe0b49c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0