- Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add NetworkLinking to AddVmInterfaceCommand
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: add NetworkLinking to AddVmInterfaceCommand ...................................................................... core: add NetworkLinking to AddVmInterfaceCommand - canDoAction- If "UnlinkingSupported" is false for the cluster compatibility version. - block 'null' network. - block unlinking. If "UnlinkingSupported" is true - allow 'null' network. Change-Id: I4f804e0d3117eed22814a8397d0fee12dd9e1347 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java 1 file changed, 25 insertions(+), 15 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f804e0d3117eed22814a8397d0fee12dd9e1347 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add NetworkLinking to UpdateVmInterfaceCommand
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: add NetworkLinking to UpdateVmInterfaceCommand ...................................................................... core: add NetworkLinking to UpdateVmInterfaceCommand - messages- add bll errors related to "linking feature" and Update command. - canDoAction- - Allow editing if the VM is Down. If "UnlinkingSupported" is false for the cluster compatibility version. - block 'null' network. - block unlinking. If "UnlinkingSupported" is true - allow 'null' network. Change-Id: I0ea914badc716f2908f45c020b53ced423ed23ec Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java 2 files changed, 180 insertions(+), 43 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ea914badc716f2908f45c020b53ced423ed23ec Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add NetworkLinking support to UpdateVmCommand
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add NetworkLinking support to UpdateVmCommand ...................................................................... core: Add NetworkLinking support to UpdateVmCommand - Avoid NPE in case there is a vnic with null network. Change-Id: I48c014629678f634593e81e584fcbbb6083fddc7 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48c014629678f634593e81e584fcbbb6083fddc7 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Rename HotPlugUnplgNicVDSParameters
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Rename HotPlugUnplgNicVDSParameters ...................................................................... engine: Rename HotPlugUnplgNicVDSParameters Renamed the parameters to VmNicDeviceVDSParameters so that they can be used in other commands that need the same combination of parameters. Change-Id: Ie9f956a2dc00cfded652682a39521bf901917369 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateDeactivateVmNicCommand.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmNicDeviceVDSParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotUnplugNicVDSCommand.java 4 files changed, 8 insertions(+), 8 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10269 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9f956a2dc00cfded652682a39521bf901917369 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: allow editing VmInterface while the VM is running.
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: allow editing VmInterface while the VM is running. ...................................................................... core: allow editing VmInterface while the VM is running. NetworkLinking feature allows editig a VM while it is UP. Change-Id: I6870491156f264079c60d63c0d9321e9b4364192 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6870491156f264079c60d63c0d9321e9b4364192 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding AbstractVmInterfaceCommand
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: adding AbstractVmInterfaceCommand ...................................................................... core: adding AbstractVmInterfaceCommand This command will contain common logic of VmIntrefaceCommands. For now, the logic of internaly calling activateNic (called from AddVmInterfaceCommnad and will be called from UpdateVmInterfaceCommanf in the future) was moved to AbstractVmInterfaceCommand. In the future other common logic can be placed here. Change-Id: I15acf7c715703582e96274f4621239b33d263172 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java 2 files changed, 45 insertions(+), 32 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15acf7c715703582e96274f4621239b33d263172 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : add NetwookLinking support to VmInterfaceManager
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core : add NetwookLinking support to VmInterfaceManager ...................................................................... core : add NetwookLinking support to VmInterfaceManager - Support the case when vm has vnic/s will null network. Change-Id: I16ef011a47efc6265787b845dc7af6fee5044578 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16ef011a47efc6265787b845dc7af6fee5044578 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: create UpdateVmInterfaceVDSCommand
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: create UpdateVmInterfaceVDSCommand ...................................................................... core: create UpdateVmInterfaceVDSCommand The command will be called from UpdateVmInterfaceCommand. It will be used to hot-update a vnic on a running vm. The fields that can be updated are- network linked (link state) Change-Id: Idc54fedde0fdf6ea9694fc19977bf1178e73efdf Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/UpdateVmInterfaceVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 6 files changed, 55 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc54fedde0fdf6ea9694fc19977bf1178e73efdf Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding VdsmError for failure on VmUpdateDevice on Vnic...
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: adding VdsmError for failure on VmUpdateDevice on Vnic. ...................................................................... core: adding VdsmError for failure on VmUpdateDevice on Vnic. If the vdsm fails to update the Vnic via VmUpdateDevice the error UPDATE_VNIC_FAILED (translated to- Failed to update VM Network Interface.) will be thrown. Change-Id: I8e081a127fb39fa5c188d9f6b17a5fe0ca52c25b Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 5 files changed, 8 insertions(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e081a127fb39fa5c188d9f6b17a5fe0ca52c25b Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: copy "linked" property on VmNetworkInterface clone...
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: copy "linked" property on VmNetworkInterface cloner. ...................................................................... webadmin: copy "linked" property on VmNetworkInterface cloner. "linked" boolean is a new property added to VmNetworkInterface. It should also be copied by the cloner. Change-Id: Ic00991d1919234716f6f984ba3f27af41d620786 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9801 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic00991d1919234716f6f984ba3f27af41d620786 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0